)]}'
{"keystone/api/os_inherit.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"65d810a4424e7417da84d1887060b8cdc3e7bc0c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    target \u003d {}"},{"line_number":57,"context_line":"    if role_id:"},{"line_number":58,"context_line":"        try:"},{"line_number":59,"context_line":"            target[\u0027role\u0027] \u003d PROVIDERS.role_api.get_role(role_id)"},{"line_number":60,"context_line":"        except exception.RoleNotFound:"},{"line_number":61,"context_line":"            LOG.info(\u0027Role (%(role_id)s) not found, Enforcement target of \u0027"},{"line_number":62,"context_line":"                     \u0027`role` remaind empty\u0027, {\u0027role_id\u0027: role_id})"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_de1532e7","line":59,"updated":"2018-08-28 19:04:31.000000000","message":"I left a similar comment on a previous patch set. We\u0027ll need to think about how we want to handle this because whatever we choose could impact how people maintain custom policy.\n\nIf we do something like:\n\n  target[\u0027role\u0027] \u003d PROVIDERS.role_api.get_role(role_id)\n\nThen operators will need to do:\n\n  role_id:%(target.role.id)s\n\nIf we do:\n\n  target \u003d PROVIDERS.role_api.get_role(role_id)\n\nThen they\u0027ll have to do:\n\n  role_id:%(target.id)s\n\nI\u0027m not sure there is a right or a wrong here so long as we are consistent so that people don\u0027t have to dig in code to figure out which one they need to use.","commit_id":"c0276b17a66a0dd1085e57e6ebe0b8dbe03e1ae3"}]}