)]}'
{"keystone/common/rbac_enforcer/enforcer.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a4a9a9498ad02489f7b3aa165793550dcbf8722b","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            try:"},{"line_number":319,"context_line":"                policy_dict.update(cls._extract_member_target_data("},{"line_number":320,"context_line":"                    member_target_type, member_target))"},{"line_number":321,"context_line":"            except Exception as e:  # nosec"},{"line_number":322,"context_line":"                # NOTE(morgan): Errors should never bubble up at this point,"},{"line_number":323,"context_line":"                # if there is an error getting the target, log it and move"},{"line_number":324,"context_line":"                # on. Missing values in the target dict means we cannot match"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_08096294","line":321,"updated":"2018-08-15 06:13:11.000000000","message":"Can we test this?","commit_id":"adf323ae37edd9817e2bf963db6d3ce4939970a3"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"fddd27d04c3ee9b051fd54d482d91f5c8a5b0370","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                # on it, and no value is by default safe."},{"line_number":326,"context_line":"                LOG.info(\u0027Unable to extract inferred target data during \u0027"},{"line_number":327,"context_line":"                         \u0027enforcement\u0027)"},{"line_number":328,"context_line":"                LOG.debug(e, exc_info\u003dTrue)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"            # Special Case, extract and add subject_token data."},{"line_number":331,"context_line":"            subj_token_target_data \u003d cls._extract_subject_token_target_data()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_9ae26da0","line":328,"updated":"2018-08-16 16:12:32.000000000","message":"Currently we exit out in an exception.  Now we will continue on.  Is that safe?","commit_id":"adf323ae37edd9817e2bf963db6d3ce4939970a3"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"e2c148c3325b839af4c4ed169d89071612f7acfa","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            try:"},{"line_number":319,"context_line":"                policy_dict.update(cls._extract_member_target_data("},{"line_number":320,"context_line":"                    member_target_type, member_target))"},{"line_number":321,"context_line":"            except Exception as e:  # nosec"},{"line_number":322,"context_line":"                # NOTE(morgan): Errors should never bubble up at this point,"},{"line_number":323,"context_line":"                # if there is an error getting the target, log it and move"},{"line_number":324,"context_line":"                # on. Raise an explicit 403, we have failed policy checks."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_e90376bd","line":321,"updated":"2018-08-18 12:25:41.000000000","message":"is there a more specific exception we can catch here?","commit_id":"e1381fe3f59965dd61ba843d3e26666516462c30"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"984264f6106a106454bf94678cba4a37c0b0cbbb","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            try:"},{"line_number":319,"context_line":"                policy_dict.update(cls._extract_member_target_data("},{"line_number":320,"context_line":"                    member_target_type, member_target))"},{"line_number":321,"context_line":"            except Exception as e:  # nosec"},{"line_number":322,"context_line":"                # NOTE(morgan): Errors should never bubble up at this point,"},{"line_number":323,"context_line":"                # if there is an error getting the target, log it and move"},{"line_number":324,"context_line":"                # on. Raise an explicit 403, we have failed policy checks."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_68d7e44c","line":321,"in_reply_to":"3f79a3b5_2e8386ab","updated":"2018-08-23 17:10:04.000000000","message":"I\u0027ll get a test spun up in a separate patch. Should ultimately be easy with the current RBACEnforcer framework.","commit_id":"e1381fe3f59965dd61ba843d3e26666516462c30"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0e4debe15b3b8da14b4439fd2bf7142205d19cad","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            try:"},{"line_number":319,"context_line":"                policy_dict.update(cls._extract_member_target_data("},{"line_number":320,"context_line":"                    member_target_type, member_target))"},{"line_number":321,"context_line":"            except Exception as e:  # nosec"},{"line_number":322,"context_line":"                # NOTE(morgan): Errors should never bubble up at this point,"},{"line_number":323,"context_line":"                # if there is an error getting the target, log it and move"},{"line_number":324,"context_line":"                # on. Raise an explicit 403, we have failed policy checks."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_2e8386ab","line":321,"in_reply_to":"3f79a3b5_43ec9e8e","updated":"2018-08-21 12:02:11.000000000","message":"Can we test this to make sure raised exceptions don\u0027t derail requests?","commit_id":"e1381fe3f59965dd61ba843d3e26666516462c30"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"924dc0d74b7d9b9d129dfdbba42205edb5e78a54","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            try:"},{"line_number":319,"context_line":"                policy_dict.update(cls._extract_member_target_data("},{"line_number":320,"context_line":"                    member_target_type, member_target))"},{"line_number":321,"context_line":"            except Exception as e:  # nosec"},{"line_number":322,"context_line":"                # NOTE(morgan): Errors should never bubble up at this point,"},{"line_number":323,"context_line":"                # if there is an error getting the target, log it and move"},{"line_number":324,"context_line":"                # on. Raise an explicit 403, we have failed policy checks."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_43ec9e8e","line":321,"in_reply_to":"3f79a3b5_e90376bd","updated":"2018-08-21 08:43:56.000000000","message":"emm, the generic Exception here seems OK due the NOTE and warning message below.","commit_id":"e1381fe3f59965dd61ba843d3e26666516462c30"}]}