)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"a3c00e5940c98edc8a6b5f119869ce24e4f5dfc5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The password should be changed when changing password"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When changing user password, the new password should be diffrent"},{"line_number":10,"context_line":"than the orignal one. Changing password in the way like PW1 -\u003e PW1"},{"line_number":11,"context_line":"is useless and meaningless."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_803165ef","line":9,"range":{"start_line":9,"start_character":56,"end_line":9,"end_character":64},"updated":"2018-08-20 10:11:14.000000000","message":"different.","commit_id":"49dc2e82fac2c8fc2075596e0962beb164bb8ca0"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"68110406aebd442da5556d8a66f9c2b875ee5a20","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The password should be changed when changing password"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When changing user password, the new password should be diffrent"},{"line_number":10,"context_line":"than the orignal one. Changing password in the way like PW1 -\u003e PW1"},{"line_number":11,"context_line":"is useless and meaningless."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_b63707e4","line":9,"range":{"start_line":9,"start_character":56,"end_line":9,"end_character":64},"in_reply_to":"3f79a3b5_803165ef","updated":"2018-08-20 11:21:08.000000000","message":"Done","commit_id":"49dc2e82fac2c8fc2075596e0962beb164bb8ca0"},{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"a3c00e5940c98edc8a6b5f119869ce24e4f5dfc5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is useless and meaningless."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id368c99ca4926c995ea47959a6c3a438fffe1823"},{"line_number":14,"context_line":"Cloese-Bug: #1787874"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_a03a61ca","line":14,"updated":"2018-08-20 10:11:14.000000000","message":"s/cloese/closes","commit_id":"49dc2e82fac2c8fc2075596e0962beb164bb8ca0"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"68110406aebd442da5556d8a66f9c2b875ee5a20","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is useless and meaningless."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id368c99ca4926c995ea47959a6c3a438fffe1823"},{"line_number":14,"context_line":"Cloese-Bug: #1787874"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_563473de","line":14,"in_reply_to":"3f79a3b5_a03a61ca","updated":"2018-08-20 11:21:08.000000000","message":"Done","commit_id":"49dc2e82fac2c8fc2075596e0962beb164bb8ca0"},{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"91816d87ae1afdff485e317a81ee04914387cd4b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"password history check only check one previous password."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id368c99ca4926c995ea47959a6c3a438fffe1823"},{"line_number":14,"context_line":"Cloese-Bug: #1787874"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f79a3b5_334e4d6f","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":7},"updated":"2018-08-23 04:22:24.000000000","message":"I think it still remains left.","commit_id":"5f366c31e6fb6c1f8b05bceffde083128b6527ee"}],"keystone/identity/backends/sql.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"70a60133a24f7eb78095f1a1dba83b6ff7830546","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        unique_cnt \u003d CONF.security_compliance.unique_last_password_count"},{"line_number":236,"context_line":"        # Slice off all of the extra passwords."},{"line_number":237,"context_line":"        user_ref.local_user.passwords \u003d ("},{"line_number":238,"context_line":"            user_ref.local_user.passwords[-unique_cnt:])"},{"line_number":239,"context_line":"        # Validate the new password against the remaining passwords."},{"line_number":240,"context_line":"        if unique_cnt \u003e 0:"},{"line_number":241,"context_line":"            for password_ref in user_ref.local_user.passwords:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_f8d474eb","line":238,"updated":"2018-08-21 10:17:09.000000000","message":"I think this won\u0027t work properly anymore:\n\n \u003e\u003e\u003e [\u0027x\u0027, \u0027y\u0027][-0:]\n [\u0027x\u0027, \u0027y\u0027]\n\nThe list will continue to expand without ever being truncated. Same here: http://git.openstack.org/cgit/openstack/keystone/tree/keystone/identity/backends/sql_model.py#n140","commit_id":"4b6828185891ceb3d17908b79be1a2d5a864f3d3"}],"releasenotes/notes/bug-1787874-13499ec227b8e26c.yaml":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"70a60133a24f7eb78095f1a1dba83b6ff7830546","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    when changing password, the new one should be different than the current"},{"line_number":9,"context_line":"    one."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    Please not that the deployment which set `unique_last_password_count \u003d 1`"},{"line_number":12,"context_line":"    in the config file should update the value to keep the same behavior as"},{"line_number":13,"context_line":"    before."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_78df043a","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":11},"updated":"2018-08-21 10:17:09.000000000","message":"I think this belongs in an upgrade: section since we\u0027re not giving a deprecation period and this is an action that deployers must take in order to keep compatibility.\n\nAnother possibility to avoid breaking deployers like this might be to add a new option like require_unique_new_password or something. Though I agree that fixing the default value here would probably be ideal.","commit_id":"4b6828185891ceb3d17908b79be1a2d5a864f3d3"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"b240001c4473a7abe810a5700f69eec713852916","unresolved":false,"context_lines":[{"line_number":11,"context_line":"upgrade:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    [`bug 1787874 \u003chttps://bugs.launchpad.net/keystone/+bug/1787874\u003e`_]"},{"line_number":14,"context_line":"    Please not that the deployment which set `unique_last_password_count \u003d 1`"},{"line_number":15,"context_line":"    in the config file should update the value to 0 to keep the same behavior"},{"line_number":16,"context_line":"    as before."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_966fe126","line":14,"range":{"start_line":14,"start_character":11,"end_line":14,"end_character":14},"updated":"2018-08-24 19:25:25.000000000","message":"note*","commit_id":"34609d557e68020c6a054282c4d206aaa26a0d67"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"b240001c4473a7abe810a5700f69eec713852916","unresolved":false,"context_lines":[{"line_number":11,"context_line":"upgrade:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    [`bug 1787874 \u003chttps://bugs.launchpad.net/keystone/+bug/1787874\u003e`_]"},{"line_number":14,"context_line":"    Please not that the deployment which set `unique_last_password_count \u003d 1`"},{"line_number":15,"context_line":"    in the config file should update the value to 0 to keep the same behavior"},{"line_number":16,"context_line":"    as before."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_3664cd49","line":14,"range":{"start_line":14,"start_character":41,"end_line":14,"end_character":44},"updated":"2018-08-24 19:25:25.000000000","message":"sets*","commit_id":"34609d557e68020c6a054282c4d206aaa26a0d67"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"ae6148f7e193efe36c76bee0eac3b6acd388e75a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"upgrade:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    [`bug 1787874 \u003chttps://bugs.launchpad.net/keystone/+bug/1787874\u003e`_]"},{"line_number":14,"context_line":"    Please not that the deployment which set `unique_last_password_count \u003d 1`"},{"line_number":15,"context_line":"    in the config file should update the value to 0 to keep the same behavior"},{"line_number":16,"context_line":"    as before."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f79a3b5_fed70722","line":14,"range":{"start_line":14,"start_character":11,"end_line":14,"end_character":14},"in_reply_to":"3f79a3b5_966fe126","updated":"2018-08-25 01:12:50.000000000","message":"oh, this should be updated. Thanks. https://review.openstack.org/#/c/596506/","commit_id":"34609d557e68020c6a054282c4d206aaa26a0d67"}]}