)]}'
{"id":"openstack%2Fkeystone~59547","triplet_id":"openstack%2Fkeystone~master~I0efbcce9abc23bf79eb970e441e5f7644b1c8453","project":"openstack/keystone","branch":"master","hashtags":[],"change_id":"I0efbcce9abc23bf79eb970e441e5f7644b1c8453","subject":"Revert \"Return a descriptive error message for controllers\"","status":"MERGED","created":"2013-12-02 21:18:38.000000000","updated":"2013-12-03 01:39:34.000000000","submitted":"2013-12-03 01:39:33.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"699dacf02ace8daf83cc0c76a0fa58554666c6ea","_number":59547,"virtual_id_number":59547,"owner":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":2,"date":"2013-12-03 01:39:33.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"all":[{"value":0,"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"value":2,"date":"2013-12-02 21:34:09.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":2,"date":"2013-12-02 21:20:13.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"all":[{"value":0,"date":"2013-12-02 21:19:42.000000000","_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"value":1,"date":"2013-12-02 21:34:09.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"date":"2013-12-02 21:20:13.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-12-02 21:20:13.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2013-12-02 21:34:09.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2013-12-03 01:39:33.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e574f3e3d215d2dbfb64bce3d67aea0452ff8ae8","author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"date":"2013-12-02 21:19:42.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ad15e49f53dea715915fca2c1e4f5f742d8ef957","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-12-02 21:19:49.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"bcf1a42d73377cb5c6d6924bd27e992674426444","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2013-12-02 21:20:13.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"a548353213458b18d1c3dd7bfa919591bf264dca","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2013-12-02 21:34:09.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"2f23cd7582778e3ef0a941249ed7046518b6c2d8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-02 21:34:43.000000000","message":"Patch Set 2:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"0133e6b72f6a33f3c3d30fe382b38b44f8539fca","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-02 22:34:15.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-keystone-pep8 http://logs.openstack.org/47/59547/2/check/gate-keystone-pep8/c837cac : SUCCESS in 2m 48s\n- gate-keystone-docs http://docs-draft.openstack.org/47/59547/2/check/gate-keystone-docs/d90b681/doc/build/html/ : SUCCESS in 4m 27s\n- gate-keystone-python26 http://logs.openstack.org/47/59547/2/check/gate-keystone-python26/8ed80cd : SUCCESS in 24m 25s\n- gate-keystone-python27 http://logs.openstack.org/47/59547/2/check/gate-keystone-python27/6c4517f : SUCCESS in 17m 23s\n- check-tempest-devstack-vm-full-default http://logs.openstack.org/47/59547/2/check/check-tempest-devstack-vm-full-default/7b46076 : SUCCESS in 50m 50s\n- check-tempest-devstack-vm-postgres-full-default http://logs.openstack.org/47/59547/2/check/check-tempest-devstack-vm-postgres-full-default/9243e3c : SUCCESS in 50m 38s\n- check-tempest-devstack-vm-neutron-default http://logs.openstack.org/47/59547/2/check/check-tempest-devstack-vm-neutron-default/03f5880 : SUCCESS in 41m 19s\n- gate-tempest-devstack-vm-large-ops-default http://logs.openstack.org/47/59547/2/check/gate-tempest-devstack-vm-large-ops-default/ac4c7ba : SUCCESS in 14m 04s\n- gate-tempest-devstack-vm-neutron-large-ops-default http://logs.openstack.org/47/59547/2/check/gate-tempest-devstack-vm-neutron-large-ops-default/9f80b98 : FAILURE in 19m 55s\n- check-grenade-devstack-vm http://logs.openstack.org/47/59547/2/check/check-grenade-devstack-vm/a6898b9 : SUCCESS in 22m 51s\n- check-swift-devstack-vm-functional-default http://logs.openstack.org/47/59547/2/check/check-swift-devstack-vm-functional-default/0b48b1a : FAILURE in 4m 47s\n","accounts_in_message":[],"_revision_number":2},{"id":"4231d46074ba6e7aeb42c8656bca0f4253906250","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-03 01:39:33.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- gate-keystone-docs http://docs-draft.openstack.org/47/59547/2/gate/gate-keystone-docs/f0a5e4d/doc/build/html/ : SUCCESS in 1m 07s\n- gate-keystone-pep8 http://logs.openstack.org/47/59547/2/gate/gate-keystone-pep8/e43da35 : SUCCESS in 1m 06s\n- gate-keystone-python26 http://logs.openstack.org/47/59547/2/gate/gate-keystone-python26/b891b91 : SUCCESS in 22m 43s\n- gate-keystone-python27 http://logs.openstack.org/47/59547/2/gate/gate-keystone-python27/ae91e62 : SUCCESS in 15m 08s\n- gate-tempest-dsvm-full http://logs.openstack.org/47/59547/2/gate/gate-tempest-dsvm-full/bcd4fbe : SUCCESS in 36m 10s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/47/59547/2/gate/gate-tempest-dsvm-postgres-full/eddb8cd : SUCCESS in 40m 40s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/47/59547/2/gate/gate-tempest-dsvm-neutron/06fba4b : SUCCESS in 29m 56s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/47/59547/2/gate/gate-tempest-dsvm-large-ops/022dbc9 : SUCCESS in 18m 59s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/47/59547/2/gate/gate-tempest-dsvm-neutron-large-ops/75b4275 : SUCCESS in 16m 07s\n- gate-grenade-dsvm http://logs.openstack.org/47/59547/2/gate/gate-grenade-dsvm/57e9d3c : SUCCESS in 28m 58s\n- gate-swift-dsvm-functional http://logs.openstack.org/47/59547/2/gate/gate-swift-dsvm-functional/e9a406b : SUCCESS in 12m 18s\n","accounts_in_message":[],"_revision_number":2},{"id":"699dacf02ace8daf83cc0c76a0fa58554666c6ea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-03 01:39:34.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"be069f646f92e8eb680fe081887459e31562047a","revisions":{"72b5adc8bec9c747135626c15237ef41446770c2":{"kind":"REWORK","_number":1,"created":"2013-12-02 21:18:38.000000000","uploader":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"ref":"refs/changes/47/59547/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/47/59547/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/47/59547/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/47/59547/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/47/59547/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/47/59547/1"}}},"commit":{"parents":[{"commit":"f72f36953870406a0dc24b2a868d2c640dcda230","subject":"Merge \"Return a descriptive error message for controllers\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/f72f36953870406a0dc24b2a868d2c640dcda230"}]}],"author":{"name":"David Stanek","email":"dstanek@dstanek.com","date":"2013-12-02 21:16:58.000000000","tz":0},"committer":{"name":"David Stanek","email":"dstanek@dstanek.com","date":"2013-12-02 21:18:24.000000000","tz":0},"subject":"Revert \"Return a descriptive error message for controllers\"","message":"Revert \"Return a descriptive error message for controllers\"\n\nThis reverts commit 6512c71a49c14e1a2f7a857a37b96883def57788.\n\nWhile this fixes the problem it doesn\u0027t do it in a comprehensive way.\nThe right way would be to implement real validation.\n\nThe reverted patch breaks on methods marked as deprecated because the\ndeprecated decorator is a function that accepts *args and **kwargs.\nThis bypasses the check and we go back to the same TypeError from the\noriginal bug.\n\nChange-Id: I0efbcce9abc23bf79eb970e441e5f7644b1c8453\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/72b5adc8bec9c747135626c15237ef41446770c2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/72b5adc8bec9c747135626c15237ef41446770c2"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f72f36953870406a0dc24b2a868d2c640dcda230","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"be069f646f92e8eb680fe081887459e31562047a":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2013-12-02 21:19:42.000000000","uploader":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"ref":"refs/changes/47/59547/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/47/59547/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/47/59547/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/47/59547/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/47/59547/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/47/59547/2"}}},"commit":{"parents":[{"commit":"f72f36953870406a0dc24b2a868d2c640dcda230","subject":"Merge \"Return a descriptive error message for controllers\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/f72f36953870406a0dc24b2a868d2c640dcda230"}]}],"author":{"name":"David Stanek","email":"dstanek@dstanek.com","date":"2013-12-02 21:16:58.000000000","tz":0},"committer":{"name":"David Stanek","email":"dstanek@dstanek.com","date":"2013-12-02 21:19:20.000000000","tz":0},"subject":"Revert \"Return a descriptive error message for controllers\"","message":"Revert \"Return a descriptive error message for controllers\"\n\nThis reverts commit 6512c71a49c14e1a2f7a857a37b96883def57788.\n\nWhile this fixes the problem it doesn\u0027t do it in a comprehensive way.\nThe right way would be to implement real validation.\n\nThe reverted patch breaks on methods marked as deprecated because the\ndeprecated decorator is a function that accepts *args and **kwargs.\nThis bypasses the check and we go back to the same TypeError from the\noriginal bug.\n\nRelated-Bug: #1149987\nChange-Id: I0efbcce9abc23bf79eb970e441e5f7644b1c8453\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/be069f646f92e8eb680fe081887459e31562047a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/be069f646f92e8eb680fe081887459e31562047a"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f72f36953870406a0dc24b2a868d2c640dcda230","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}