)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"35f778c5719c9d7008615bc16b101b5618eea38a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[0] https://review.openstack.org/#/c/591147/11/keystone/server/flask/common.py@938"},{"line_number":17,"context_line":"[1] http://logs.openstack.org/57/600257/7/check/patrole-admin/ea8c8d8/controller/logs/screen-keystone.txt.gz?level\u003dERROR#_Sep_15_04_26_35_127915"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ia645f06bde71b14dc41fdf248ce3dadb22b6af60"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_3e514931","line":18,"updated":"2018-09-17 07:28:47.000000000","message":"Partial-Bug: #1776504","commit_id":"cd593ebb33762381248b654c74e1bfd660925741"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e34bdee4d486b297654643edc0ee51ae7d1d00b4","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[0] https://review.openstack.org/#/c/591147/11/keystone/server/flask/common.py@938"},{"line_number":17,"context_line":"[1] http://logs.openstack.org/57/600257/7/check/patrole-admin/ea8c8d8/controller/logs/screen-keystone.txt.gz?level\u003dERROR#_Sep_15_04_26_35_127915"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ia645f06bde71b14dc41fdf248ce3dadb22b6af60"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_734a85ad","line":18,"in_reply_to":"3f79a3b5_3e514931","updated":"2018-09-17 23:27:07.000000000","message":"Done","commit_id":"cd593ebb33762381248b654c74e1bfd660925741"}],"keystone/tests/unit/server/test_keystone_flask.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"35f778c5719c9d7008615bc16b101b5618eea38a","unresolved":false,"context_lines":[{"line_number":548,"context_line":"                self.assertThat(resp_data[\u0027resources\u0027][rel],"},{"line_number":549,"context_line":"                                matchers.Equals(json_home_data[rel]))"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"class TestKeystoneFlaskGroups(rest.RestfulTestCase):"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_7e2021b1","line":551,"updated":"2018-09-17 07:28:47.000000000","message":"Instead of add a new group related test class here. I think you\u0027d better add them to test_v3_identity.py.\n\nHere you can just add a test for _get_domain_id_from_token in TestKeystoneFlaskCommon","commit_id":"cd593ebb33762381248b654c74e1bfd660925741"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"e34bdee4d486b297654643edc0ee51ae7d1d00b4","unresolved":false,"context_lines":[{"line_number":548,"context_line":"                self.assertThat(resp_data[\u0027resources\u0027][rel],"},{"line_number":549,"context_line":"                                matchers.Equals(json_home_data[rel]))"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"class TestKeystoneFlaskGroups(rest.RestfulTestCase):"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_13d1d1cc","line":551,"in_reply_to":"3f79a3b5_7e2021b1","updated":"2018-09-17 23:27:07.000000000","message":"I removed these tests as test_v3_identity.py already has good coverage and when I tried to call POST /groups without a domain_id in the body (i.e. to test some different branches in the _normalize_domain_id method) I got schema validation errors. While I could\u0027ve mocked that out, frankly the testing would\u0027ve been redundant anyway with the new tests I added to directly test _normalize_domain_id.","commit_id":"cd593ebb33762381248b654c74e1bfd660925741"}]}