)]}'
{"keystone/common/policies/domain.py":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"044d536f0b31315cf84073b6a46b39a1e2570b26","unresolved":false,"context_lines":[{"line_number":44,"context_line":")"},{"line_number":45,"context_line":"SYSTEM_USER_OR_DOMAIN_USER_OR_PROJECT_USER \u003d ("},{"line_number":46,"context_line":"    \u0027(role:reader and system_scope:all) or \u0027"},{"line_number":47,"context_line":"    \u0027token.domain.id:%(target.domain.id)s or \u0027"},{"line_number":48,"context_line":"    \u0027token.project.domain.id:%(target.domain.id)s\u0027"},{"line_number":49,"context_line":")"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_75e4b70e","line":47,"updated":"2018-09-28 23:04:28.000000000","message":"In the past we had an exception thrown when we checked for a non-existent value like this.  If we sent a project scoped token, the token.domain key would not exists, and the whole check would fail.  Did we fix this somehow?","commit_id":"d7b6dcedde717ff6ef74aaf7b4318e7958a800d5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"daba0903a05074a6f32dc3b27df22c358fe3888c","unresolved":false,"context_lines":[{"line_number":44,"context_line":")"},{"line_number":45,"context_line":"SYSTEM_USER_OR_DOMAIN_USER_OR_PROJECT_USER \u003d ("},{"line_number":46,"context_line":"    \u0027(role:reader and system_scope:all) or \u0027"},{"line_number":47,"context_line":"    \u0027token.domain.id:%(target.domain.id)s or \u0027"},{"line_number":48,"context_line":"    \u0027token.project.domain.id:%(target.domain.id)s\u0027"},{"line_number":49,"context_line":")"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ce071981","line":47,"in_reply_to":"3f79a3b5_75e4b70e","updated":"2018-10-12 19:12:52.000000000","message":"Technically - this same check is being used in the tests here, which would fail. I don\u0027t think this is failing because it\u0027s OR logic.\n\nhttps://review.openstack.org/#/c/605851/2/keystone/tests/unit/protection/v3/test_domains.py@438","commit_id":"d7b6dcedde717ff6ef74aaf7b4318e7958a800d5"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"caf56b399c09dbd90b1f82f669183d37524a1bac","unresolved":false,"context_lines":[{"line_number":46,"context_line":"SYSTEM_USER_OR_DOMAIN_USER_OR_PROJECT_USER \u003d ("},{"line_number":47,"context_line":"    \u0027(role:reader and system_scope:all) or \u0027"},{"line_number":48,"context_line":"    \u0027token.domain.id:%(target.domain.id)s or \u0027"},{"line_number":49,"context_line":"    \u0027token.project.domain.id:%(target.domain.id)s\u0027"},{"line_number":50,"context_line":")"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bfdaf3ff_33eb52b1","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":30},"updated":"2019-01-10 19:11:53.000000000","message":"should be \u0027token.project.domain_id\u0027 or \u0027project_domain_id\u0027. See https://bugs.launchpad.net/keystone/+bug/1810983","commit_id":"90e2041aca821310bdec6363197ffcb76f290030"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"f4d75b3dbb230861baf2fa4a4954b5019df417fa","unresolved":false,"context_lines":[{"line_number":46,"context_line":"SYSTEM_USER_OR_DOMAIN_USER_OR_PROJECT_USER \u003d ("},{"line_number":47,"context_line":"    \u0027(role:reader and system_scope:all) or \u0027"},{"line_number":48,"context_line":"    \u0027token.domain.id:%(target.domain.id)s or \u0027"},{"line_number":49,"context_line":"    \u0027token.project.domain.id:%(target.domain.id)s\u0027"},{"line_number":50,"context_line":")"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bfdaf3ff_39e1f3ff","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":30},"in_reply_to":"bfdaf3ff_33eb52b1","updated":"2019-01-10 21:25:46.000000000","message":"Please ignore my previous comment. Looks like \u0027token.project.domain.id\u0027 will work as we added the token dict back here.\n\nhttps://github.com/openstack/keystone/blob/master/keystone/common/context.py#L65","commit_id":"90e2041aca821310bdec6363197ffcb76f290030"}]}