)]}'
{"keystone/cmd/cli.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"5519695dc319fee7d51985fcea1e3c1b8d183201","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"                                          tester.rules[\u0027rules\u0027])"},{"line_number":1092,"context_line":"        mapped \u003d rp.process(tester.assertion)"},{"line_number":1093,"context_line":"        print(jsonutils.dumps(mapped, indent\u003d2))"},{"line_number":1094,"context_line":"        return mapped"},{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"    @classmethod"},{"line_number":1097,"context_line":"    def add_argument_parser(cls, subparsers):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d886b4ba","line":1094,"updated":"2018-10-04 13:43:40.000000000","message":"I would prefer if the functionality of the main() function wasn\u0027t changed with the enhancements to this test. If we are checking the value of mapped rather than the content of stdout, we\u0027re really testing the RuleProcessor.process method, which is already tested elsewhere, rather than testing the CLI.\n\nTo check the stdout, you can follow examples like this: http://git.openstack.org/cgit/openstack/keystone/tree/keystone/tests/unit/test_cli.py#n575","commit_id":"49ff3a87cb953bb549086ccaeb3c5c2998f542a5"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"8d07057f0592450c5170981d263f0599fc314fe4","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"                                          tester.rules[\u0027rules\u0027])"},{"line_number":1092,"context_line":"        mapped \u003d rp.process(tester.assertion)"},{"line_number":1093,"context_line":"        print(jsonutils.dumps(mapped, indent\u003d2))"},{"line_number":1094,"context_line":"        return mapped"},{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"    @classmethod"},{"line_number":1097,"context_line":"    def add_argument_parser(cls, subparsers):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_34afa59e","line":1094,"in_reply_to":"3f79a3b5_212e098d","updated":"2018-10-17 14:12:22.000000000","message":"I\u0027m with Colleen here.\n\nDon\u0027t return from this function.  Check the output.  You can check for existence of each of the values using a substring search. Or You can use JSON to parse the output, which is what an end user would probably do anyway.","commit_id":"49ff3a87cb953bb549086ccaeb3c5c2998f542a5"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"ffe382bf5ef4ed145cad972d9f7c9f88dfdee7a5","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"                                          tester.rules[\u0027rules\u0027])"},{"line_number":1092,"context_line":"        mapped \u003d rp.process(tester.assertion)"},{"line_number":1093,"context_line":"        print(jsonutils.dumps(mapped, indent\u003d2))"},{"line_number":1094,"context_line":"        return mapped"},{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"    @classmethod"},{"line_number":1097,"context_line":"    def add_argument_parser(cls, subparsers):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_212e098d","line":1094,"in_reply_to":"3f79a3b5_a9227ba5","updated":"2018-10-11 08:42:56.000000000","message":"Hi Colleen,I used the approach of mocking prints to check stdout. As there are 3 prints in the mock_call containing Json object. It is difficult to match the expected with the actual as you can see in [1].Due to the different key positions the matching is failed.\n\nSo I asserted a mock_count in code to confirm that all 3 prints are there but not able to validate stdout. Suggestions Pl?\nThanks\n\n[1] http://paste.openstack.org/show/731879/","commit_id":"49ff3a87cb953bb549086ccaeb3c5c2998f542a5"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"76aba25ed8daff3fac49471e7063e3d2e7672b76","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"                                          tester.rules[\u0027rules\u0027])"},{"line_number":1092,"context_line":"        mapped \u003d rp.process(tester.assertion)"},{"line_number":1093,"context_line":"        print(jsonutils.dumps(mapped, indent\u003d2))"},{"line_number":1094,"context_line":"        return mapped"},{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"    @classmethod"},{"line_number":1097,"context_line":"    def add_argument_parser(cls, subparsers):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a9227ba5","line":1094,"in_reply_to":"3f79a3b5_c69484ea","updated":"2018-10-05 08:16:45.000000000","message":"stdout \u003d \"standard output\", the output stream that print() prints to. We want to check that what the user sees is working properly, not just that the internal object has the right content.","commit_id":"49ff3a87cb953bb549086ccaeb3c5c2998f542a5"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"170e7d68ffd85a21da6304f5764be727af07eb5c","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"                                          tester.rules[\u0027rules\u0027])"},{"line_number":1092,"context_line":"        mapped \u003d rp.process(tester.assertion)"},{"line_number":1093,"context_line":"        print(jsonutils.dumps(mapped, indent\u003d2))"},{"line_number":1094,"context_line":"        return mapped"},{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"    @classmethod"},{"line_number":1097,"context_line":"    def add_argument_parser(cls, subparsers):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c69484ea","line":1094,"in_reply_to":"3f79a3b5_d886b4ba","updated":"2018-10-05 08:07:15.000000000","message":"I did not get the clear meaning of stdout. Can you pl give a little brief?","commit_id":"49ff3a87cb953bb549086ccaeb3c5c2998f542a5"}]}