)]}'
{"doc/source/admin/identity-use-trusts.rst":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"c75afeae8d1196baa8edfc764315735cce8b463e","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Options (optional):"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        project-id \u003cstring\u003e: To purge trusts of given project-id."},{"line_number":70,"context_line":"        trustor-user-id \u003cstring\u003e: To purge trusts of given trustor-id."},{"line_number":71,"context_line":"        trustee-user-id \u003cstring\u003e: To purge trusts of given trustee-id."},{"line_number":72,"context_line":"        date \u003cstring\u003e: To purge trusts older than date."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_3e299b39","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":18},"updated":"2018-10-08 07:42:15.000000000","message":"--project-id","commit_id":"3a617f6bc2d67225967770cbee095a9b6b42c16b"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"c8d9afa1e80a6132a14989d1bc0754fe80e9c705","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Options (optional):"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        project-id \u003cstring\u003e: To purge trusts of given project-id."},{"line_number":70,"context_line":"        trustor-user-id \u003cstring\u003e: To purge trusts of given trustor-id."},{"line_number":71,"context_line":"        trustee-user-id \u003cstring\u003e: To purge trusts of given trustee-id."},{"line_number":72,"context_line":"        date \u003cstring\u003e: To purge trusts older than date."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_194624a9","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":18},"in_reply_to":"3f79a3b5_3e299b39","updated":"2018-10-09 02:58:13.000000000","message":"done","commit_id":"3a617f6bc2d67225967770cbee095a9b6b42c16b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1613ed44c7dfd311f9139d398f23177371e81b15","unresolved":false,"context_lines":[{"line_number":62,"context_line":"In the SQL trust stores expired and soft deleted trusts, that are not"},{"line_number":63,"context_line":"automatically removed. These trusts can be removed with::"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    $ keystone-manage trust_flush [Options]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Options (optional):"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_1e00b8ff","line":65,"range":{"start_line":65,"start_character":35,"end_line":65,"end_character":36},"updated":"2018-10-15 20:09:28.000000000","message":"options* just to be consistent with the documentation in /cli \n\nhttps://docs.openstack.org/keystone/latest/cli/index.html#keystone-manage","commit_id":"edbff5fd6efc19f544d757d1379f08cef2c6add3"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"51071bad089ab7b96f129b72370e8397539c66df","unresolved":false,"context_lines":[{"line_number":62,"context_line":"In the SQL trust stores expired and soft deleted trusts, that are not"},{"line_number":63,"context_line":"automatically removed. These trusts can be removed with::"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    $ keystone-manage trust_flush [Options]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Options (optional):"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_2e9e7bb7","line":65,"range":{"start_line":65,"start_character":35,"end_line":65,"end_character":36},"in_reply_to":"3f79a3b5_1e00b8ff","updated":"2018-10-17 10:07:14.000000000","message":"Done","commit_id":"edbff5fd6efc19f544d757d1379f08cef2c6add3"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"3ccf30361ac28d993826178edfc79d3fecf12356","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        --trustee-user-id \u003cstring\u003e:"},{"line_number":74,"context_line":"                    To purge trusts of given trustee-id."},{"line_number":75,"context_line":"        --date \u003cstring\u003e:"},{"line_number":76,"context_line":"                    To purge trusts older than date.It will purge"},{"line_number":77,"context_line":"                    trusts older than current if date not given."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_fe3a4395","line":76,"range":{"start_line":76,"start_character":52,"end_line":76,"end_character":53},"updated":"2018-10-19 00:29:12.000000000","message":"NIT: need a space after the period.","commit_id":"77bb2af3318e238a22a8f88b3741d45e8d7539d3"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"c625cf95f52aceacab157a7593b5ad4cbc216430","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        --trustee-user-id \u003cstring\u003e:"},{"line_number":74,"context_line":"                    To purge trusts of given trustee-id."},{"line_number":75,"context_line":"        --date \u003cstring\u003e:"},{"line_number":76,"context_line":"                    To purge trusts older than date.It will purge"},{"line_number":77,"context_line":"                    trusts older than current if date not given."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_8381564f","line":76,"range":{"start_line":76,"start_character":52,"end_line":76,"end_character":53},"in_reply_to":"3f79a3b5_fe3a4395","updated":"2018-10-22 02:48:04.000000000","message":"Done","commit_id":"77bb2af3318e238a22a8f88b3741d45e8d7539d3"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"dff2acaf8f4c7cf5829d0c1d6b22d1bb60ce2a11","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                    To purge trusts of given trustee-id."},{"line_number":75,"context_line":"        --date \u003cstring\u003e:"},{"line_number":76,"context_line":"                    To purge trusts older than date. If no date is supplied"},{"line_number":77,"context_line":"                    keystone-manage will use the system clock time at runtime."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_ef73414e","line":77,"range":{"start_line":77,"start_character":36,"end_line":77,"end_character":78},"updated":"2018-10-22 16:03:21.000000000","message":"Look at my other comment.","commit_id":"9f256d33e5f62d3fbf107c39347ef20ad1ab436d"}],"keystone/cmd/cli.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"c75afeae8d1196baa8edfc764315735cce8b463e","unresolved":false,"context_lines":[{"line_number":695,"context_line":"                            help\u003d(\u0027The id of the trustee of which the trusts\u0027"},{"line_number":696,"context_line":"                                  \u0027 is to be purged\u0027))"},{"line_number":697,"context_line":"        parser.add_argument(\u0027--date\u0027, default\u003dNone,"},{"line_number":698,"context_line":"                            help\u003d(\u0027The date of which the trusts older than \u0027"},{"line_number":699,"context_line":"                                  \u0027that will be purged. The format of the date\u0027"},{"line_number":700,"context_line":"                                  \u0027to be \"DD-MM-YYYY\"\u0027))"},{"line_number":701,"context_line":"        return parser"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1e993f6c","line":700,"range":{"start_line":698,"start_character":34,"end_line":700,"end_character":53},"updated":"2018-10-08 07:42:15.000000000","message":"we should add more that if \"--date\" is not provided, it will purge the trust older than current.","commit_id":"3a617f6bc2d67225967770cbee095a9b6b42c16b"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"c8d9afa1e80a6132a14989d1bc0754fe80e9c705","unresolved":false,"context_lines":[{"line_number":695,"context_line":"                            help\u003d(\u0027The id of the trustee of which the trusts\u0027"},{"line_number":696,"context_line":"                                  \u0027 is to be purged\u0027))"},{"line_number":697,"context_line":"        parser.add_argument(\u0027--date\u0027, default\u003dNone,"},{"line_number":698,"context_line":"                            help\u003d(\u0027The date of which the trusts older than \u0027"},{"line_number":699,"context_line":"                                  \u0027that will be purged. The format of the date\u0027"},{"line_number":700,"context_line":"                                  \u0027to be \"DD-MM-YYYY\"\u0027))"},{"line_number":701,"context_line":"        return parser"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_99cf9427","line":700,"range":{"start_line":698,"start_character":34,"end_line":700,"end_character":53},"in_reply_to":"3f79a3b5_1e993f6c","updated":"2018-10-09 02:58:13.000000000","message":"done","commit_id":"3a617f6bc2d67225967770cbee095a9b6b42c16b"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"d20dede11ed64e90028ba4721e0bc8cc1b29e87b","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        parser.add_argument(\u0027--trustee-user-id\u0027, default\u003dNone,"},{"line_number":695,"context_line":"                            help\u003d(\u0027The id of the trustee of which the trusts\u0027"},{"line_number":696,"context_line":"                                  \u0027 is to be purged\u0027))"},{"line_number":697,"context_line":"        parser.add_argument(\u0027--date\u0027, default\u003dNone,"},{"line_number":698,"context_line":"                            help\u003d(\u0027The date of which the trusts older than \u0027"},{"line_number":699,"context_line":"                                  \u0027that will be purged. The format of the date\u0027"},{"line_number":700,"context_line":"                                  \u0027to be \"DD-MM-YYYY\". If \"--date\" is not \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_21b12946","line":697,"range":{"start_line":697,"start_character":15,"end_line":697,"end_character":27},"updated":"2018-10-11 08:46:34.000000000","message":"I wonder if add_argument support date format by default? If so, we can make the code cleaner.","commit_id":"edbff5fd6efc19f544d757d1379f08cef2c6add3"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1613ed44c7dfd311f9139d398f23177371e81b15","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        parser.add_argument(\u0027--trustee-user-id\u0027, default\u003dNone,"},{"line_number":695,"context_line":"                            help\u003d(\u0027The id of the trustee of which the trusts\u0027"},{"line_number":696,"context_line":"                                  \u0027 is to be purged\u0027))"},{"line_number":697,"context_line":"        parser.add_argument(\u0027--date\u0027, default\u003dNone,"},{"line_number":698,"context_line":"                            help\u003d(\u0027The date of which the trusts older than \u0027"},{"line_number":699,"context_line":"                                  \u0027that will be purged. The format of the date\u0027"},{"line_number":700,"context_line":"                                  \u0027to be \"DD-MM-YYYY\". If \"--date\" is not \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_3ba58648","line":697,"range":{"start_line":697,"start_character":46,"end_line":697,"end_character":50},"updated":"2018-10-15 20:09:28.000000000","message":"This could be datetime.datetime.utcnow() couldn\u0027t it?","commit_id":"edbff5fd6efc19f544d757d1379f08cef2c6add3"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"51071bad089ab7b96f129b72370e8397539c66df","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        parser.add_argument(\u0027--trustee-user-id\u0027, default\u003dNone,"},{"line_number":695,"context_line":"                            help\u003d(\u0027The id of the trustee of which the trusts\u0027"},{"line_number":696,"context_line":"                                  \u0027 is to be purged\u0027))"},{"line_number":697,"context_line":"        parser.add_argument(\u0027--date\u0027, default\u003dNone,"},{"line_number":698,"context_line":"                            help\u003d(\u0027The date of which the trusts older than \u0027"},{"line_number":699,"context_line":"                                  \u0027that will be purged. The format of the date\u0027"},{"line_number":700,"context_line":"                                  \u0027to be \"DD-MM-YYYY\". If \"--date\" is not \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_8e822f51","line":697,"range":{"start_line":697,"start_character":46,"end_line":697,"end_character":50},"in_reply_to":"3f79a3b5_3ba58648","updated":"2018-10-17 10:07:14.000000000","message":"Thanks for this suggestion. Done","commit_id":"edbff5fd6efc19f544d757d1379f08cef2c6add3"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1613ed44c7dfd311f9139d398f23177371e81b15","unresolved":false,"context_lines":[{"line_number":696,"context_line":"                                  \u0027 is to be purged\u0027))"},{"line_number":697,"context_line":"        parser.add_argument(\u0027--date\u0027, default\u003dNone,"},{"line_number":698,"context_line":"                            help\u003d(\u0027The date of which the trusts older than \u0027"},{"line_number":699,"context_line":"                                  \u0027that will be purged. The format of the date\u0027"},{"line_number":700,"context_line":"                                  \u0027to be \"DD-MM-YYYY\". If \"--date\" is not \u0027"},{"line_number":701,"context_line":"                                  \u0027provided, it will purge the trusts older \u0027"},{"line_number":702,"context_line":"                                  \u0027than current.\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_fbbb8e71","line":699,"range":{"start_line":699,"start_character":74,"end_line":699,"end_character":78},"updated":"2018-10-15 20:09:28.000000000","message":"nit: missing a space here","commit_id":"edbff5fd6efc19f544d757d1379f08cef2c6add3"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"51071bad089ab7b96f129b72370e8397539c66df","unresolved":false,"context_lines":[{"line_number":696,"context_line":"                                  \u0027 is to be purged\u0027))"},{"line_number":697,"context_line":"        parser.add_argument(\u0027--date\u0027, default\u003dNone,"},{"line_number":698,"context_line":"                            help\u003d(\u0027The date of which the trusts older than \u0027"},{"line_number":699,"context_line":"                                  \u0027that will be purged. The format of the date\u0027"},{"line_number":700,"context_line":"                                  \u0027to be \"DD-MM-YYYY\". If \"--date\" is not \u0027"},{"line_number":701,"context_line":"                                  \u0027provided, it will purge the trusts older \u0027"},{"line_number":702,"context_line":"                                  \u0027than current.\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_2e775b91","line":699,"range":{"start_line":699,"start_character":74,"end_line":699,"end_character":78},"in_reply_to":"3f79a3b5_fbbb8e71","updated":"2018-10-17 10:07:14.000000000","message":"Done","commit_id":"edbff5fd6efc19f544d757d1379f08cef2c6add3"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1613ed44c7dfd311f9139d398f23177371e81b15","unresolved":false,"context_lines":[{"line_number":697,"context_line":"        parser.add_argument(\u0027--date\u0027, default\u003dNone,"},{"line_number":698,"context_line":"                            help\u003d(\u0027The date of which the trusts older than \u0027"},{"line_number":699,"context_line":"                                  \u0027that will be purged. The format of the date\u0027"},{"line_number":700,"context_line":"                                  \u0027to be \"DD-MM-YYYY\". If \"--date\" is not \u0027"},{"line_number":701,"context_line":"                                  \u0027provided, it will purge the trusts older \u0027"},{"line_number":702,"context_line":"                                  \u0027than current.\u0027))"},{"line_number":703,"context_line":"        return parser"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_fb494e8d","line":702,"range":{"start_line":700,"start_character":55,"end_line":702,"end_character":49},"updated":"2018-10-15 20:09:28.000000000","message":"minor wording nit:\n\nIf no date is supplied, keystone-manage will use the system clock time at runtime.","commit_id":"edbff5fd6efc19f544d757d1379f08cef2c6add3"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"51071bad089ab7b96f129b72370e8397539c66df","unresolved":false,"context_lines":[{"line_number":697,"context_line":"        parser.add_argument(\u0027--date\u0027, default\u003dNone,"},{"line_number":698,"context_line":"                            help\u003d(\u0027The date of which the trusts older than \u0027"},{"line_number":699,"context_line":"                                  \u0027that will be purged. The format of the date\u0027"},{"line_number":700,"context_line":"                                  \u0027to be \"DD-MM-YYYY\". If \"--date\" is not \u0027"},{"line_number":701,"context_line":"                                  \u0027provided, it will purge the trusts older \u0027"},{"line_number":702,"context_line":"                                  \u0027than current.\u0027))"},{"line_number":703,"context_line":"        return parser"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_4e7c1771","line":702,"range":{"start_line":700,"start_character":55,"end_line":702,"end_character":49},"in_reply_to":"3f79a3b5_fb494e8d","updated":"2018-10-17 10:07:14.000000000","message":"Done","commit_id":"edbff5fd6efc19f544d757d1379f08cef2c6add3"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1613ed44c7dfd311f9139d398f23177371e81b15","unresolved":false,"context_lines":[{"line_number":711,"context_line":"                CONF.command.date \u003d datetime.datetime.strptime("},{"line_number":712,"context_line":"                    CONF.command.date, \u0027%d-%m-%Y\u0027)"},{"line_number":713,"context_line":"            except KeyError:"},{"line_number":714,"context_line":"                raise ValueError(\"\u0027%s\u0027Invalid input for date,should be \""},{"line_number":715,"context_line":"                                 \"DD-MM-YYYY\", CONF.command.date)"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"        trust_manager.flush_expired_and_soft_deleted_trusts("}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_3bf7c65c","line":714,"range":{"start_line":714,"start_character":61,"end_line":714,"end_character":67},"updated":"2018-10-15 20:09:28.000000000","message":"nit: missing a space here","commit_id":"edbff5fd6efc19f544d757d1379f08cef2c6add3"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"51071bad089ab7b96f129b72370e8397539c66df","unresolved":false,"context_lines":[{"line_number":711,"context_line":"                CONF.command.date \u003d datetime.datetime.strptime("},{"line_number":712,"context_line":"                    CONF.command.date, \u0027%d-%m-%Y\u0027)"},{"line_number":713,"context_line":"            except KeyError:"},{"line_number":714,"context_line":"                raise ValueError(\"\u0027%s\u0027Invalid input for date,should be \""},{"line_number":715,"context_line":"                                 \"DD-MM-YYYY\", CONF.command.date)"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"        trust_manager.flush_expired_and_soft_deleted_trusts("}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_ee90839a","line":714,"range":{"start_line":714,"start_character":61,"end_line":714,"end_character":67},"in_reply_to":"3f79a3b5_3bf7c65c","updated":"2018-10-17 10:07:14.000000000","message":"Done","commit_id":"edbff5fd6efc19f544d757d1379f08cef2c6add3"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"3ccf30361ac28d993826178edfc79d3fecf12356","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        parser \u003d super(TrustFlush, cls).add_argument_parser(subparsers)"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        parser.add_argument(\u0027--project-id\u0027, default\u003dNone,"},{"line_number":689,"context_line":"                            help\u003d(\u0027The id of the project of which the trusts \u0027"},{"line_number":690,"context_line":"                                  \u0027is to be purged\u0027))"},{"line_number":691,"context_line":"        parser.add_argument(\u0027--trustor-user-id\u0027, default\u003dNone,"},{"line_number":692,"context_line":"                            help\u003d(\u0027The id of the trustor of which the trusts \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_be44cb1b","line":689,"range":{"start_line":689,"start_character":28,"end_line":689,"end_character":78},"updated":"2018-10-19 00:29:12.000000000","message":"Please add back in \"expired\" and/or qualify that only expired/soft-deleted trusts will be purged.","commit_id":"77bb2af3318e238a22a8f88b3741d45e8d7539d3"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"c625cf95f52aceacab157a7593b5ad4cbc216430","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        parser \u003d super(TrustFlush, cls).add_argument_parser(subparsers)"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        parser.add_argument(\u0027--project-id\u0027, default\u003dNone,"},{"line_number":689,"context_line":"                            help\u003d(\u0027The id of the project of which the trusts \u0027"},{"line_number":690,"context_line":"                                  \u0027is to be purged\u0027))"},{"line_number":691,"context_line":"        parser.add_argument(\u0027--trustor-user-id\u0027, default\u003dNone,"},{"line_number":692,"context_line":"                            help\u003d(\u0027The id of the trustor of which the trusts \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_2378827c","line":689,"range":{"start_line":689,"start_character":28,"end_line":689,"end_character":78},"in_reply_to":"3f79a3b5_be44cb1b","updated":"2018-10-22 02:48:04.000000000","message":"Done","commit_id":"77bb2af3318e238a22a8f88b3741d45e8d7539d3"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"dff2acaf8f4c7cf5829d0c1d6b22d1bb60ce2a11","unresolved":false,"context_lines":[{"line_number":719,"context_line":"                    raise ValueError(\"\u0027%s\u0027Invalid input for date, should be \""},{"line_number":720,"context_line":"                                     \"DD-MM-YYYY\", CONF.command.date)"},{"line_number":721,"context_line":"        else:"},{"line_number":722,"context_line":"            raise ValueError(\"Valid date is to be provided to purge \""},{"line_number":723,"context_line":"                             \"the trusts \")"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        trust_manager.flush_expired_and_soft_deleted_trusts("}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_6f889120","line":722,"updated":"2018-10-22 16:03:21.000000000","message":"This is now not matching the documentation. the documentation says that if no date is supplied it will use utcnow().","commit_id":"9f256d33e5f62d3fbf107c39347ef20ad1ab436d"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"7cc187e10107ec5e2d022c6aa7cfbffd41db4809","unresolved":false,"context_lines":[{"line_number":719,"context_line":"                    raise ValueError(\"\u0027%s\u0027Invalid input for date, should be \""},{"line_number":720,"context_line":"                                     \"DD-MM-YYYY\", CONF.command.date)"},{"line_number":721,"context_line":"        else:"},{"line_number":722,"context_line":"            raise ValueError(\"Valid date is to be provided to purge \""},{"line_number":723,"context_line":"                             \"the trusts \")"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        trust_manager.flush_expired_and_soft_deleted_trusts("}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_3b2f2da7","line":722,"in_reply_to":"3f79a3b5_1596c0a1","updated":"2018-10-23 06:13:30.000000000","message":"Yep, perfect just report using date XXX (utcnow())","commit_id":"9f256d33e5f62d3fbf107c39347ef20ad1ab436d"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"552451144db543c215bcf388606449a2dd7f675c","unresolved":false,"context_lines":[{"line_number":719,"context_line":"                    raise ValueError(\"\u0027%s\u0027Invalid input for date, should be \""},{"line_number":720,"context_line":"                                     \"DD-MM-YYYY\", CONF.command.date)"},{"line_number":721,"context_line":"        else:"},{"line_number":722,"context_line":"            raise ValueError(\"Valid date is to be provided to purge \""},{"line_number":723,"context_line":"                             \"the trusts \")"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        trust_manager.flush_expired_and_soft_deleted_trusts("}],"source_content_type":"text/x-python","patch_set":7,"id":"3f79a3b5_1596c0a1","line":722,"in_reply_to":"3f79a3b5_6f889120","updated":"2018-10-23 02:21:36.000000000","message":"Since the parameter date is having its default value with utcnow(), should I just log a message \"The current utc will be used \"here and remove the exception?? or Dont do anything?","commit_id":"9f256d33e5f62d3fbf107c39347ef20ad1ab436d"}],"keystone/tests/unit/trust/test_backends.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"3a028ab72284694d76323f96f68321665d78ba4f","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        trust_data \u003d PROVIDERS.trust_api.create_trust(trust_ref2[\u0027id\u0027],"},{"line_number":499,"context_line":"                                                      trust_ref2, roles)"},{"line_number":500,"context_line":"        self.assertIsNotNone(trust_data)"},{"line_number":501,"context_line":"        PROVIDERS.trust_api.delete_trust(trust_ref2[\u0027id\u0027])"},{"line_number":502,"context_line":"        trust_data \u003d PROVIDERS.trust_api.create_trust(trust_ref3[\u0027id\u0027],"},{"line_number":503,"context_line":"                                                      trust_ref3, roles)"},{"line_number":504,"context_line":"        self.assertIsNotNone(trust_data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4a190085","line":501,"range":{"start_line":501,"start_character":0,"end_line":501,"end_character":58},"updated":"2018-10-10 06:30:26.000000000","message":"it\u0027s interesting here. You created trust, then deleted it. Why?","commit_id":"072cecafcb49822625a373ded30960f1b45c051f"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"3e93a745c382add30b355113559968f5d1f70dbb","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        trust_data \u003d PROVIDERS.trust_api.create_trust(trust_ref2[\u0027id\u0027],"},{"line_number":499,"context_line":"                                                      trust_ref2, roles)"},{"line_number":500,"context_line":"        self.assertIsNotNone(trust_data)"},{"line_number":501,"context_line":"        PROVIDERS.trust_api.delete_trust(trust_ref2[\u0027id\u0027])"},{"line_number":502,"context_line":"        trust_data \u003d PROVIDERS.trust_api.create_trust(trust_ref3[\u0027id\u0027],"},{"line_number":503,"context_line":"                                                      trust_ref3, roles)"},{"line_number":504,"context_line":"        self.assertIsNotNone(trust_data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7bb4cc36","line":501,"range":{"start_line":501,"start_character":0,"end_line":501,"end_character":58},"in_reply_to":"3f79a3b5_4a190085","updated":"2018-10-10 07:55:48.000000000","message":"Sorry. That was by mistake. Removed in new patch.","commit_id":"072cecafcb49822625a373ded30960f1b45c051f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"3ccf30361ac28d993826178edfc79d3fecf12356","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                                                      trust_ref2, roles)"},{"line_number":207,"context_line":"        self.assertIsNotNone(trust_data)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        PROVIDERS.trust_api.flush_expired_and_soft_deleted_trusts("},{"line_number":210,"context_line":"            date\u003ddatetime.datetime.utcnow())"},{"line_number":211,"context_line":"        trusts \u003d self.trust_api.list_trusts()"},{"line_number":212,"context_line":"        self.assertEqual(len(trusts), 1)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_7e4e333a","line":209,"updated":"2018-10-19 00:29:12.000000000","message":"I don\u0027t like that we changed the value(s) here for these tests. it feels like we should put a guard in on the manager/driver method to ensure we always have utcnow() even if it isn\u0027t passed in -- OR raise an exception.","commit_id":"77bb2af3318e238a22a8f88b3741d45e8d7539d3"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"c625cf95f52aceacab157a7593b5ad4cbc216430","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                                                      trust_ref2, roles)"},{"line_number":207,"context_line":"        self.assertIsNotNone(trust_data)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        PROVIDERS.trust_api.flush_expired_and_soft_deleted_trusts("},{"line_number":210,"context_line":"            date\u003ddatetime.datetime.utcnow())"},{"line_number":211,"context_line":"        trusts \u003d self.trust_api.list_trusts()"},{"line_number":212,"context_line":"        self.assertEqual(len(trusts), 1)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_e3912a9d","line":209,"in_reply_to":"3f79a3b5_7e4e333a","updated":"2018-10-22 02:48:04.000000000","message":"Done","commit_id":"77bb2af3318e238a22a8f88b3741d45e8d7539d3"}],"keystone/trust/backends/sql.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"c75afeae8d1196baa8edfc764315735cce8b463e","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                                              date\u003dNone):"},{"line_number":198,"context_line":"        with sql.session_for_write() as session:"},{"line_number":199,"context_line":"            query \u003d session.query(TrustModel)"},{"line_number":200,"context_line":"            if not date:"},{"line_number":201,"context_line":"                cmp_date \u003d timeutils.utcnow()"},{"line_number":202,"context_line":"            else:"},{"line_number":203,"context_line":"                cmp_date \u003d date"},{"line_number":204,"context_line":"            query \u003d query. \\"},{"line_number":205,"context_line":"                filter(sqlalchemy.or_(TrustModel.deleted_at.isnot(None),"},{"line_number":206,"context_line":"                                      sqlalchemy.and_("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_fed7a321","line":203,"range":{"start_line":200,"start_character":0,"end_line":203,"end_character":31},"updated":"2018-10-08 07:42:15.000000000","message":"no need a new variable, just:\n\nif not date:\n    date \u003d timeutils.utcnow()","commit_id":"3a617f6bc2d67225967770cbee095a9b6b42c16b"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"c8d9afa1e80a6132a14989d1bc0754fe80e9c705","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                                              date\u003dNone):"},{"line_number":198,"context_line":"        with sql.session_for_write() as session:"},{"line_number":199,"context_line":"            query \u003d session.query(TrustModel)"},{"line_number":200,"context_line":"            if not date:"},{"line_number":201,"context_line":"                cmp_date \u003d timeutils.utcnow()"},{"line_number":202,"context_line":"            else:"},{"line_number":203,"context_line":"                cmp_date \u003d date"},{"line_number":204,"context_line":"            query \u003d query. \\"},{"line_number":205,"context_line":"                filter(sqlalchemy.or_(TrustModel.deleted_at.isnot(None),"},{"line_number":206,"context_line":"                                      sqlalchemy.and_("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_19db84ea","line":203,"range":{"start_line":200,"start_character":0,"end_line":203,"end_character":31},"in_reply_to":"3f79a3b5_fed7a321","updated":"2018-10-09 02:58:13.000000000","message":"done","commit_id":"3a617f6bc2d67225967770cbee095a9b6b42c16b"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"3a028ab72284694d76323f96f68321665d78ba4f","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            query \u003d session.query(TrustModel)"},{"line_number":200,"context_line":"            if not date:"},{"line_number":201,"context_line":"                date \u003d timeutils.utcnow()"},{"line_number":202,"context_line":"            query \u003d query. \\"},{"line_number":203,"context_line":"                filter(sqlalchemy.or_(TrustModel.deleted_at.isnot(None),"},{"line_number":204,"context_line":"                                      sqlalchemy.and_("},{"line_number":205,"context_line":"                                          TrustModel.expires_at.isnot(None),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4d461625","line":202,"updated":"2018-10-10 06:30:26.000000000","message":"unnecessary blank","commit_id":"072cecafcb49822625a373ded30960f1b45c051f"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"3e93a745c382add30b355113559968f5d1f70dbb","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            query \u003d session.query(TrustModel)"},{"line_number":200,"context_line":"            if not date:"},{"line_number":201,"context_line":"                date \u003d timeutils.utcnow()"},{"line_number":202,"context_line":"            query \u003d query. \\"},{"line_number":203,"context_line":"                filter(sqlalchemy.or_(TrustModel.deleted_at.isnot(None),"},{"line_number":204,"context_line":"                                      sqlalchemy.and_("},{"line_number":205,"context_line":"                                          TrustModel.expires_at.isnot(None),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_1b7d986c","line":202,"in_reply_to":"3f79a3b5_4d461625","updated":"2018-10-10 07:55:48.000000000","message":"Done","commit_id":"072cecafcb49822625a373ded30960f1b45c051f"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"3ccf30361ac28d993826178edfc79d3fecf12356","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                filter(sqlalchemy.or_(TrustModel.deleted_at.isnot(None),"},{"line_number":202,"context_line":"                                      sqlalchemy.and_("},{"line_number":203,"context_line":"                                          TrustModel.expires_at.isnot(None),"},{"line_number":204,"context_line":"                                          TrustModel.expires_at \u003c date)))"},{"line_number":205,"context_line":"            if project_id:"},{"line_number":206,"context_line":"                query \u003d query.filter_by(project_id\u003dproject_id)"},{"line_number":207,"context_line":"            if trustor_user_id:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_de6ae780","line":204,"updated":"2018-10-19 00:29:12.000000000","message":"Suggest adding in a guard to make sure if date isn\u0027t specified we raise an exception. I don\u0027t like that we had to change tests without an explicit guard to prevent bad data from reaching our backend.","commit_id":"77bb2af3318e238a22a8f88b3741d45e8d7539d3"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"c625cf95f52aceacab157a7593b5ad4cbc216430","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                filter(sqlalchemy.or_(TrustModel.deleted_at.isnot(None),"},{"line_number":202,"context_line":"                                      sqlalchemy.and_("},{"line_number":203,"context_line":"                                          TrustModel.expires_at.isnot(None),"},{"line_number":204,"context_line":"                                          TrustModel.expires_at \u003c date)))"},{"line_number":205,"context_line":"            if project_id:"},{"line_number":206,"context_line":"                query \u003d query.filter_by(project_id\u003dproject_id)"},{"line_number":207,"context_line":"            if trustor_user_id:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_c3866e60","line":204,"in_reply_to":"3f79a3b5_de6ae780","updated":"2018-10-22 02:48:04.000000000","message":"Done","commit_id":"77bb2af3318e238a22a8f88b3741d45e8d7539d3"}],"releasenotes/notes/bug-1473292-c21481e6aec29ec2.yaml":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"c75afeae8d1196baa8edfc764315735cce8b463e","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    Options (optional):"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"        project-id \u003cstring\u003e: To purge trusts of given project-id."},{"line_number":17,"context_line":"        trustor-user-id \u003cstring\u003e: To purge trusts of given trustor-id."},{"line_number":18,"context_line":"        trustee-user-id \u003cstring\u003e: To purge trusts of given trustee-id."},{"line_number":19,"context_line":"        date \u003cstring\u003e: To purge trusts older than date."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_7e995378","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":18},"updated":"2018-10-08 07:42:15.000000000","message":"I\u0027d like to see \"--project-id\" instead.","commit_id":"3a617f6bc2d67225967770cbee095a9b6b42c16b"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"c8d9afa1e80a6132a14989d1bc0754fe80e9c705","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    Options (optional):"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"        project-id \u003cstring\u003e: To purge trusts of given project-id."},{"line_number":17,"context_line":"        trustor-user-id \u003cstring\u003e: To purge trusts of given trustor-id."},{"line_number":18,"context_line":"        trustee-user-id \u003cstring\u003e: To purge trusts of given trustee-id."},{"line_number":19,"context_line":"        date \u003cstring\u003e: To purge trusts older than date."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_d9ee6c89","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":18},"in_reply_to":"3f79a3b5_7e995378","updated":"2018-10-09 02:58:13.000000000","message":"done","commit_id":"3a617f6bc2d67225967770cbee095a9b6b42c16b"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"3a028ab72284694d76323f96f68321665d78ba4f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        --project-id \u003cstring\u003e: To purge trusts of given project-id."},{"line_number":17,"context_line":"        --trustor-user-id \u003cstring\u003e: To purge trusts of given trustor-id."},{"line_number":18,"context_line":"        --trustee-user-id \u003cstring\u003e: To purge trusts of given trustee-id."},{"line_number":19,"context_line":"        --date \u003cstring\u003e: To purge trusts older than date."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_1dfb5015","line":19,"range":{"start_line":19,"start_character":24,"end_line":19,"end_character":57},"updated":"2018-10-10 06:30:26.000000000","message":"here should be updated as well.","commit_id":"072cecafcb49822625a373ded30960f1b45c051f"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"3e93a745c382add30b355113559968f5d1f70dbb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        --project-id \u003cstring\u003e: To purge trusts of given project-id."},{"line_number":17,"context_line":"        --trustor-user-id \u003cstring\u003e: To purge trusts of given trustor-id."},{"line_number":18,"context_line":"        --trustee-user-id \u003cstring\u003e: To purge trusts of given trustee-id."},{"line_number":19,"context_line":"        --date \u003cstring\u003e: To purge trusts older than date."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_7b8dac7a","line":19,"range":{"start_line":19,"start_character":24,"end_line":19,"end_character":57},"in_reply_to":"3f79a3b5_1dfb5015","updated":"2018-10-10 07:55:48.000000000","message":"Done","commit_id":"072cecafcb49822625a373ded30960f1b45c051f"}]}