)]}'
{"keystone/api/_shared/saml.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"455751b46d821a17e054464c9b2ff246172f19b9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"PROVIDERS \u003d provider_api.ProviderAPIs"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def create_base_saml_assertion(auth):"},{"line_number":26,"context_line":"    issuer \u003d CONF.saml.idp_entity_id"},{"line_number":27,"context_line":"    sp_id \u003d auth[\u0027scope\u0027][\u0027service_provider\u0027][\u0027id\u0027]"},{"line_number":28,"context_line":"    service_provider \u003d PROVIDERS.federation_api.get_sp(sp_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_88a5ce03","line":25,"updated":"2018-10-10 19:20:03.000000000","message":"I see the comment on https://review.openstack.org/#/c/603461/10/keystone/api/auth.py@58 but it kind of seems weird to have a _shared.saml just for one method.","commit_id":"54b6227c1fdec1e768570ba696841b00f4e0a549"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"703045b5f6fb2dca3b1eadbab97f4f26e758ab9f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"PROVIDERS \u003d provider_api.ProviderAPIs"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def create_base_saml_assertion(auth):"},{"line_number":26,"context_line":"    issuer \u003d CONF.saml.idp_entity_id"},{"line_number":27,"context_line":"    sp_id \u003d auth[\u0027scope\u0027][\u0027service_provider\u0027][\u0027id\u0027]"},{"line_number":28,"context_line":"    service_provider \u003d PROVIDERS.federation_api.get_sp(sp_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_be81e0c4","line":25,"in_reply_to":"3f79a3b5_88a5ce03","updated":"2018-10-10 20:40:20.000000000","message":"I agree, but I don\u0027t mind it being here. It can easily be moved back into keystone.api.auth","commit_id":"54b6227c1fdec1e768570ba696841b00f4e0a549"}]}