)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1e92f9efbb793604f06a0f03cafc71c94884b55a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This commit lays down the basic structure for the upgrade checks and"},{"line_number":14,"context_line":"ties it up to `keystone-status` command."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Story: 2003657"},{"line_number":17,"context_line":"Change-Id: I6586827104156ac549217967a1b9171f1a3b32e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_e7e69a4a","line":16,"updated":"2018-10-15 14:38:35.000000000","message":"Add this too:\n\nTask: 26135","commit_id":"9618832979670a1746a230a87db0d695528eec61"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"27dac953f6a19a2de3dfb20e78d8f238688e005d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This commit lays down the basic structure for the upgrade checks and"},{"line_number":14,"context_line":"ties it up to `keystone-status` command."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Story: 2003657"},{"line_number":17,"context_line":"Change-Id: I6586827104156ac549217967a1b9171f1a3b32e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_6d390bcd","line":16,"in_reply_to":"3f79a3b5_e7e69a4a","updated":"2018-10-15 15:32:03.000000000","message":"Done","commit_id":"9618832979670a1746a230a87db0d695528eec61"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"be95da0d1ebe1196be6c98de6121212a9309da8c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"ties it up to `keystone-status` command."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Story: 2003657"},{"line_number":17,"context_line":"Task: 26135"},{"line_number":18,"context_line":"Change-Id: I6586827104156ac549217967a1b9171f1a3b32e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f79a3b5_6d626bdb","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":11},"updated":"2018-10-15 15:33:12.000000000","message":"Weird, this doesn\u0027t appear to link to Storyboard?","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e89b33d7b130dae9f137a4a5297441af7f2fbf7f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"ties it up to `keystone-status` command."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Story: 2003657"},{"line_number":17,"context_line":"Task: 26135"},{"line_number":18,"context_line":"Change-Id: I6586827104156ac549217967a1b9171f1a3b32e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f79a3b5_a1b5d5d1","line":17,"range":{"start_line":17,"start_character":6,"end_line":17,"end_character":11},"in_reply_to":"3f79a3b5_6d626bdb","updated":"2018-10-16 14:20:11.000000000","message":"I think because tasks aren\u0027t a top level resource in the UI?","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"}],"doc/source/cli/index.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3fbc63c0baf36b700fae25ca694a00b644748d5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"CLI Documentation"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. include:: keystone-manage.rst"},{"line_number":22,"context_line":".. include:: keystone-status.rst"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_81fc5971","line":21,"range":{"start_line":21,"start_character":3,"end_line":21,"end_character":10},"updated":"2018-10-16 14:28:33.000000000","message":"Now that you have two commands, you might consider making this a toc tree otherwise the include makes the cli index page pretty gorpy:\n\nhttp://logs.openstack.org/85/608785/6/check/openstack-tox-docs/2113d95/html/cli/\n\nMost other projects have cli/index.rst using a toc tree:\n\nhttps://docs.openstack.org/nova/latest/cli/\nhttps://docs.openstack.org/cinder/latest/cli/\nhttps://docs.openstack.org/neutron/latest/cli/\nhttps://docs.openstack.org/glance/latest/cli/","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b7353bee672a758e5d6bed3535fc3004fe5e7e34","unresolved":false,"context_lines":[{"line_number":18,"context_line":"CLI Documentation"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. include:: keystone-manage.rst"},{"line_number":22,"context_line":".. include:: keystone-status.rst"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_fc660bee","line":21,"range":{"start_line":21,"start_character":3,"end_line":21,"end_character":10},"in_reply_to":"3f79a3b5_81fc5971","updated":"2018-10-16 19:10:52.000000000","message":"Done","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6893d9e23fde5391d5582f87cb123d0d7bde5a4a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":"CLI Documentation"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. toctree::"},{"line_number":22,"context_line":"   :maxdepth: 1"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_35355844","line":20,"updated":"2018-10-17 20:45:43.000000000","message":"You should update the home page since it\u0027s more than just keystone-manage now:\n\nhttp://logs.openstack.org/85/608785/7/check/openstack-tox-docs/ef5098e/html/#cli-documentation","commit_id":"31da6ec7c030b18b75e01668ddb920bb271df917"}],"doc/source/cli/keystone-status.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3fbc63c0baf36b700fae25ca694a00b644748d5","unresolved":false,"context_lines":[{"line_number":8,"context_line":":Author: openstack@lists.openstack.org"},{"line_number":9,"context_line":":Date: 2018-10-15"},{"line_number":10,"context_line":":Copyright: OpenStack Foundation"},{"line_number":11,"context_line":":Version: 14.0.0"},{"line_number":12,"context_line":":Manual section: 1"},{"line_number":13,"context_line":":Manual group: cloud computing"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_e1be6dad","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":12},"updated":"2018-10-16 14:28:33.000000000","message":"Shouldn\u0027t this be 15 for stein?","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b7353bee672a758e5d6bed3535fc3004fe5e7e34","unresolved":false,"context_lines":[{"line_number":8,"context_line":":Author: openstack@lists.openstack.org"},{"line_number":9,"context_line":":Date: 2018-10-15"},{"line_number":10,"context_line":":Copyright: OpenStack Foundation"},{"line_number":11,"context_line":":Version: 14.0.0"},{"line_number":12,"context_line":":Manual section: 1"},{"line_number":13,"context_line":":Manual group: cloud computing"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_1c62e7d9","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":12},"in_reply_to":"3f79a3b5_e1be6dad","updated":"2018-10-16 19:10:52.000000000","message":"Done","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3fbc63c0baf36b700fae25ca694a00b644748d5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"SYNOPSIS"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  keystone-status [options]"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"DESCRIPTION"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_c106d185","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":2},"updated":"2018-10-16 14:28:33.000000000","message":"You don\u0027t need the indent on this, it formats weirdly:\n\nhttp://logs.openstack.org/85/608785/6/check/openstack-tox-docs/2113d95/html/cli/#id1\n\nAlternatively, do something like this:\n\n.. code-block:: console\n\n   $ keystone-status [options]","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b7353bee672a758e5d6bed3535fc3004fe5e7e34","unresolved":false,"context_lines":[{"line_number":15,"context_line":"SYNOPSIS"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  keystone-status [options]"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"DESCRIPTION"},{"line_number":21,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_3c77a390","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":2},"in_reply_to":"3f79a3b5_c106d185","updated":"2018-10-16 19:10:52.000000000","message":"Done","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3fbc63c0baf36b700fae25ca694a00b644748d5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"USAGE"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    ``keystone-status [options] action [additional args]``"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":".. include:: upgrade.rst"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_4137214c","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":4},"updated":"2018-10-16 14:28:33.000000000","message":"same","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b7353bee672a758e5d6bed3535fc3004fe5e7e34","unresolved":false,"context_lines":[{"line_number":26,"context_line":"USAGE"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    ``keystone-status [options] action [additional args]``"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":".. include:: upgrade.rst"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_fcd92b83","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":4},"in_reply_to":"3f79a3b5_4137214c","updated":"2018-10-16 19:10:52.000000000","message":"Done","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3fbc63c0baf36b700fae25ca694a00b644748d5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"OPTIONS"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  -h, --help            show this help message and exit"},{"line_number":37,"context_line":"  --config-dir DIR      Path to a config directory to pull \\*.conf files from."},{"line_number":38,"context_line":"                        This file set is sorted, so as to provide a"},{"line_number":39,"context_line":"                        predictable parse order if individual options are"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_a11155b1","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":2},"updated":"2018-10-16 14:28:33.000000000","message":"same here and below","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b7353bee672a758e5d6bed3535fc3004fe5e7e34","unresolved":false,"context_lines":[{"line_number":33,"context_line":"OPTIONS"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  -h, --help            show this help message and exit"},{"line_number":37,"context_line":"  --config-dir DIR      Path to a config directory to pull \\*.conf files from."},{"line_number":38,"context_line":"                        This file set is sorted, so as to provide a"},{"line_number":39,"context_line":"                        predictable parse order if individual options are"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_1cd50747","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":2},"in_reply_to":"3f79a3b5_a11155b1","updated":"2018-10-16 19:10:52.000000000","message":"Done","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3fbc63c0baf36b700fae25ca694a00b644748d5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"SOURCE"},{"line_number":58,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* Keystone is sourced in Gerrit git `Keystone \u003chttps://git.openstack.org/cgit/openstack/keystone\u003e`__"},{"line_number":61,"context_line":"* Keystone bugs are managed at Launchpad `Keystone \u003chttps://bugs.launchpad.net/keystone\u003e`__"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_6107bd71","line":60,"range":{"start_line":60,"start_character":25,"end_line":60,"end_character":31},"updated":"2018-10-16 14:28:33.000000000","message":"The link here isn\u0027t really to gerrit...","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b7353bee672a758e5d6bed3535fc3004fe5e7e34","unresolved":false,"context_lines":[{"line_number":57,"context_line":"SOURCE"},{"line_number":58,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* Keystone is sourced in Gerrit git `Keystone \u003chttps://git.openstack.org/cgit/openstack/keystone\u003e`__"},{"line_number":61,"context_line":"* Keystone bugs are managed at Launchpad `Keystone \u003chttps://bugs.launchpad.net/keystone\u003e`__"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_fcc28b85","line":60,"range":{"start_line":60,"start_character":25,"end_line":60,"end_character":31},"in_reply_to":"3f79a3b5_6107bd71","updated":"2018-10-16 19:10:52.000000000","message":"Done","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6893d9e23fde5391d5582f87cb123d0d7bde5a4a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. code-block:: console"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"   $ keystone-status [options]"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DESCRIPTION"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_351eb8bc","line":20,"range":{"start_line":20,"start_character":3,"end_line":20,"end_character":4},"updated":"2018-10-17 20:45:43.000000000","message":"nit: either drop this or be consistent in using it in other console blocks below.","commit_id":"31da6ec7c030b18b75e01668ddb920bb271df917"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6893d9e23fde5391d5582f87cb123d0d7bde5a4a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"         upgrade."},{"line_number":75,"context_line":"     * - 255"},{"line_number":76,"context_line":"       - An unexpected error occurred."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"OPTIONS"},{"line_number":79,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_755af082","line":77,"updated":"2018-10-17 20:45:43.000000000","message":"I\u0027d add the history of checks section here like other projects are doing:\n\nhttps://review.openstack.org/#/c/610581/5/doc/source/cli/cinder-status.rst@84\n\nIt\u0027s pretty boring now but it will be useful when real checks are added.","commit_id":"31da6ec7c030b18b75e01668ddb920bb271df917"}],"doc/source/cli/upgrade.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3fbc63c0baf36b700fae25ca694a00b644748d5","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Available commands:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"* ``upgrade``: Perform checks to determine if the deployment is in a good state"},{"line_number":9,"context_line":"  for upgrading to newer releases."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_61ca5d19","line":8,"updated":"2018-10-16 14:28:33.000000000","message":"I\u0027d recommend having the same return codes table and history of checks section as the other docs for $project-status upgrade check, e.g.:\n\nhttps://review.openstack.org/#/c/610581/4/doc/source/cli/cinder-status.rst\n\nhttps://review.openstack.org/#/c/608444/4/doc/source/cli/neutron-status.rst\n\nhttps://review.openstack.org/#/c/604430/5/doc/source/cli/designate-status.rst","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b7353bee672a758e5d6bed3535fc3004fe5e7e34","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Available commands:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"* ``upgrade``: Perform checks to determine if the deployment is in a good state"},{"line_number":9,"context_line":"  for upgrading to newer releases."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_9c8a7717","line":8,"in_reply_to":"3f79a3b5_61ca5d19","updated":"2018-10-16 19:10:52.000000000","message":"Done","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"}],"keystone/cmd/status.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5796cfd6e54848aba4d17e7a75a89d20952bd016","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    _upgrade_checks \u003d ("},{"line_number":40,"context_line":"        (\u0027Successful Noop Check\u0027, successful_noop),"},{"line_number":41,"context_line":"        (\u0027Unsuccessful Noop Check\u0027, unsuccessful_noop),"},{"line_number":42,"context_line":"    )"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_a79e62b4","line":41,"updated":"2018-10-15 14:36:28.000000000","message":"I don\u0027t think you want to roll out your initial upgrade checks with a failure - anyone automating their deployment scripts is going to fail on keystone if they are generically checking the results for [[ $? -ge 2 ]] on this, like grenade does.","commit_id":"9618832979670a1746a230a87db0d695528eec61"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"58f71897f1b08ac7a5544ec233e2b9b51d42267f","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    _upgrade_checks \u003d ("},{"line_number":40,"context_line":"        (\u0027Successful Noop Check\u0027, successful_noop),"},{"line_number":41,"context_line":"        (\u0027Unsuccessful Noop Check\u0027, unsuccessful_noop),"},{"line_number":42,"context_line":"    )"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_87aa4617","line":41,"in_reply_to":"3f79a3b5_a79e62b4","updated":"2018-10-15 14:57:20.000000000","message":"Done","commit_id":"9618832979670a1746a230a87db0d695528eec61"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3fbc63c0baf36b700fae25ca694a00b644748d5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    policies actually exist within the roles backend."},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    pass"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_c19571e4","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":8},"updated":"2018-10-16 14:28:33.000000000","message":"I\u0027m not sure you can just pass here...will the library handle that if _upgrade_checks is not set?\n\nCinder and Neutron are just providing a simple noop placeholder success check in their initial patch:\n\nhttps://review.openstack.org/#/c/610581/4/cinder/cmd/status.py\n\nhttps://review.openstack.org/#/c/608444/4/neutron/cmd/status.py","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b7353bee672a758e5d6bed3535fc3004fe5e7e34","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    policies actually exist within the roles backend."},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    pass"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_7c8c3b2d","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":8},"in_reply_to":"3f79a3b5_41aac119","updated":"2018-10-16 19:10:52.000000000","message":"Sweet - so this should be fine until we get a real check.","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9f5982a5c02c0ce4e3ef89630db2cbfad15a14d8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    policies actually exist within the roles backend."},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    pass"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_41aac119","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":8},"in_reply_to":"3f79a3b5_c19571e4","updated":"2018-10-16 14:30:39.000000000","message":"I guess the library will default to an empty tuple:\n\nhttps://github.com/openstack/oslo.upgradecheck/blob/master/oslo_upgradecheck/upgradecheck.py#L77","commit_id":"255c6da65eab12c4ada1d32e35d9d6fad2da42fa"}],"keystone/tests/unit/test_upgrade_checks.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c1ba0a7edae3225f360109119c0c8433744f8f3b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    def test_unsuccessful_check(self):"},{"line_number":25,"context_line":"        result \u003d status.Checks().unsuccessful_noop()"},{"line_number":26,"context_line":"        self.assertEqual(result.code, 2)"},{"line_number":27,"context_line":"        self.assertEqual(result.details, \u0027Noop check was unsuccessful\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4c1d91bc","line":27,"updated":"2018-10-10 14:38:03.000000000","message":"These tests aren\u0027t really super useful, but I added them to give reviewers a feel for how we can test our checks. Since the code to do the CLI bits is in oslo.upgradecheck, we can make our testing simpler by just testing the boundaries of that interface.\n\nI didn\u0027t want to propose this patch without tests and these checks aren\u0027t doing anything useful for operators, but I can remove them if we have an actual upgrade check to implement.","commit_id":"ba0a2b07b99d371955ff4b7044d7d2cd9226fc3f"}],"releasenotes/notes/bp-upgrade-checks-0dc692a392a96879.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4aa17b4cfda88afecd1a1433b601ce6aa439cfd8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`Community Goal \u003chttps://governance.openstack.org/tc/goals/stein/upgrade-checkers.html\u003e`_]"},{"line_number":5,"context_line":"    Support has been added for developers to write pre-upgrade checks."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_a7d66225","line":2,"updated":"2018-10-15 14:42:17.000000000","message":"You should also have CLI docs:\n\nhttps://docs.openstack.org/keystone/latest/cli/","commit_id":"9618832979670a1746a230a87db0d695528eec61"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"27dac953f6a19a2de3dfb20e78d8f238688e005d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`Community Goal \u003chttps://governance.openstack.org/tc/goals/stein/upgrade-checkers.html\u003e`_]"},{"line_number":5,"context_line":"    Support has been added for developers to write pre-upgrade checks."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_4d3e8fb9","line":2,"in_reply_to":"3f79a3b5_a7d66225","updated":"2018-10-15 15:32:03.000000000","message":"Done","commit_id":"9618832979670a1746a230a87db0d695528eec61"}],"setup.cfg":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"c88b66bd6dbb8a6e061d3e6f8bb18794963ccdb6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"[entry_points]"},{"line_number":67,"context_line":"console_scripts \u003d"},{"line_number":68,"context_line":"    keystone-manage \u003d keystone.cmd.manage:main"},{"line_number":69,"context_line":"    keystone-status \u003d keystone.cmd.status:main"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"wsgi_scripts \u003d"},{"line_number":72,"context_line":"    keystone-wsgi-admin \u003d keystone.server.wsgi:initialize_admin_application"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"3f79a3b5_8655f3c4","line":69,"updated":"2018-10-09 01:23:39.000000000","message":"I think this change requires a release note too. Pl Update.","commit_id":"8125ac9fb95b38d64e9d7af2b9b7e08fc7c7a60e"}]}