)]}'
{"keystone/limit/backends/sql.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"77234d1a9a2f1b53ae9ec3f039fa500aceb6ab50","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                old_dict \u003d ref.to_dict()"},{"line_number":213,"context_line":"                old_dict.update(registered_limit)"},{"line_number":214,"context_line":"                if (registered_limit.get(\u0027service_id\u0027) or"},{"line_number":215,"context_line":"                        \u0027region_id\u0027 in registered_limit or"},{"line_number":216,"context_line":"                        registered_limit.get(\u0027resource_name\u0027)):"},{"line_number":217,"context_line":"                    self._check_unified_limit_unique(old_dict)"},{"line_number":218,"context_line":"                new_registered_limit \u003d RegisteredLimitModel.from_dict("}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_ab46bd7d","line":215,"updated":"2018-10-19 17:35:55.000000000","message":"I\u0027d like to see a note as to why we\u0027re using \"in\" here. I get it, but I know it\u0027s not super intuitive at first glance. Good catch.","commit_id":"8e9de8a515b5b0407a54ab098ce47c5fab756a09"}],"keystone/tests/unit/test_limits.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"6e5f451d9bf857439990644342de69c2deaaebf4","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        new_registered_limits \u003d r.result[\u0027registered_limit\u0027]"},{"line_number":255,"context_line":"        self.assertEqual(new_registered_limits[\u0027description\u0027], \u0027\u0027)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def test_update_registered_limit_region_id_to_None(self):"},{"line_number":258,"context_line":"        ref \u003d unit.new_registered_limit_ref(service_id\u003dself.service_id,"},{"line_number":259,"context_line":"                                            region_id\u003dself.region_id,"},{"line_number":260,"context_line":"                                            resource_name\u003d\u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_de8e6779","line":257,"updated":"2018-10-19 00:18:48.000000000","message":"I\u0027d like to see a test to see what happens if the region_id is not none and it is attempted to update it to none but a conflicting limit with a region_id of None already exists.\n\nJust for completeness of the tests / coverage with the new behavior.","commit_id":"4cef0d09b39ed4cbcf2c89a75d8de5769c700487"}]}