)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ea1ebf0dce601d4ed1b343f5109495e16fb759e2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"http://review.openstack.org/#/c/60820"},{"line_number":12,"context_line":"However, I noticed that it doesn\u0027t allow for embedded extra non-"},{"line_number":13,"context_line":"oauth parameters in the oauth header, something which the old"},{"line_number":14,"context_line":"library (that we use on the server side) does."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I819a29119a359873633ab8fde553a11a8a37a682"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAT3%2F%2F3OQ%3D","line":14,"updated":"2013-12-29 20:57:46.000000000","message":"suggest reword this to just say what the change is and what effect it\u0027s going to have.","commit_id":"722f9fb12940b3b5aca88cfb777de6c99e9c9aab"}],"keystone/contrib/oauth1/controllers.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ea1ebf0dce601d4ed1b343f5109495e16fb759e2","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                                             consumer,"},{"line_number":193,"context_line":"                                             token\u003dNone)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if len(params) !\u003d 0:"},{"line_number":196,"context_line":"            msg \u003d _(\u0027There should not be any non-oauth parameters\u0027)"},{"line_number":197,"context_line":"            raise exception.Unauthorized(message\u003dmsg)"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F3OM%3D","line":195,"updated":"2013-12-29 20:57:46.000000000","message":"change to \"if params:\" since non-empty list is True. (there\u0027s another commit that cleans this up)","commit_id":"722f9fb12940b3b5aca88cfb777de6c99e9c9aab"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"10285b2fbf0c40c9b6ee4d210bc794d54a6771ab","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                                             token\u003dNone)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if len(params) !\u003d 0:"},{"line_number":196,"context_line":"            msg \u003d _(\u0027There should not be any non-oauth parameters\u0027)"},{"line_number":197,"context_line":"            raise exception.Unauthorized(message\u003dmsg)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        request_token_duration \u003d CONF.oauth1.request_token_duration"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9N1s%3D","line":196,"updated":"2013-12-13 22:10:21.000000000","message":"So at first I thought this comment may be incorrect.  But upon digging into oauth_server.verify_request it truly does return back any non-oauth parameters if it returns anything.  So your message is more accurate than I initially thought.","commit_id":"722f9fb12940b3b5aca88cfb777de6c99e9c9aab"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ea1ebf0dce601d4ed1b343f5109495e16fb759e2","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                                             token\u003dNone)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if len(params) !\u003d 0:"},{"line_number":196,"context_line":"            msg \u003d _(\u0027There should not be any non-oauth parameters\u0027)"},{"line_number":197,"context_line":"            raise exception.Unauthorized(message\u003dmsg)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        request_token_duration \u003d CONF.oauth1.request_token_duration"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2F3OI%3D","line":196,"updated":"2013-12-29 20:57:46.000000000","message":"suggest add a . at and of sentence.","commit_id":"722f9fb12940b3b5aca88cfb777de6c99e9c9aab"}]}
