)]}'
{"keystone/common/fernet_utils.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"cad9ce2dafce5489cf5e5c4862a6d7c6219c690d","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        return is_valid"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def create_key_directory(self, keystone_user_id\u003dNone,"},{"line_number":76,"context_line":"                             keystone_group_id\u003dNone):"},{"line_number":77,"context_line":"        \"\"\"Attempt to create the key directory if it doesn\u0027t exist.\"\"\""},{"line_number":78,"context_line":"        file_utils.create_directory("},{"line_number":79,"context_line":"            self.key_repository, keystone_user_id\u003dkeystone_user_id,"},{"line_number":80,"context_line":"            keystone_group_id\u003dkeystone_group_id"},{"line_number":81,"context_line":"        )"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _create_new_key(self, keystone_user_id, keystone_group_id):"},{"line_number":84,"context_line":"        \"\"\"Securely create a new encryption key."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_568c452c","line":81,"range":{"start_line":75,"start_character":0,"end_line":81,"end_character":9},"updated":"2018-11-05 09:03:16.000000000","message":"Maybe this func can be removed totally? Can\u0027t see much benefit for it.","commit_id":"1811220243e86af4ff1220125a9f8b52d4c95c64"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c168bfd77ff441cd784cc2e0f66f7f9cc8dcc934","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        return is_valid"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def create_key_directory(self, keystone_user_id\u003dNone,"},{"line_number":76,"context_line":"                             keystone_group_id\u003dNone):"},{"line_number":77,"context_line":"        \"\"\"Attempt to create the key directory if it doesn\u0027t exist.\"\"\""},{"line_number":78,"context_line":"        file_utils.create_directory("},{"line_number":79,"context_line":"            self.key_repository, keystone_user_id\u003dkeystone_user_id,"},{"line_number":80,"context_line":"            keystone_group_id\u003dkeystone_group_id"},{"line_number":81,"context_line":"        )"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _create_new_key(self, keystone_user_id, keystone_group_id):"},{"line_number":84,"context_line":"        \"\"\"Securely create a new encryption key."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c1caca17","line":81,"range":{"start_line":75,"start_character":0,"end_line":81,"end_character":9},"in_reply_to":"3f79a3b5_568c452c","updated":"2018-11-05 15:04:52.000000000","message":"This is really only used for the keystone-manage commands, where an operator uses it to actually create the directory in addition to setting up the keys.","commit_id":"1811220243e86af4ff1220125a9f8b52d4c95c64"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"80dd1d38dba55b6f3d3249eaa5d046c7e1131a03","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        return is_valid"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def create_key_directory(self, keystone_user_id\u003dNone,"},{"line_number":76,"context_line":"                             keystone_group_id\u003dNone):"},{"line_number":77,"context_line":"        \"\"\"Attempt to create the key directory if it doesn\u0027t exist.\"\"\""},{"line_number":78,"context_line":"        file_utils.create_directory("},{"line_number":79,"context_line":"            self.key_repository, keystone_user_id\u003dkeystone_user_id,"},{"line_number":80,"context_line":"            keystone_group_id\u003dkeystone_group_id"},{"line_number":81,"context_line":"        )"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _create_new_key(self, keystone_user_id, keystone_group_id):"},{"line_number":84,"context_line":"        \"\"\"Securely create a new encryption key."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_511dfa5e","line":81,"range":{"start_line":75,"start_character":0,"end_line":81,"end_character":9},"in_reply_to":"3f79a3b5_c1caca17","updated":"2018-11-07 07:59:46.000000000","message":"So how about remove this func and call the common one directly in keystone-manage place.","commit_id":"1811220243e86af4ff1220125a9f8b52d4c95c64"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"16d08fd8e2397c8bfc862af84a6d2720c4a8dd62","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        return is_valid"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def create_key_directory(self, keystone_user_id\u003dNone,"},{"line_number":76,"context_line":"                             keystone_group_id\u003dNone):"},{"line_number":77,"context_line":"        \"\"\"Attempt to create the key directory if it doesn\u0027t exist.\"\"\""},{"line_number":78,"context_line":"        utils.create_directory("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b6ebe478","line":75,"updated":"2018-11-09 19:25:30.000000000","message":"why not remove this method all together?","commit_id":"6649144771e97d0588e6af039c2491ab4b0278b1"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"82033b6bc82b32b8156213c4033a53db3e025f12","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        return is_valid"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def create_key_directory(self, keystone_user_id\u003dNone,"},{"line_number":76,"context_line":"                             keystone_group_id\u003dNone):"},{"line_number":77,"context_line":"        \"\"\"Attempt to create the key directory if it doesn\u0027t exist.\"\"\""},{"line_number":78,"context_line":"        utils.create_directory("}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_43b4f081","line":75,"in_reply_to":"3f79a3b5_b6ebe478","updated":"2018-11-13 08:20:26.000000000","message":"I didn\u0027t refactor this out since there are several places that rely on it as the original interface.\n\nIt can be removed, but I figured it was still useful to have a method that invoked the directory creation as a method of the FernetUtils class and has the directory location as variables.","commit_id":"6649144771e97d0588e6af039c2491ab4b0278b1"}]}