)]}'
{"keystone/cmd/cli.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"56f6a5f941f56041415a8ea3b2b3f1179bdad1e7","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                keystone_user_id, keystone_group_id)"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        if (os.path.abspath(CONF.fernet_tokens.key_repository) !\u003d"},{"line_number":413,"context_line":"                os.path.abspath(CONF.fernet_receipts.key_repository)):"},{"line_number":414,"context_line":"            futils \u003d fernet_utils.FernetUtils("},{"line_number":415,"context_line":"                CONF.fernet_receipts.key_repository,"},{"line_number":416,"context_line":"                CONF.fernet_receipts.max_active_keys,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_e6e6fcaf","line":413,"range":{"start_line":413,"start_character":24,"end_line":413,"end_character":31},"updated":"2018-11-05 14:30:15.000000000","message":"We use a default absolute path for every key repository we use fernet for, but I don\u0027t think we actually document that anywhere.\n\nThe usage of abspath() here assumes it\u0027s working with an absolute path, right? Because the output of:\n\n  os.path.abspath(\u0027fernet-keys\u0027)\n\nand\n\n  os.path.abspath(\u0027/etc/keystone/fernet-keys\u0027)\n\ncould be different based on runtime.\n\nMaybe we need to have a follow-up patch to clarify our expectations of absolute paths.","commit_id":"7fa62c823af2fd5765bf7f68e4b0b3e0390881df"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"95ac86e3ab0cc1e3939affb113c0e82d19f317eb","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                keystone_user_id, keystone_group_id)"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        if (os.path.abspath(CONF.fernet_tokens.key_repository) !\u003d"},{"line_number":413,"context_line":"                os.path.abspath(CONF.fernet_receipts.key_repository)):"},{"line_number":414,"context_line":"            futils \u003d fernet_utils.FernetUtils("},{"line_number":415,"context_line":"                CONF.fernet_receipts.key_repository,"},{"line_number":416,"context_line":"                CONF.fernet_receipts.max_active_keys,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8c0c093b","line":413,"range":{"start_line":413,"start_character":24,"end_line":413,"end_character":31},"in_reply_to":"3f79a3b5_61589624","updated":"2018-11-05 15:14:46.000000000","message":"Maybe I was reading too far into it then. I was under the assumption we were moving in the direction of requiring absolute paths.","commit_id":"7fa62c823af2fd5765bf7f68e4b0b3e0390881df"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"6272f1562e1c52a04e46d9d4262a98d963781c22","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                keystone_user_id, keystone_group_id)"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        if (os.path.abspath(CONF.fernet_tokens.key_repository) !\u003d"},{"line_number":413,"context_line":"                os.path.abspath(CONF.fernet_receipts.key_repository)):"},{"line_number":414,"context_line":"            futils \u003d fernet_utils.FernetUtils("},{"line_number":415,"context_line":"                CONF.fernet_receipts.key_repository,"},{"line_number":416,"context_line":"                CONF.fernet_receipts.max_active_keys,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0c955994","line":413,"range":{"start_line":413,"start_character":24,"end_line":413,"end_character":31},"in_reply_to":"3f79a3b5_8c0c093b","updated":"2018-11-05 15:17:04.000000000","message":"It doesn\u0027t require an absolute path, it will transform a relative path into an absolute path.","commit_id":"7fa62c823af2fd5765bf7f68e4b0b3e0390881df"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"f3f148bb023ddde3771d0f9507c9e9a785b0a085","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                keystone_user_id, keystone_group_id)"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        if (os.path.abspath(CONF.fernet_tokens.key_repository) !\u003d"},{"line_number":413,"context_line":"                os.path.abspath(CONF.fernet_receipts.key_repository)):"},{"line_number":414,"context_line":"            futils \u003d fernet_utils.FernetUtils("},{"line_number":415,"context_line":"                CONF.fernet_receipts.key_repository,"},{"line_number":416,"context_line":"                CONF.fernet_receipts.max_active_keys,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_61589624","line":413,"range":{"start_line":413,"start_character":24,"end_line":413,"end_character":31},"in_reply_to":"3f79a3b5_e6e6fcaf","updated":"2018-11-05 14:43:48.000000000","message":"Is it a problem if they\u0027re different? The logic still applies: if I\u0027m running keystone from my homedir with [fernet_tokens]/key_repository\u003dfernet-keys and I\u0027ve left [fernet_receipts]/key_repository set to the default of /etc/keystone/fernet-keys then the result is\n\n/home/colleen/fernet-keys !\u003d /etc/keystone/fernet-keys\n\nwhich are indeed different so this should apply.","commit_id":"7fa62c823af2fd5765bf7f68e4b0b3e0390881df"}]}