)]}'
{"keystone/notifications.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"bce368df1dab476912d2d2b1f6d8f2b325069b19","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    else:"},{"line_number":423,"context_line":"        target_uri \u003d CADF_TYPE_MAP.get(resource_type)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    # NOTE(gagehugo): If the ID is the root domain, don\u0027t emit a notification"},{"line_number":426,"context_line":"    if resource_id \u003d\u003d ROOT_DOMAIN:"},{"line_number":427,"context_line":"        return"},{"line_number":428,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d5d184fb","line":425,"range":{"start_line":425,"start_character":4,"end_line":425,"end_character":77},"updated":"2018-11-13 23:33:29.000000000","message":"why?","commit_id":"e515567b70add62d961029550996c8fd84af8c42"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"579cd94bca7bcafdbfef363ab4700234b0e9d714","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    else:"},{"line_number":423,"context_line":"        target_uri \u003d CADF_TYPE_MAP.get(resource_type)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    # NOTE(gagehugo): If the ID is the root domain, don\u0027t emit a notification"},{"line_number":426,"context_line":"    if resource_id \u003d\u003d ROOT_DOMAIN:"},{"line_number":427,"context_line":"        return"},{"line_number":428,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d2ad08a5","line":425,"range":{"start_line":425,"start_character":4,"end_line":425,"end_character":77},"in_reply_to":"3f79a3b5_d5d184fb","updated":"2018-11-14 20:41:53.000000000","message":"The root domain id is typically hidden, and only shows up in the unit tests for setup. I will change this comment to better clarify this.","commit_id":"e515567b70add62d961029550996c8fd84af8c42"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"ff29a74bd0e51a9a598c7a9a970d820063f15b5a","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    else:"},{"line_number":423,"context_line":"        target_uri \u003d CADF_TYPE_MAP.get(resource_type)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    # NOTE(gagehugo): The root domain ID is typically hidden, there isn\u0027t a"},{"line_number":426,"context_line":"    # reason to emit a notification for it. This cuts down on the amount of"},{"line_number":427,"context_line":"    # uuid warnings in the unit tests by a significant amount."},{"line_number":428,"context_line":"    if resource_id \u003d\u003d ROOT_DOMAIN:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_32b55cd0","line":425,"range":{"start_line":425,"start_character":11,"end_line":425,"end_character":19},"updated":"2018-11-14 20:54:51.000000000","message":"shouldn\u0027t we at least log that than?","commit_id":"45dbf4a3cbcd79c8895f6508ee5a30326ecc09ce"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"998e2ed346f836913b197c1ca05cddf7d25f41e4","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    else:"},{"line_number":423,"context_line":"        target_uri \u003d CADF_TYPE_MAP.get(resource_type)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    # NOTE(gagehugo): The root domain ID is typically hidden, there isn\u0027t a"},{"line_number":426,"context_line":"    # reason to emit a notification for it. This cuts down on the amount of"},{"line_number":427,"context_line":"    # uuid warnings in the unit tests by a significant amount."},{"line_number":428,"context_line":"    if resource_id \u003d\u003d ROOT_DOMAIN:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_9871c016","line":425,"range":{"start_line":425,"start_character":11,"end_line":425,"end_character":19},"in_reply_to":"3f79a3b5_32b55cd0","updated":"2018-11-19 15:21:38.000000000","message":"The issue is that CADF does not know how to handle non-UUID formed ids. Nothing should lean on the root domain for an initiator or anything else (until we expose it later down the line, which case we can remove this bit).\n\nThis will be undone once we make the root domain an exposed element.","commit_id":"45dbf4a3cbcd79c8895f6508ee5a30326ecc09ce"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"2d3185f394478f4f2563789fbcf1441343e02d0c","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    else:"},{"line_number":423,"context_line":"        target_uri \u003d CADF_TYPE_MAP.get(resource_type)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    # NOTE(gagehugo): The root domain ID is typically hidden, there isn\u0027t a"},{"line_number":426,"context_line":"    # reason to emit a notification for it. This cuts down on the amount of"},{"line_number":427,"context_line":"    # uuid warnings in the unit tests by a significant amount."},{"line_number":428,"context_line":"    if resource_id \u003d\u003d ROOT_DOMAIN:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_63e5103d","line":425,"range":{"start_line":425,"start_character":11,"end_line":425,"end_character":19},"in_reply_to":"3f79a3b5_9871c016","updated":"2018-11-29 18:19:35.000000000","message":"thanks @Morgan.","commit_id":"45dbf4a3cbcd79c8895f6508ee5a30326ecc09ce"}]}