)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4a510bb276c1416a69ae70dafabb99380bc92447","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add request_id and global_request_id to cadf notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enhance CADF notifications with request ID and global request ID"},{"line_number":10,"context_line":"for easier requests tracing."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9bc1b29464b76e7d37f73e22062f31231046a496"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_b804f5c5","line":9,"updated":"2018-12-12 22:25:51.000000000","message":"Is this pattern specific to the CADF specification, or is this something that we should consider adding to basic notifications as well?\n\nI think Morgan had a point here too in the bug report since CADF has more strict standards than the basic implementation we have since that doesn\u0027t technically follow a standard.","commit_id":"b4f0d032430cd502e4296d6d09835f4ff6414396"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"5af4d33c1d06fcdce5c4529f77f65e44b82fafe9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add request_id and global_request_id to cadf notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enhance CADF notifications with request ID and global request ID"},{"line_number":10,"context_line":"for easier requests tracing."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9bc1b29464b76e7d37f73e22062f31231046a496"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_a0f90151","line":9,"in_reply_to":"3f79a3b5_7b73b751","updated":"2018-12-14 02:43:27.000000000","message":"the \"request_id\" and \"global_request_id\" is added into INITIATOR. \n\nIIUC, CADF sepc doesn\u0027t tell that what keys must(not) be in INITIATOR. It just describes its concept --- The RESOURCE that initiated, originated, or instigated the event\u0027s ACTION.\n\nIt\u0027s the reason why I\u0027m Ok with this patch.","commit_id":"b4f0d032430cd502e4296d6d09835f4ff6414396"},{"author":{"_account_id":29525,"name":"Artem Vasilyev","email":"artem.v.vasilyev@gmail.com","username":"artem.v.vasilyev"},"change_message_id":"4c23ba16a7852dc59be7aba44449b083b353abab","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add request_id and global_request_id to cadf notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enhance CADF notifications with request ID and global request ID"},{"line_number":10,"context_line":"for easier requests tracing."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9bc1b29464b76e7d37f73e22062f31231046a496"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_dc36b503","line":9,"in_reply_to":"3f79a3b5_7c6626f3","updated":"2019-02-01 08:40:27.000000000","message":"I may implement this for basic notifications after merging this patch, if required","commit_id":"b4f0d032430cd502e4296d6d09835f4ff6414396"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ec3273eab1c45275ec52f7bd6e4d4deae4601714","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add request_id and global_request_id to cadf notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enhance CADF notifications with request ID and global request ID"},{"line_number":10,"context_line":"for easier requests tracing."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9bc1b29464b76e7d37f73e22062f31231046a496"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_7c6626f3","line":9,"in_reply_to":"3f79a3b5_a0f90151","updated":"2018-12-14 16:19:20.000000000","message":"Ack - that said. Do we want to propose a follow-up to add this support for basic notifications, too?","commit_id":"b4f0d032430cd502e4296d6d09835f4ff6414396"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"c0a3d57aa1fc3ee98fceefc41d2cf75effc3fe24","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add request_id and global_request_id to cadf notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enhance CADF notifications with request ID and global request ID"},{"line_number":10,"context_line":"for easier requests tracing."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9bc1b29464b76e7d37f73e22062f31231046a496"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_7b73b751","line":9,"in_reply_to":"3f79a3b5_b804f5c5","updated":"2018-12-12 23:23:32.000000000","message":"The standards aren\u0027t entirely clear, as there are optional fields for specific activity[1] that one could have report specific measurement data (response time).\n\nThe CADF document[0] doesn\u0027t mention request_id or global_id specifically, but they could be considered attributes of an event IMO.\n\nHaving this in the basic notifications could also be an option if this isn\u0027t strictly CADF.\n\n[0] https://www.dmtf.org/sites/default/files/standards/documents/DSP0262_1.0.0.pdf#page\u003d23\n\n[1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0262_1.0.0.pdf#page\u003d32","commit_id":"b4f0d032430cd502e4296d6d09835f4ff6414396"}],"keystone/notifications.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"f5221fbb769f814964f58d3b40833898e4d8b9c0","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    if oslo_context.domain_id:"},{"line_number":103,"context_line":"        initiator.domain_id \u003d oslo_context.domain_id"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    if oslo_context.request_id:"},{"line_number":106,"context_line":"        initiator.request_id \u003d oslo_context.request_id"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    if oslo_context.global_request_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_16935bb2","line":105,"range":{"start_line":105,"start_character":0,"end_line":105,"end_character":31},"updated":"2018-11-16 09:16:10.000000000","message":"Don\u0027t need this check, since request_id is always there.","commit_id":"549e34d26f50d7cb3fb3fd0e292de054a000b1f2"},{"author":{"_account_id":29525,"name":"Artem Vasilyev","email":"artem.v.vasilyev@gmail.com","username":"artem.v.vasilyev"},"change_message_id":"1f558fdb240b6e548b2a622e707dce9ece070022","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    if oslo_context.domain_id:"},{"line_number":103,"context_line":"        initiator.domain_id \u003d oslo_context.domain_id"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    if oslo_context.request_id:"},{"line_number":106,"context_line":"        initiator.request_id \u003d oslo_context.request_id"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    if oslo_context.global_request_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_9c20ed9f","line":105,"range":{"start_line":105,"start_character":0,"end_line":105,"end_character":31},"in_reply_to":"3f79a3b5_16935bb2","updated":"2018-11-16 10:23:51.000000000","message":"Done","commit_id":"549e34d26f50d7cb3fb3fd0e292de054a000b1f2"}],"keystone/tests/unit/common/test_notifications.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e2355d7c44a91696080bef69515f293252e521d4","unresolved":false,"context_lines":[{"line_number":917,"context_line":"            initiator[\u0027global_request_id\u0027], global_request_id)"},{"line_number":918,"context_line":"        self.assertIn(\u0027request_id\u0027, initiator)"},{"line_number":919,"context_line":""},{"line_number":920,"context_line":"        self.post(\u0027/auth/tokens\u0027, body\u003ddata)"},{"line_number":921,"context_line":"        audit \u003d self._audits[-1]"},{"line_number":922,"context_line":"        initiator \u003d audit[\u0027payload\u0027][\u0027initiator\u0027]"},{"line_number":923,"context_line":"        self.assertNotIn(\u0027global_request_id\u0027, initiator)"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"class TestEventCallbacks(test_v3.RestfulTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_86a0d343","line":923,"range":{"start_line":920,"start_character":8,"end_line":923,"end_character":56},"updated":"2019-02-01 19:57:13.000000000","message":"IMO this could be a separate test, but we can do that in a follow-up.","commit_id":"b4f0d032430cd502e4296d6d09835f4ff6414396"}]}