)]}'
{"keystone/common/policies/service_provider.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"fbf1841190bea29097cd60edc655bb36c0413741","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"service_provider_policies \u003d ["},{"line_number":48,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":49,"context_line":"        name\u003dbase.IDENTITY % \u0027create_service_provider\u0027,"},{"line_number":50,"context_line":"        check_str\u003dbase.RULE_ADMIN_REQUIRED,"},{"line_number":51,"context_line":"        # FIXME(lbragstad): Today, keystone doesn\u0027t support federation without"},{"line_number":52,"context_line":"        # modifying configuration files. It makes sense to require system scope"},{"line_number":53,"context_line":"        # for these operations until keystone supports a way to add federated"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f7a4da4f","line":50,"range":{"start_line":49,"start_character":0,"end_line":50,"end_character":43},"updated":"2018-11-29 02:05:35.000000000","message":"so neither name nor check_str is changed. what\u0027s deprecated?","commit_id":"4ee5255bded8bb5f3bf609bcecd5adef1ca21c4e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9cd001d3a3b7c28788bd252ee02692dde76c6958","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"service_provider_policies \u003d ["},{"line_number":48,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":49,"context_line":"        name\u003dbase.IDENTITY % \u0027create_service_provider\u0027,"},{"line_number":50,"context_line":"        check_str\u003dbase.RULE_ADMIN_REQUIRED,"},{"line_number":51,"context_line":"        # FIXME(lbragstad): Today, keystone doesn\u0027t support federation without"},{"line_number":52,"context_line":"        # modifying configuration files. It makes sense to require system scope"},{"line_number":53,"context_line":"        # for these operations until keystone supports a way to add federated"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_aa15904d","line":50,"range":{"start_line":49,"start_character":0,"end_line":50,"end_character":43},"in_reply_to":"3f79a3b5_f7a4da4f","updated":"2018-11-29 15:11:40.000000000","message":"Oh - you\u0027re right. I missed those but since the policy is pretty much the same the tests didn\u0027t catch it.\n\nWill update, thanks!","commit_id":"4ee5255bded8bb5f3bf609bcecd5adef1ca21c4e"}],"releasenotes/notes/bug-1804522-00df902cd2d74ee3.yaml":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"8ebe57623916e4b74f6ee144704204d0efe6f76c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"deprecations:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    [`bug 1804522 \u003chttps://bugs.launchpad.net/keystone/+bug/1804522\u003e`_]"},{"line_number":17,"context_line":"    Several policies used to protect the federated service provider API"},{"line_number":18,"context_line":"    have been deprecated in favor of more clear and concise defaults."},{"line_number":19,"context_line":"    Please consider these new defaults if your deployment overrides the"},{"line_number":20,"context_line":"    federated service provider policies."},{"line_number":21,"context_line":"security:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ffd0ebdf_ac4effbe","line":18,"range":{"start_line":17,"start_character":4,"end_line":18,"end_character":24},"updated":"2019-01-03 09:49:14.000000000","message":"I think it would be good to enumerate which policies specifically have been changed, unless there\u0027s a better way to discover that (upgrading and then reading the logs is not a good way to find out which policies have been changed)","commit_id":"0df07e4a5c524ebb6e4846e3e667148ed9ee162f"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b838b1a14df75cff93aff5cc6e96ccd7d5b3490f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"deprecations:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    [`bug 1804522 \u003chttps://bugs.launchpad.net/keystone/+bug/1804522\u003e`_]"},{"line_number":17,"context_line":"    Several policies used to protect the federated service provider API"},{"line_number":18,"context_line":"    have been deprecated in favor of more clear and concise defaults."},{"line_number":19,"context_line":"    Please consider these new defaults if your deployment overrides the"},{"line_number":20,"context_line":"    federated service provider policies."},{"line_number":21,"context_line":"security:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ffd0ebdf_0821304e","line":18,"range":{"start_line":17,"start_character":4,"end_line":18,"end_character":24},"in_reply_to":"ffd0ebdf_ac4effbe","updated":"2019-01-03 15:40:22.000000000","message":"You\u0027ve made this comment on a few other patches and I thought I addressed them, but I missed a few.\n\nWill fix. Thanks for the review.","commit_id":"0df07e4a5c524ebb6e4846e3e667148ed9ee162f"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"8810897fcb0fa404a2118b8cc7d82da846715aef","unresolved":false,"context_lines":[{"line_number":14,"context_line":"deprecations:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    [`bug 1804522 \u003chttps://bugs.launchpad.net/keystone/+bug/1804522\u003e`_]"},{"line_number":17,"context_line":"    The following federated service provider policy check strings have"},{"line_number":18,"context_line":"    been deprecated in favor of more clear and concise defaults:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    * ``identity:get_service_provider``"},{"line_number":21,"context_line":"    * ``identity:list_service_providers``"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ffd0ebdf_ecef0ee7","line":18,"range":{"start_line":17,"start_character":4,"end_line":18,"end_character":19},"updated":"2019-01-04 11:44:09.000000000","message":"This is kind of unclear, it\u0027s not that the rules listed below were deprecated but their old check strings. This still doesn\u0027t give a picture of what exactly has changed so I as an operator can\u0027t know without looking at the code whether the new defaults are satisfactory to me or if I should update my customizations.","commit_id":"48a42b0182cd384c259cfaeff85f7b3c3e5052dd"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ebafa2a485fa0d3b6568aff01eb7cd60c9f45208","unresolved":false,"context_lines":[{"line_number":14,"context_line":"deprecations:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    [`bug 1804522 \u003chttps://bugs.launchpad.net/keystone/+bug/1804522\u003e`_]"},{"line_number":17,"context_line":"    The following federated service provider policy check strings have"},{"line_number":18,"context_line":"    been deprecated in favor of more clear and concise defaults:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    * ``identity:get_service_provider``"},{"line_number":21,"context_line":"    * ``identity:list_service_providers``"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ffd0ebdf_74276414","line":18,"range":{"start_line":17,"start_character":4,"end_line":18,"end_character":19},"in_reply_to":"ffd0ebdf_140b788e","updated":"2019-01-04 15:06:10.000000000","message":"Yes, I think that would be helpful, unless I\u0027m missing something and there\u0027s a better way to get that information.","commit_id":"48a42b0182cd384c259cfaeff85f7b3c3e5052dd"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f218bda122a8c273448b232abdf8710996d539a0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"deprecations:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    [`bug 1804522 \u003chttps://bugs.launchpad.net/keystone/+bug/1804522\u003e`_]"},{"line_number":17,"context_line":"    The following federated service provider policy check strings have"},{"line_number":18,"context_line":"    been deprecated in favor of more clear and concise defaults:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    * ``identity:get_service_provider``"},{"line_number":21,"context_line":"    * ``identity:list_service_providers``"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ffd0ebdf_48b87f29","line":18,"range":{"start_line":17,"start_character":4,"end_line":18,"end_character":19},"in_reply_to":"ffd0ebdf_74276414","updated":"2019-01-04 17:02:57.000000000","message":"Sounds good. Including the old and new check strings might get a bit long, but I\u0027ll play around with it and see how it renders.","commit_id":"48a42b0182cd384c259cfaeff85f7b3c3e5052dd"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f2840a2ef93af4e00672849a9943a2ecd14a931b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"deprecations:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    [`bug 1804522 \u003chttps://bugs.launchpad.net/keystone/+bug/1804522\u003e`_]"},{"line_number":17,"context_line":"    The following federated service provider policy check strings have"},{"line_number":18,"context_line":"    been deprecated in favor of more clear and concise defaults:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    * ``identity:get_service_provider``"},{"line_number":21,"context_line":"    * ``identity:list_service_providers``"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ffd0ebdf_140b788e","line":18,"range":{"start_line":17,"start_character":4,"end_line":18,"end_character":19},"in_reply_to":"ffd0ebdf_ecef0ee7","updated":"2019-01-04 15:02:25.000000000","message":"Are you suggesting we call it out explicitly with something like \"identity:get_service_provider\" is changing from A to B?","commit_id":"48a42b0182cd384c259cfaeff85f7b3c3e5052dd"}]}