)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"17fd594629fca29fd11ba4d795bfdc6dde51beca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lance Bragstad \u003clbragstad@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-12-19 22:18:05 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tests for domain users interacting with registered limits"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit introduces some tests that explicitly show how domain"},{"line_number":10,"context_line":"users are expected to behave with the registered limits API. A"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ffd0ebdf_d118a5d4","line":7,"updated":"2019-01-04 10:51:16.000000000","message":"Technically this is not just adding tests, I would prefer this was clear that this was adding \u0027domain\u0027 as a valid scope since that\u0027s quite a significant change.","commit_id":"c6bac7cf5414051f2da85ad6294e1cc85ef78757"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d030d5b93e6063f283992e220fc534caee08915e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lance Bragstad \u003clbragstad@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-12-19 22:18:05 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tests for domain users interacting with registered limits"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit introduces some tests that explicitly show how domain"},{"line_number":10,"context_line":"users are expected to behave with the registered limits API. A"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"dfd5e7cf_a16a5c7d","line":7,"in_reply_to":"ffd0ebdf_d118a5d4","updated":"2019-01-08 18:16:29.000000000","message":"Done","commit_id":"c6bac7cf5414051f2da85ad6294e1cc85ef78757"}],"keystone/tests/unit/protection/v3/test_registered_limits.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"1db9f2f1f3c4c0fd5dc9b4580d179158c5db3c77","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            uuid.uuid4().hex, unit.new_domain_ref()"},{"line_number":332,"context_line":"        )"},{"line_number":333,"context_line":"        self.domain_id \u003d domain[\u0027id\u0027]"},{"line_number":334,"context_line":"        domain_admin \u003d unit.new_user_ref(domain_id\u003dself.domain_id)"},{"line_number":335,"context_line":"        self.user_id \u003d PROVIDERS.identity_api.create_user(domain_admin)[\u0027id\u0027]"},{"line_number":336,"context_line":"        PROVIDERS.assignment_api.create_grant("},{"line_number":337,"context_line":"            self.bootstrapper.admin_role_id, user_id\u003dself.user_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfdaf3ff_8183bd56","line":334,"range":{"start_line":334,"start_character":8,"end_line":334,"end_character":20},"updated":"2019-01-11 10:39:51.000000000","message":"domain admin? Isn\u0027t this change about allowing non-admins to access these APIs?","commit_id":"e29ff512bb2a5dde3f9eec2b2a2ec596384ec1a2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3ec76db3694079647b6c7bec3a31ca1644206103","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            uuid.uuid4().hex, unit.new_domain_ref()"},{"line_number":332,"context_line":"        )"},{"line_number":333,"context_line":"        self.domain_id \u003d domain[\u0027id\u0027]"},{"line_number":334,"context_line":"        domain_admin \u003d unit.new_user_ref(domain_id\u003dself.domain_id)"},{"line_number":335,"context_line":"        self.user_id \u003d PROVIDERS.identity_api.create_user(domain_admin)[\u0027id\u0027]"},{"line_number":336,"context_line":"        PROVIDERS.assignment_api.create_grant("},{"line_number":337,"context_line":"            self.bootstrapper.admin_role_id, user_id\u003dself.user_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfdaf3ff_abbb3be3","line":334,"range":{"start_line":334,"start_character":8,"end_line":334,"end_character":20},"in_reply_to":"bfdaf3ff_8183bd56","updated":"2019-01-11 14:14:11.000000000","message":"All the registered limit behavior for domain users is the same, so I just used a single user for these tests.\n\nI can break this out into DomainAdminUserTests, DomainMemberUserTests, DomainReaderUserTests if needed.","commit_id":"e29ff512bb2a5dde3f9eec2b2a2ec596384ec1a2"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ec7a5c7a29fc30b821c2516600194a7e90892988","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            uuid.uuid4().hex, unit.new_domain_ref()"},{"line_number":332,"context_line":"        )"},{"line_number":333,"context_line":"        self.domain_id \u003d domain[\u0027id\u0027]"},{"line_number":334,"context_line":"        domain_admin \u003d unit.new_user_ref(domain_id\u003dself.domain_id)"},{"line_number":335,"context_line":"        self.user_id \u003d PROVIDERS.identity_api.create_user(domain_admin)[\u0027id\u0027]"},{"line_number":336,"context_line":"        PROVIDERS.assignment_api.create_grant("},{"line_number":337,"context_line":"            self.bootstrapper.admin_role_id, user_id\u003dself.user_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bfdaf3ff_164aaa26","line":334,"range":{"start_line":334,"start_character":8,"end_line":334,"end_character":20},"in_reply_to":"bfdaf3ff_abbb3be3","updated":"2019-01-11 14:44:54.000000000","message":"Ah I guess this is fine","commit_id":"e29ff512bb2a5dde3f9eec2b2a2ec596384ec1a2"}]}