)]}'
{"keystone/identity/controllers.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0203d2621dda758e265a7244cbaa6f862f334e99","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class DeprecatedMeta(type):"},{"line_number":38,"context_line":"    \"\"\"Metaclass that ensures that the correct methods on the deprecated"},{"line_number":39,"context_line":"    classes are reported as deprecated on call."},{"line_number":40,"context_line":"    \"\"\""},{"line_number":41,"context_line":"    @staticmethod"},{"line_number":42,"context_line":"    def moved_to_assignment(class_name):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F8vYs%3D","line":39,"updated":"2013-12-20 20:26:29.000000000","message":"this documentation makes it seem like this class is more generic than it really is, since it\u0027s specific to identity and assignment.","commit_id":"3e2a26281c6d48bdb1505bad350ffd5a33831aa4"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"a3e06c52390c64b6a8d0167a017ce18a7ac5c27b","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class DeprecatedMeta(type):"},{"line_number":38,"context_line":"    \"\"\"Metaclass that ensures that the correct methods on the deprecated"},{"line_number":39,"context_line":"    classes are reported as deprecated on call."},{"line_number":40,"context_line":"    \"\"\""},{"line_number":41,"context_line":"    @staticmethod"},{"line_number":42,"context_line":"    def moved_to_assignment(class_name):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F8vX8%3D","line":39,"in_reply_to":"AAAATn%2F8vYs%3D","updated":"2013-12-20 20:30:06.000000000","message":"Fair point.  Will keep in mind for future cases like this.  Since this will be removed in the next cycle early-on, I\u0027ll not worry about updating it.","commit_id":"3e2a26281c6d48bdb1505bad350ffd5a33831aa4"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"127c24013e086c6bcb5a76a047a5fcaa4c17a75d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        # NOTE(morganfainberg): Wrapping non-callables, non-methods, and"},{"line_number":62,"context_line":"        # builtins is not the point of the deprecation warnings. Simple test"},{"line_number":63,"context_line":"        # to ensure the item is one of the types that should be wrapped."},{"line_number":64,"context_line":"        if (callable(item) and"},{"line_number":65,"context_line":"                inspect.ismethod(item) and"},{"line_number":66,"context_line":"                not inspect.isbuiltin(item)):"},{"line_number":67,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F8vYE%3D","line":64,"updated":"2013-12-20 20:34:51.000000000","message":"could just return the condition lol\n\n  return (\n    callable(item) and\n    inspect.ismethod(item) and\n    not inspect.isbuildin(item))","commit_id":"3e2a26281c6d48bdb1505bad350ffd5a33831aa4"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0203d2621dda758e265a7244cbaa6f862f334e99","unresolved":false,"context_lines":[{"line_number":437,"context_line":""},{"line_number":438,"context_line":"# TODO(morganfainberg): Remove proxy compat classes once Icehouse is released."},{"line_number":439,"context_line":"@six.add_metaclass(DeprecatedMeta)"},{"line_number":440,"context_line":"class Tenant(assignment_controllers.Tenant):"},{"line_number":441,"context_line":"    pass"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F8vYk%3D","line":440,"updated":"2013-12-20 20:26:29.000000000","message":"these classes seem unnecessary to me.","commit_id":"3e2a26281c6d48bdb1505bad350ffd5a33831aa4"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"a3e06c52390c64b6a8d0167a017ce18a7ac5c27b","unresolved":false,"context_lines":[{"line_number":437,"context_line":""},{"line_number":438,"context_line":"# TODO(morganfainberg): Remove proxy compat classes once Icehouse is released."},{"line_number":439,"context_line":"@six.add_metaclass(DeprecatedMeta)"},{"line_number":440,"context_line":"class Tenant(assignment_controllers.Tenant):"},{"line_number":441,"context_line":"    pass"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F8vYA%3D","line":440,"in_reply_to":"AAAATn%2F8vYk%3D","updated":"2013-12-20 20:30:06.000000000","message":"I am just making every effort not to rip out the carpet from under people.  The non-v3 ones are likely not required, but the V3 ones use the .wrap_member stuff that might be valid in out-of-tree extensions.","commit_id":"3e2a26281c6d48bdb1505bad350ffd5a33831aa4"}]}