)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"32ed3609fb1bb5e06caa11d061450f0dfdb6a58d","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit also adds a few tests to the test_users protection tests"},{"line_number":15,"context_line":"that show how domain administrators should behave with unsupported"},{"line_number":16,"context_line":"filters for query strings. This change changes the response code to"},{"line_number":17,"context_line":"allow these operations to happen, but doesn\u0027t expose any sensitive"},{"line_number":18,"context_line":"data (e.g., an empty list is returned as opposed to an HTTP 403)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I60b2e2b8af172c369eab0eb2c29f056f5c98ad16"},{"line_number":21,"context_line":"Parial-Bug: 1806762"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5fc1f717_14430c15","line":18,"range":{"start_line":16,"start_character":27,"end_line":18,"end_character":65},"updated":"2019-03-25 11:20:24.000000000","message":"This commit is packing a lot into a change that on first glance is supposed to just be a cleanup change, it would be a lot easier to digest if at least this part was split up. Can you elaborate on why it\u0027s acceptable to change the response code here?","commit_id":"ac31b8e1655e67dcc8a688dc2b2d645cbffa614a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e30bba196d8b40709fcb3633d6819461d37e0829","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit also adds a few tests to the test_users protection tests"},{"line_number":15,"context_line":"that show how domain administrators should behave with unsupported"},{"line_number":16,"context_line":"filters for query strings. This change changes the response code to"},{"line_number":17,"context_line":"allow these operations to happen, but doesn\u0027t expose any sensitive"},{"line_number":18,"context_line":"data (e.g., an empty list is returned as opposed to an HTTP 403)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I60b2e2b8af172c369eab0eb2c29f056f5c98ad16"},{"line_number":21,"context_line":"Parial-Bug: 1806762"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5fc1f717_99288897","line":18,"range":{"start_line":16,"start_character":27,"end_line":18,"end_character":65},"in_reply_to":"5fc1f717_14430c15","updated":"2019-03-25 16:49:43.000000000","message":"I attempted to clarify. Let me know if it helps.","commit_id":"ac31b8e1655e67dcc8a688dc2b2d645cbffa614a"}],"keystone/tests/unit/protection/v3/test_users.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"67cab3746a0a4dc72a4f60b317a6d7776e038109","unresolved":false,"context_lines":[{"line_number":746,"context_line":"        with self.test_client() as c:"},{"line_number":747,"context_line":"            c.post(\u0027/v3/users\u0027, json\u003dcreate, headers\u003dself.headers)"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"    def test_user_can_create_users_within_domain_hyphened_domain_id(self):"},{"line_number":750,"context_line":"        # Finally, show that we can create a new user without any surprises."},{"line_number":751,"context_line":"        # But if we specify a \u0027domain-id\u0027 instead of a \u0027domain_id\u0027, we get a"},{"line_number":752,"context_line":"        # Forbidden response because we fail a policy check before"}],"source_content_type":"text/x-python","patch_set":10,"id":"5fc1f717_878fbe21","line":749,"range":{"start_line":749,"start_character":18,"end_line":749,"end_character":21},"updated":"2019-03-25 18:09:20.000000000","message":"cannot","commit_id":"aeff33bad92ca73c050b6818efbdf6689172ed20"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f05fa4d111e23c81de91c369c555322d2b740007","unresolved":false,"context_lines":[{"line_number":746,"context_line":"        with self.test_client() as c:"},{"line_number":747,"context_line":"            c.post(\u0027/v3/users\u0027, json\u003dcreate, headers\u003dself.headers)"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"    def test_user_can_create_users_within_domain_hyphened_domain_id(self):"},{"line_number":750,"context_line":"        # Finally, show that we can create a new user without any surprises."},{"line_number":751,"context_line":"        # But if we specify a \u0027domain-id\u0027 instead of a \u0027domain_id\u0027, we get a"},{"line_number":752,"context_line":"        # Forbidden response because we fail a policy check before"}],"source_content_type":"text/x-python","patch_set":10,"id":"5fc1f717_f51aecc3","line":749,"range":{"start_line":749,"start_character":18,"end_line":749,"end_character":21},"in_reply_to":"5fc1f717_878fbe21","updated":"2019-03-25 19:38:58.000000000","message":"Done","commit_id":"aeff33bad92ca73c050b6818efbdf6689172ed20"}]}