)]}'
{"keystone/identity/backends/sql.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"817c0db62353916ee1d91fdfed96fb5f578fe8f7","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    def list_users(self, hints):"},{"line_number":165,"context_line":"        with sql.session_for_read() as session:"},{"line_number":166,"context_line":"            query \u003d session.query(model.User).order_by("},{"line_number":167,"context_line":"                model.User.id.asc()).outerjoin(model.LocalUser)"},{"line_number":168,"context_line":"            query, hints \u003d self._create_password_expires_query(session, query,"},{"line_number":169,"context_line":"                                                               hints)"},{"line_number":170,"context_line":"            user_refs \u003d sql.filter_limit_query(model.User, query, hints)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b903de63","line":167,"updated":"2018-12-10 13:53:00.000000000","message":"For other reviewers: if my reading of https://dev.mysql.com/doc/refman/8.0/en/order-by-optimization.html is correct then this shouldn\u0027t have too much of a performance impact, but I don\u0027t have enough experience here to say for sure","commit_id":"75bc06ffd82a47d9a96fa3a5a268ba9862a70a0b"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"0dc2583e844d176b1f31d6cde5a99e5d8f40a8d9","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    def list_users(self, hints):"},{"line_number":165,"context_line":"        with sql.session_for_read() as session:"},{"line_number":166,"context_line":"            query \u003d session.query(model.User).order_by("},{"line_number":167,"context_line":"                model.User.id.asc()).outerjoin(model.LocalUser)"},{"line_number":168,"context_line":"            query, hints \u003d self._create_password_expires_query(session, query,"},{"line_number":169,"context_line":"                                                               hints)"},{"line_number":170,"context_line":"            user_refs \u003d sql.filter_limit_query(model.User, query, hints)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f9ba0b6e","line":167,"in_reply_to":"3f79a3b5_79f83b4a","updated":"2018-12-18 17:42:52.000000000","message":"if User.id is the primary key column as seems very likely here, it\u0027s indexed so the performance impact of ORDER BY for less than say 10M rows is close to zero.","commit_id":"75bc06ffd82a47d9a96fa3a5a268ba9862a70a0b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"592cdd5dfec382238998e3a788f367eb1e95c47c","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    def list_users(self, hints):"},{"line_number":165,"context_line":"        with sql.session_for_read() as session:"},{"line_number":166,"context_line":"            query \u003d session.query(model.User).order_by("},{"line_number":167,"context_line":"                model.User.id.asc()).outerjoin(model.LocalUser)"},{"line_number":168,"context_line":"            query, hints \u003d self._create_password_expires_query(session, query,"},{"line_number":169,"context_line":"                                                               hints)"},{"line_number":170,"context_line":"            user_refs \u003d sql.filter_limit_query(model.User, query, hints)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_79f83b4a","line":167,"in_reply_to":"3f79a3b5_b903de63","updated":"2018-12-18 17:39:35.000000000","message":"It might be good to get zzzeek\u0027s eyes on this.","commit_id":"75bc06ffd82a47d9a96fa3a5a268ba9862a70a0b"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"8543a1b62c386698978a6b0ff94d19d0e027ff56","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    def list_users(self, hints):"},{"line_number":165,"context_line":"        with sql.session_for_read() as session:"},{"line_number":166,"context_line":"            query \u003d session.query(model.User).order_by("},{"line_number":167,"context_line":"                model.User.id.asc()).outerjoin(model.LocalUser)"},{"line_number":168,"context_line":"            query, hints \u003d self._create_password_expires_query(session, query,"},{"line_number":169,"context_line":"                                                               hints)"},{"line_number":170,"context_line":"            user_refs \u003d sql.filter_limit_query(model.User, query, hints)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_99075721","line":167,"in_reply_to":"3f79a3b5_f9ba0b6e","updated":"2018-12-18 17:47:29.000000000","message":"oh also if the issue is that there\u0027s a LIMIT being added, then yes you absolutely need an ORDER BY for that to work deterministically.","commit_id":"75bc06ffd82a47d9a96fa3a5a268ba9862a70a0b"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"817c0db62353916ee1d91fdfed96fb5f578fe8f7","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    def get_user_by_name(self, user_name, domain_id):"},{"line_number":193,"context_line":"        with sql.session_for_read() as session:"},{"line_number":194,"context_line":"            query \u003d session.query(model.User).order_by("},{"line_number":195,"context_line":"                model.User.id.asc()).join(model.LocalUser)"},{"line_number":196,"context_line":"            query \u003d query.filter(sqlalchemy.and_("},{"line_number":197,"context_line":"                model.LocalUser.name \u003d\u003d user_name,"},{"line_number":198,"context_line":"                model.LocalUser.domain_id \u003d\u003d domain_id))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7efd2c3a","line":195,"updated":"2018-12-10 13:53:00.000000000","message":"I don\u0027t think this query uses LIMIT, so does it still have the same probem? Or why is the ordering needed here?","commit_id":"75bc06ffd82a47d9a96fa3a5a268ba9862a70a0b"}]}
