)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3f766211fb414373718d992d6cca99427cbc681b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove message about circular role inferences"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While Cycles could be a problem, this code was detercting them even"},{"line_number":10,"context_line":"when there were none.  If a role gets added twice, it was reporting"},{"line_number":11,"context_line":"an error, but that is possible from the case where two distinct prior"},{"line_number":12,"context_line":"add the same implied role.  Just move on quietly."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_521a5fc8","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":21},"updated":"2018-12-12 21:52:06.000000000","message":"Outside of the message being confusing, isn\u0027t this a separate bug?\n\nIf this was getting logged when there wasn\u0027t a circular reference, then we probably have an issue with that logic. We should open a separate bug so that we can fix and test it separately.\n\nI think I\u0027m ok merging this as-is since it at least clarifies things.","commit_id":"78566e828659b201563e7d07823df30f7b00b0d4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5b54b6a3237ce5c44bbe107fc0aa2fb93ef83354","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove message about circular role inferences"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While Cycles could be a problem, this code was detercting them even"},{"line_number":10,"context_line":"when there were none.  If a role gets added twice, it was reporting"},{"line_number":11,"context_line":"an error, but that is possible from the case where two distinct prior"},{"line_number":12,"context_line":"add the same implied role.  Just move on quietly."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_24b18c01","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":21},"in_reply_to":"3f79a3b5_3068eaf1","updated":"2018-12-13 18:33:11.000000000","message":"Sure - I guess when I read the wording it sounded like there was still work to do.","commit_id":"78566e828659b201563e7d07823df30f7b00b0d4"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"9017f1198353f183de9c1e6bb80979b78197401f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove message about circular role inferences"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While Cycles could be a problem, this code was detercting them even"},{"line_number":10,"context_line":"when there were none.  If a role gets added twice, it was reporting"},{"line_number":11,"context_line":"an error, but that is possible from the case where two distinct prior"},{"line_number":12,"context_line":"add the same implied role.  Just move on quietly."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_3068eaf1","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":21},"in_reply_to":"3f79a3b5_521a5fc8","updated":"2018-12-13 16:14:22.000000000","message":"I don\u0027t have a problem with circular roles if they short-circuit and just expand as expected. It would in-fact be the behavior I would expect. Don\u0027t fail, just don\u0027t get stuck.\n\nI think this is the most correct solution. No further bug is needed. We don\u0027t really care if they are circular, we care about the expanded role-set.","commit_id":"78566e828659b201563e7d07823df30f7b00b0d4"}]}