)]}'
{"keystone/auth/plugins/core.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3f49ce487b575b627498384dae9b56c0ef7b7a00","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            raise exception.ValidationError(attribute\u003d\u0027id or name\u0027,"},{"line_number":166,"context_line":"                                            target\u003d\u0027user\u0027)"},{"line_number":167,"context_line":"        user_ref \u003d {\u0027id\u0027: uuid.uuid4().hex}"},{"line_number":168,"context_line":"        domain_ref \u003d {\u0027id\u0027: uuid.uuid4().hex}"},{"line_number":169,"context_line":"        try:"},{"line_number":170,"context_line":"            if user_name:"},{"line_number":171,"context_line":"                if \u0027domain\u0027 not in user_info:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_aca54c04","line":168,"updated":"2018-12-17 20:14:24.000000000","message":"This is likely going to be tough to understand in the future. It\u0027s not really apparent as to *why* we\u0027re doing this step.\n\nI\u0027m wondering if we can leverage pre/post hooks from flask here instead. For example, we use it for making sure we always protect APIs by checking to make sure a flask-specific variable is set in the RBAC enforcer. We might be able to use a similar pattern to solve this problem, which could help use \"resume normal authentication flow\" as Colleen mentioned, up until we\u0027re about the process the response and we can raise the 401.\n\nOnly suggesting that as a possible option since it might be simpler to understand long-term unless we add some comments and tests to make sure the order of operations here doesn\u0027t change. If a future refactor changes the order of statements here, we could be back to square one.","commit_id":"baaf20e7757f5132f33636abf34b847d4aca72cb"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ddddd425b1383ca610a4ee4f85381ae47064bed9","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            raise exception.ValidationError(attribute\u003d\u0027id or name\u0027,"},{"line_number":166,"context_line":"                                            target\u003d\u0027user\u0027)"},{"line_number":167,"context_line":"        user_ref \u003d {\u0027id\u0027: uuid.uuid4().hex}"},{"line_number":168,"context_line":"        domain_ref \u003d {\u0027id\u0027: uuid.uuid4().hex}"},{"line_number":169,"context_line":"        try:"},{"line_number":170,"context_line":"            if user_name:"},{"line_number":171,"context_line":"                if \u0027domain\u0027 not in user_info:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_a0b08844","line":168,"in_reply_to":"3f79a3b5_aca54c04","updated":"2019-02-14 13:15:13.000000000","message":"++\n\nAt a minimum this needs comments.","commit_id":"baaf20e7757f5132f33636abf34b847d4aca72cb"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ddddd425b1383ca610a4ee4f85381ae47064bed9","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                user_ref \u003d PROVIDERS.identity_api.get_user(user_id)"},{"line_number":179,"context_line":"                domain_ref \u003d PROVIDERS.resource_api.get_domain("},{"line_number":180,"context_line":"                    user_ref[\u0027domain_id\u0027])"},{"line_number":181,"context_line":"                self._assert_user_is_enabled(user_ref)"},{"line_number":182,"context_line":"                self._assert_domain_is_enabled(domain_ref)"},{"line_number":183,"context_line":"        except exception.UserNotFound as e:"},{"line_number":184,"context_line":"            LOG.warning(six.text_type(e))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_80df8464","line":181,"updated":"2019-02-14 13:15:13.000000000","message":"Isn\u0027t this needed in the if clause too?","commit_id":"baaf20e7757f5132f33636abf34b847d4aca72cb"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ddddd425b1383ca610a4ee4f85381ae47064bed9","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                target\u003dresource.Resource(typeURI\u003dtaxonomy.ACCOUNT_USER),"},{"line_number":206,"context_line":"                event_type\u003d_NOTIFY_EVENT,"},{"line_number":207,"context_line":"                reason\u003daudit_reason)"},{"line_number":208,"context_line":"            raise exception.Unauthorized(e)"},{"line_number":209,"context_line":"        self.user_ref \u003d user_ref"},{"line_number":210,"context_line":"        self.user_id \u003d user_ref[\u0027id\u0027]"},{"line_number":211,"context_line":"        self.domain_id \u003d domain_ref[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_40651cb4","line":208,"range":{"start_line":208,"start_character":12,"end_line":208,"end_character":43},"updated":"2019-02-14 13:15:13.000000000","message":"I\u0027m not really clear how this solves the issue, doesn\u0027t this line still cause an early bailout if the user isn\u0027t found?","commit_id":"baaf20e7757f5132f33636abf34b847d4aca72cb"}]}
