)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f2317f1c087671f643f238d0f79b2ba9302c31f7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update, reorganize and clean up the shibboleth guide. Remove the full"},{"line_number":10,"context_line":"example of shibboleth2.xml, it does not add anything useful and just"},{"line_number":11,"context_line":"creates clutter. Use the systemctl command to modernize the service"},{"line_number":12,"context_line":"management commands. Add examples of configuring all required endpoints"},{"line_number":13,"context_line":"in Apache to mirror the new section on configuring protected endpoints"},{"line_number":14,"context_line":"in the main guide and replace the lost examples from the consolidated"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffd0ebdf_5434ae4a","line":11,"range":{"start_line":11,"start_character":25,"end_line":11,"end_character":34},"updated":"2019-01-03 21:32:04.000000000","message":"Aha - I\u0027ve been littering comments about this through the entire string of patches you have up.\n\nThis works for me, but we should update the installation guide as well since I think that\u0027s using `service`.","commit_id":"ed95848e0a921ef363102e928ddb3e78eb40949c"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"6742964b7a8989b4522edfaa78dae874a673ce5d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update, reorganize and clean up the shibboleth guide. Remove the full"},{"line_number":10,"context_line":"example of shibboleth2.xml, it does not add anything useful and just"},{"line_number":11,"context_line":"creates clutter. Use the systemctl command to modernize the service"},{"line_number":12,"context_line":"management commands. Add examples of configuring all required endpoints"},{"line_number":13,"context_line":"in Apache to mirror the new section on configuring protected endpoints"},{"line_number":14,"context_line":"in the main guide and replace the lost examples from the consolidated"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffd0ebdf_1632a3f2","line":11,"range":{"start_line":11,"start_character":25,"end_line":11,"end_character":34},"in_reply_to":"ffd0ebdf_5434ae4a","updated":"2019-01-04 10:26:58.000000000","message":"Ah, I guess I should have included this in the other commit messages where this was changed.","commit_id":"ed95848e0a921ef363102e928ddb3e78eb40949c"}],"doc/source/admin/federation/shibboleth.rst":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8645e76ee6d39d10dc7f93bed6a37939d36fb20c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Setting up Shibboleth"},{"line_number":16,"context_line":"---------------------"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"See the general `Service Provider configuration guide`_ before proceeding with"},{"line_number":19,"context_line":"these Shibboleth-specific instructions."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. _Service Provider configuration guide: keystone-as-sp"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ffd0ebdf_f4f9224d","line":18,"range":{"start_line":18,"start_character":15,"end_line":18,"end_character":55},"updated":"2019-01-03 21:36:49.000000000","message":"This link breaks for me when I check the docs build.\n\nhttp://logs.openstack.org/82/627982/2/check/openstack-tox-docs/6910ed7/html/admin/federation/configure_federation.html#setting-up-shibboleth\nhttp://logs.openstack.org/82/627982/2/check/openstack-tox-docs/6910ed7/html/admin/federation/keystone-as-sp","commit_id":"ed95848e0a921ef363102e928ddb3e78eb40949c"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"6742964b7a8989b4522edfaa78dae874a673ce5d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Setting up Shibboleth"},{"line_number":16,"context_line":"---------------------"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"See the general `Service Provider configuration guide`_ before proceeding with"},{"line_number":19,"context_line":"these Shibboleth-specific instructions."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. _Service Provider configuration guide: keystone-as-sp"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ffd0ebdf_91453d1a","line":18,"range":{"start_line":18,"start_character":15,"end_line":18,"end_character":55},"in_reply_to":"ffd0ebdf_f4f9224d","updated":"2019-01-04 10:26:58.000000000","message":"Done","commit_id":"ed95848e0a921ef363102e928ddb3e78eb40949c"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"dc4b3b2bad17998164ecce489b83bf1fbb187bba","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"   \u003cSSO entityID\u003d\"https://samltest.id/saml/idp\"\u003e"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* Remove the discoveryURL lines unless you want to enable advanced IdP discovery."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"* Tell Shibboleth where to find the metadata of the Identity Provider. You could"},{"line_number":117,"context_line":"  either tell it to fetch it from a URI or point it to a local file. For"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dfd5e7cf_2c6aea7f","side":"PARENT","line":114,"range":{"start_line":114,"start_character":2,"end_line":114,"end_character":81},"updated":"2019-01-08 13:32:02.000000000","message":"Missing this part.","commit_id":"069392fe95f59d3ab5933644adefb27a48cfb4b3"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"dc4b3b2bad17998164ecce489b83bf1fbb187bba","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":".. code-block:: xml"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"   \u003cSSO entityID\u003d\"https://samltest.id/saml/idp\" ECP\u003d\"true\"\u003e"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Tell Shibboleth where to find the metadata of the Identity Provider. You could"},{"line_number":177,"context_line":"either tell it to fetch it from a URI or point it to a local file. For example,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dfd5e7cf_ac5edae3","line":174,"updated":"2019-01-08 13:32:02.000000000","message":"Previously we also mentioned about the usage of discovery protocol in case of more than one IdPs, where we do not required to mention IDP entity ID, but to configure SP with a discovery protocol. The information was less though.\n\nI tried configuring my SP with more than one IDP with [1].So my suggestion is to add more information regarding this in federation docs taking [1] as example? \n\n[1] https://github.com/ConsortiumGARR/idem-tutorials/blob/master/idem-fedops/HOWTO-Shibboleth/Embedded%20Discovery%20Service/Ubuntu/HOWTO%20Install%20and%20Configure%20a%20Shibboleth%20Embedded%20Discovery%20Service%20on%20Ubuntu%20Linux.md","commit_id":"83c37f4a943e8e7181f2f6f973b82885f598e010"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"b5d5861e7310327ffd0752756c7abe065f06bd7f","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":".. code-block:: xml"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"   \u003cSSO entityID\u003d\"https://samltest.id/saml/idp\" ECP\u003d\"true\"\u003e"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Tell Shibboleth where to find the metadata of the Identity Provider. You could"},{"line_number":177,"context_line":"either tell it to fetch it from a URI or point it to a local file. For example,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dfd5e7cf_074b3384","line":174,"in_reply_to":"dfd5e7cf_05a019f4","updated":"2019-01-09 01:56:27.000000000","message":"++for Vishakha\u0027s idea. So we can add it as additional guide like Colleen said. Let\u0027s make the guide simpler first.","commit_id":"83c37f4a943e8e7181f2f6f973b82885f598e010"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"df7ca023bf869c1a27ba4744c580e00cbc5c0058","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":".. code-block:: xml"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"   \u003cSSO entityID\u003d\"https://samltest.id/saml/idp\" ECP\u003d\"true\"\u003e"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Tell Shibboleth where to find the metadata of the Identity Provider. You could"},{"line_number":177,"context_line":"either tell it to fetch it from a URI or point it to a local file. For example,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dfd5e7cf_05a019f4","line":174,"in_reply_to":"dfd5e7cf_ac5edae3","updated":"2019-01-08 15:17:26.000000000","message":"I can add back the line about removing the discoveryURL, the reason I removed the note was I found things seemed to still work even when the line was left there, so removing the note made things simpler. My feeling is that implementing a discovery service is out of scope for this document, this should only be the bare minimum to get things to work.","commit_id":"83c37f4a943e8e7181f2f6f973b82885f598e010"}]}