)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"0ec79a116d697087f271ba0663092f33dcad8a57","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Juan Manuel Olle \u003cjuan.m.olle@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-18 12:56:42 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"service-create allows 2 services with same name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Two service must not share the same name"},{"line_number":10,"context_line":"To avoid that the name is estracted from the extra"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F8qdk%3D","line":7,"updated":"2013-12-23 15:00:46.000000000","message":"In this line you should describe the change, instead of what is the problem.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages","commit_id":"90a77844068ee642b38e1e293e16bdf7402ed57d"}],"keystone/common/sql/migrate_repo/versions/036_extract_name_from_meta_in_services.py":[{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"0ec79a116d697087f271ba0663092f33dcad8a57","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        except sql.exc.IntegrityError:"},{"line_number":48,"context_line":"            msg \u003d _(\u0027Service name %(name)s already exists\u0027)"},{"line_number":49,"context_line":"            message \u003d msg % {\u0027name\u0027: service_name}"},{"line_number":50,"context_line":"            raise exception.Conflict(type\u003d\u0027service\u0027, details\u003dmessage)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    session.commit()"},{"line_number":53,"context_line":"    session.close()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F8qbs%3D","line":50,"updated":"2013-12-23 15:00:46.000000000","message":"Maybe you can pass this piece of code as a parameter. If you do that you could reuse the common code between the migrate_name_from_extra_json_to_name() and migrate_name_from_name_to_extra_json() methods.","commit_id":"90a77844068ee642b38e1e293e16bdf7402ed57d"}],"keystone/common/sql/migrate_repo/versions/037_extract_name_from_meta_in_services.py":[{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"61ba8a5f004ec0ca611dc8b2cf1898db36418a93","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        while not inserted:"},{"line_number":41,"context_line":"            values \u003d {}"},{"line_number":42,"context_line":"            if service_name is not None:"},{"line_number":43,"context_line":"                if index !\u003d 1:"},{"line_number":44,"context_line":"                    values[\u0027name\u0027] \u003d service_name + str(index)"},{"line_number":45,"context_line":"                else:"},{"line_number":46,"context_line":"                    values[\u0027name\u0027] \u003d service_name"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FRaU%3D","line":43,"updated":"2014-01-15 16:23:15.000000000","message":"I\u0027m Not completely sure if the duplicated name should be replace by the name with a number. but if I don\u0027t do that, the migration from alder version where nova or cinder is duplicated will fail","commit_id":"b045a114e7821eddaa8ab3360eef672567fcdeb4"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"61ba8a5f004ec0ca611dc8b2cf1898db36418a93","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                migrate_engine.execute(update)"},{"line_number":53,"context_line":"                inserted \u003d True"},{"line_number":54,"context_line":"            except sql.exc.IntegrityError:"},{"line_number":55,"context_line":"                if index \u003c 10:"},{"line_number":56,"context_line":"                    index +\u003d 1"},{"line_number":57,"context_line":"                else:"},{"line_number":58,"context_line":"                    msg \u003d _(\u0027Service name %(name)s already exists\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2FRZg%3D","line":55,"updated":"2014-01-15 16:23:15.000000000","message":"I set a limit to 10 for insert retry with the name + number. I Only find 2 duplicate names. (I know it is a magic number)","commit_id":"b045a114e7821eddaa8ab3360eef672567fcdeb4"}]}