)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"8110e0a346fd826194e3b1cc02d0fe0d643909cd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Islam Musleh \u003cislam.musleh@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-01-16 07:32:11 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updates done according to notes given"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If00b829e684ee0928ebb89291ef59b86176e7f76"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfdaf3ff_81db61eb","line":7,"updated":"2019-01-16 16:14:31.000000000","message":"Could you please elaborate the commit message. The purpose of commit message is to help the reviewers to understand the problem statement for which the changes have been done. You can also provide the link to the notes you are referring here.","commit_id":"3bedd1957eb30066df1e1ee6d7ea5532e02f333d"}],"keystone/tests/unit/test_app_config.py":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"07410d2d2b0e709a21775fa7f37fcf8d214a5331","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    custom_config_files \u003d [\u0027kst.conf\u0027, \u0027kst2.conf\u0027]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_config_files_have_default_values_when_envars_not_set(self):"},{"line_number":29,"context_line":" "},{"line_number":30,"context_line":"        config_files \u003d server_flask._get_config_files()"},{"line_number":31,"context_line":"        config_files.sort()"},{"line_number":32,"context_line":"        expected_config_files \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfdaf3ff_4972694b","line":29,"updated":"2019-01-17 16:03:32.000000000","message":"You can remove these spaces.","commit_id":"a858bea1533b7a24f9a953556cbf97bc7975e4b6"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"fc8d4b6c23533c9af9d7e81a9a7101df8d7fb04b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    custom_config_dir \u003d \u0027/etc/kst/\u0027"},{"line_number":26,"context_line":"    custom_config_files \u003d [\u0027kst.conf\u0027, \u0027kst2.conf\u0027]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_config_files_have_default_values_when_envars_not_set(self): "},{"line_number":29,"context_line":"        config_files \u003d server_flask._get_config_files()"},{"line_number":30,"context_line":"        config_files.sort()"},{"line_number":31,"context_line":"        expected_config_files \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_5e9362a4","line":28,"range":{"start_line":28,"start_character":71,"end_line":28,"end_character":73},"updated":"2019-02-05 16:16:12.000000000","message":"Missed this one.","commit_id":"b7f8cb402ac5f2bbf0561bc8f4781fb747728057"}],"keystone/tests/unit/test_v3_application_credential.py":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"8110e0a346fd826194e3b1cc02d0fe0d643909cd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                \u0027/v3/users/%s/application_credentials\u0027 % self.user_id,"},{"line_number":60,"context_line":"                json\u003dapp_cred_body,"},{"line_number":61,"context_line":"                expected_status_code\u003dhttp_client.CREATED,"},{"line_number":62,"context_line":"                headers\u003d{\u0027X-Auth-Token\u0027: token}) "},{"line_number":63,"context_line":"        # Create operation returns the secret"},{"line_number":64,"context_line":"        self.assertIn(\u0027secret\u0027, resp.json[\u0027application_credential\u0027])"},{"line_number":65,"context_line":"        # But not the stored hash"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_21f4f55a","line":62,"updated":"2019-01-16 16:14:31.000000000","message":"unrelated changes?","commit_id":"3bedd1957eb30066df1e1ee6d7ea5532e02f333d"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"8110e0a346fd826194e3b1cc02d0fe0d643909cd","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def test_create_application_credential_with_secret(self):"},{"line_number":69,"context_line":"        with self.test_client() as c:"},{"line_number":70,"context_line":"            secret \u003d \u0027supersecuresecret\u0027"},{"line_number":71,"context_line":"            roles \u003d [{\u0027id\u0027: self.role_id}]"},{"line_number":72,"context_line":"            app_cred_body \u003d self._app_cred_body(roles\u003droles, secret\u003dsecret)"},{"line_number":73,"context_line":"            token \u003d self.get_scoped_token()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_c19f2901","line":70,"updated":"2019-01-16 16:14:31.000000000","message":"does it make any difference moving this inside with?","commit_id":"3bedd1957eb30066df1e1ee6d7ea5532e02f333d"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"07410d2d2b0e709a21775fa7f37fcf8d214a5331","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def test_create_application_credential_with_secret(self):"},{"line_number":69,"context_line":"        with self.test_client() as c:"},{"line_number":70,"context_line":"            secret \u003d \u0027supersecuresecret\u0027"},{"line_number":71,"context_line":"            roles \u003d [{\u0027id\u0027: self.role_id}]"},{"line_number":72,"context_line":"            app_cred_body \u003d self._app_cred_body(roles\u003droles, secret\u003dsecret)"},{"line_number":73,"context_line":"            token \u003d self.get_scoped_token()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfdaf3ff_09e461e0","line":70,"updated":"2019-01-17 16:03:32.000000000","message":"IMO changing this will not make any difference.","commit_id":"a858bea1533b7a24f9a953556cbf97bc7975e4b6"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"07410d2d2b0e709a21775fa7f37fcf8d214a5331","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                  json\u003dapp_cred_body,"},{"line_number":117,"context_line":"                  expected_status_code\u003dhttp_client.BAD_REQUEST,"},{"line_number":118,"context_line":"                  headers\u003d{\u0027X-Auth-Token\u0027: token} )"},{"line_number":119,"context_line":"    "},{"line_number":120,"context_line":"    def test_create_application_credential_with_expiration(self):"},{"line_number":121,"context_line":"        with self.test_client() as c:"},{"line_number":122,"context_line":"            roles \u003d [{\u0027id\u0027: self.role_id}]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfdaf3ff_69fbad78","line":119,"updated":"2019-01-17 16:03:32.000000000","message":"Same for all these red highlighted area. These are the spaces created in the file. We can remove them","commit_id":"a858bea1533b7a24f9a953556cbf97bc7975e4b6"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"07410d2d2b0e709a21775fa7f37fcf8d214a5331","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        with self.test_client() as c:"},{"line_number":122,"context_line":"            roles \u003d [{\u0027id\u0027: self.role_id}]"},{"line_number":123,"context_line":"            expires \u003d datetime.datetime.utcnow() + datetime.timedelta(days\u003d365)"},{"line_number":124,"context_line":"            expires \u003d str(expires)"},{"line_number":125,"context_line":"            app_cred_body \u003d self._app_cred_body(roles\u003droles, expires\u003dexpires)"},{"line_number":126,"context_line":"            token \u003d self.get_scoped_token()"},{"line_number":127,"context_line":"            resp\u003dc.post(\u0027/v3/users/%s/application_credentials\u0027 % self.user_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfdaf3ff_494349b0","line":124,"updated":"2019-01-17 16:03:32.000000000","message":"Any specific reason for converting it to string?","commit_id":"a858bea1533b7a24f9a953556cbf97bc7975e4b6"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"07410d2d2b0e709a21775fa7f37fcf8d214a5331","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            auth_data \u003d self.build_authentication_request("},{"line_number":165,"context_line":"                app_cred_id\u003dapp_cred_1.json[\u0027application_credential\u0027][\u0027id\u0027],"},{"line_number":166,"context_line":"                secret\u003dapp_cred_1.json[\u0027application_credential\u0027][\u0027secret\u0027])"},{"line_number":167,"context_line":"            token_data \u003d self.v3_create_token(auth_data,"},{"line_number":168,"context_line":"                                          expected_status\u003dhttp_client.CREATED)"},{"line_number":169,"context_line":"            app_cred_body_2 \u003d self._app_cred_body(roles\u003droles)"},{"line_number":170,"context_line":"            token\u003dtoken_data.headers[\u0027x-subject-token\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfdaf3ff_a943d56b","line":167,"updated":"2019-01-17 16:03:32.000000000","message":"As you have already issued a token in L158. I dont think we need to issue the token again.","commit_id":"a858bea1533b7a24f9a953556cbf97bc7975e4b6"}]}