)]}'
{"keystone/server/flask/request_processing/middleware/auth_context.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"57d766bffb4f4be4f4007c764e22e62c434522df","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def __init__(self, app):"},{"line_number":242,"context_line":"        super(AuthContextMiddleware, self).__init__(app, log\u003dLOG,"},{"line_number":243,"context_line":"                                                    service_type\u003d\u0027identity\u0027)"},{"line_number":244,"context_line":"        self.token \u003d None"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def fetch_token(self, token, **kwargs):"}],"source_content_type":"text/x-python","patch_set":30,"id":"5faad753_747ff114","line":243,"updated":"2019-09-12 16:04:18.000000000","message":"Interesting - is this required somehow?","commit_id":"95ad7178ea5389e5056b1035845a06ea1868853a"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"7869c52ac60dd991447a90ce7b5784fae1d1a6b0","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def __init__(self, app):"},{"line_number":242,"context_line":"        super(AuthContextMiddleware, self).__init__(app, log\u003dLOG,"},{"line_number":243,"context_line":"                                                    service_type\u003d\u0027identity\u0027)"},{"line_number":244,"context_line":"        self.token \u003d None"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def fetch_token(self, token, **kwargs):"}],"source_content_type":"text/x-python","patch_set":30,"id":"5faad753_f47a01ef","line":243,"in_reply_to":"5faad753_747ff114","updated":"2019-09-12 16:09:10.000000000","message":"Not sure what your question is. Passing the service_type is required by keystonemiddleware to make access rules work: https://opendev.org/openstack/keystonemiddleware/src/branch/master/keystonemiddleware/auth_token/__init__.py#L556-L560","commit_id":"95ad7178ea5389e5056b1035845a06ea1868853a"}],"keystone/token/provider.py":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"63815334a8e673c15430609d51e6c36de6811d89","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                token.application_credential_id)"},{"line_number":212,"context_line":"            if (app_cred.get(\u0027access_rules\u0027) is not None and"},{"line_number":213,"context_line":"                (not access_rules_support or"},{"line_number":214,"context_line":"                 float(access_rules_support) \u003c ACCESS_RULES_MIN_VERSION)):"},{"line_number":215,"context_line":"                LOG.exception(\u0027Attempted to use application credential\u0027"},{"line_number":216,"context_line":"                              \u0027 access rules with a middleware that does not\u0027"},{"line_number":217,"context_line":"                              \u0027 understand them. You must upgrade\u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"7faddb67_fdc60468","line":214,"range":{"start_line":214,"start_character":17,"end_line":214,"end_character":71},"updated":"2019-08-06 10:40:23.000000000","message":"wrapping this in parenthesis will provide more clarity","commit_id":"01d17d72711c5f25807040787746bfb649e42f7c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"57d766bffb4f4be4f4007c764e22e62c434522df","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            raise exception.TokenNotFound(_(\u0027Failed to validate token\u0027))"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def _validate_token_access_rules(self, token, access_rules_support\u003dNone):"},{"line_number":208,"context_line":"        if token.application_credential_id:"},{"line_number":209,"context_line":"            app_cred_api \u003d PROVIDERS.application_credential_api"},{"line_number":210,"context_line":"            app_cred \u003d app_cred_api.get_application_credential("}],"source_content_type":"text/x-python","patch_set":30,"id":"5faad753_74cdb164","line":207,"range":{"start_line":207,"start_character":50,"end_line":207,"end_character":70},"updated":"2019-09-12 16:04:18.000000000","message":"nit: This variable name reads like a boolean instead of a float representing a version.\n\nI wasn\u0027t really sure what type we were dealing with until I got to this method and actually saw how it was being used.","commit_id":"95ad7178ea5389e5056b1035845a06ea1868853a"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"7869c52ac60dd991447a90ce7b5784fae1d1a6b0","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            raise exception.TokenNotFound(_(\u0027Failed to validate token\u0027))"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def _validate_token_access_rules(self, token, access_rules_support\u003dNone):"},{"line_number":208,"context_line":"        if token.application_credential_id:"},{"line_number":209,"context_line":"            app_cred_api \u003d PROVIDERS.application_credential_api"},{"line_number":210,"context_line":"            app_cred \u003d app_cred_api.get_application_credential("}],"source_content_type":"text/x-python","patch_set":30,"id":"5faad753_14cebd2d","line":207,"range":{"start_line":207,"start_character":50,"end_line":207,"end_character":70},"in_reply_to":"5faad753_74cdb164","updated":"2019-09-12 16:09:10.000000000","message":"Might be because I have been thinking of it as moreorless a boolean, I don\u0027t anticipate that we\u0027ll increment the version. Suggestions for what to change it to? Maybe access_rules_support_version?","commit_id":"95ad7178ea5389e5056b1035845a06ea1868853a"}]}