)]}'
{"keystone/token/token_formatters.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"38fd2c05cb32ae674cdfe2f94022be8f52cdf7ab","unresolved":false,"context_lines":[{"line_number":600,"context_line":"                               audit_ids))"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        return (b_user_id, methods, b_scope_id, b_group_ids, b_idp_id,"},{"line_number":603,"context_line":"                protocol_id, expires_at_int, b_audit_ids)"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"    @classmethod"},{"line_number":606,"context_line":"    def disassemble(cls, payload):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_43256bc1","line":603,"range":{"start_line":603,"start_character":16,"end_line":603,"end_character":27},"updated":"2019-01-26 07:25:58.000000000","message":"I have a question maybe not related to the bug. why protocol_id didn\u0027t be encoded as \"idp_id\" did?","commit_id":"bc5a299f5d2c6cbe310d3e3d563d6808919ff5cd"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2796ac85786490778b9fc74d2f3601cdf29d795a","unresolved":false,"context_lines":[{"line_number":600,"context_line":"                               audit_ids))"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        return (b_user_id, methods, b_scope_id, b_group_ids, b_idp_id,"},{"line_number":603,"context_line":"                protocol_id, expires_at_int, b_audit_ids)"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"    @classmethod"},{"line_number":606,"context_line":"    def disassemble(cls, payload):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_770056ac","line":603,"range":{"start_line":603,"start_character":16,"end_line":603,"end_character":27},"in_reply_to":"9fdfeff1_43256bc1","updated":"2019-01-28 15:05:30.000000000","message":"Probably because it\u0027s highly unlikely we would encode it since it\u0027s usually a human-readable string (e.g., saml2, oidc, x509), where as idp_id could be a uuid.uuid4().hex, which we can encode as bytes for a smaller representation before handing it to msgpack.","commit_id":"bc5a299f5d2c6cbe310d3e3d563d6808919ff5cd"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"38fd2c05cb32ae674cdfe2f94022be8f52cdf7ab","unresolved":false,"context_lines":[{"line_number":611,"context_line":"        (is_stored_as_bytes, scope_id) \u003d payload[2]"},{"line_number":612,"context_line":"        if is_stored_as_bytes:"},{"line_number":613,"context_line":"            scope_id \u003d cls.convert_uuid_bytes_to_hex(scope_id)"},{"line_number":614,"context_line":"        elif not is_stored_as_bytes:"},{"line_number":615,"context_line":"            # NOTE(lbragstad): We assembled the token payload scope as a tuple"},{"line_number":616,"context_line":"            # (False, domain_id) for cases like (False, \u0027default\u0027), since the"},{"line_number":617,"context_line":"            # default domain ID isn\u0027t converted to a byte string when it\u0027s not"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_a3bbf76f","line":614,"range":{"start_line":614,"start_character":8,"end_line":614,"end_character":36},"updated":"2019-01-26 07:25:58.000000000","message":"it could be just \"else\"","commit_id":"bc5a299f5d2c6cbe310d3e3d563d6808919ff5cd"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2796ac85786490778b9fc74d2f3601cdf29d795a","unresolved":false,"context_lines":[{"line_number":611,"context_line":"        (is_stored_as_bytes, scope_id) \u003d payload[2]"},{"line_number":612,"context_line":"        if is_stored_as_bytes:"},{"line_number":613,"context_line":"            scope_id \u003d cls.convert_uuid_bytes_to_hex(scope_id)"},{"line_number":614,"context_line":"        elif not is_stored_as_bytes:"},{"line_number":615,"context_line":"            # NOTE(lbragstad): We assembled the token payload scope as a tuple"},{"line_number":616,"context_line":"            # (False, domain_id) for cases like (False, \u0027default\u0027), since the"},{"line_number":617,"context_line":"            # default domain ID isn\u0027t converted to a byte string when it\u0027s not"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_77193620","line":614,"range":{"start_line":614,"start_character":8,"end_line":614,"end_character":36},"in_reply_to":"9fdfeff1_a3bbf76f","updated":"2019-01-28 15:05:30.000000000","message":"Done","commit_id":"bc5a299f5d2c6cbe310d3e3d563d6808919ff5cd"}]}