)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"efed696beacab5ceda6e6958fc8d3f03717f782c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"and installation for CentOS in federation.sh, and also modify"},{"line_number":11,"context_line":"uninstall_federation function for removing Shibboleth packages"},{"line_number":12,"context_line":"when running `./unstack.sh`."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8c0f63d0a4fe19eab58e7cba3c49905f35266f9d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_b9255f5e","line":13,"updated":"2019-01-27 14:10:33.000000000","message":"This should have this tag:\n\n Partial-bug: #1757000\n\nTo relate it to the bug https://bugs.launchpad.net/keystone/+bug/1757000","commit_id":"e303dd44b6f5c58c4b17de4ace58a12377a861ad"}],"devstack/lib/federation.sh":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"3e4a452430eee99057eff819efdff3d3c0f92b98","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Add Shibboleth repository with curl"},{"line_number":74,"context_line":"        curl https://download.opensuse.org/repositories/security://shibboleth/CentOS_7/security:shibboleth.repo \\"},{"line_number":75,"context_line":"        | sudo tee /etc/yum.repos.d/shibboleth.repo \u003e/dev/null"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # Install Shibboleth"},{"line_number":78,"context_line":"        install_package shibboleth"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9fdfeff1_59fd53af","line":75,"updated":"2019-01-27 14:09:15.000000000","message":"This is fine for now, but I\u0027ve proposed https://review.openstack.org/633409 to see if we can add a mirror so that we can rely less on network in CI.","commit_id":"e303dd44b6f5c58c4b17de4ace58a12377a861ad"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"3e4a452430eee99057eff819efdff3d3c0f92b98","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        # Create a new keypair for Shibboleth"},{"line_number":81,"context_line":"        sudo /etc/shibboleth/keygen.sh -f -o /etc/shibboleth"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # Enable Shibboleth module"},{"line_number":84,"context_line":"        $SYSTEMCTL start shibd"},{"line_number":85,"context_line":"    else"},{"line_number":86,"context_line":"        echo \"Skipping installation of shibboleth for non ubuntu nor fedora host\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9fdfeff1_598c737e","line":83,"range":{"start_line":83,"start_character":8,"end_line":83,"end_character":34},"updated":"2019-01-27 14:09:15.000000000","message":"This is actually starting the service, not enabling the apache module (the package probably already enables the module)","commit_id":"e303dd44b6f5c58c4b17de4ace58a12377a861ad"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"3e4a452430eee99057eff819efdff3d3c0f92b98","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        sudo /etc/shibboleth/keygen.sh -f -o /etc/shibboleth"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        # Enable Shibboleth module"},{"line_number":84,"context_line":"        $SYSTEMCTL start shibd"},{"line_number":85,"context_line":"    else"},{"line_number":86,"context_line":"        echo \"Skipping installation of shibboleth for non ubuntu nor fedora host\""},{"line_number":87,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9fdfeff1_398f2f76","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":24},"updated":"2019-01-27 14:09:15.000000000","message":"I would use the start_service devstack function","commit_id":"e303dd44b6f5c58c4b17de4ace58a12377a861ad"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"75be5607414bfbf8b67d9ed5ed86e3f61fc9ba72","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        # Enable the Shibboleth module for Apache"},{"line_number":68,"context_line":"        sudo a2enmod shib2"},{"line_number":69,"context_line":"    elif is_fedora; then"},{"line_number":70,"context_line":"        # NOTE(knikolla): For CentOS/RHEL, installing shibboleth is tricky"},{"line_number":71,"context_line":"        # It requires adding a separate repo not officially supported"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fdfeff1_1ebfacb0","line":69,"updated":"2019-01-28 07:47:46.000000000","message":"Can you add a note here, \u0027is_fedora\u0027 check for all fedora distributions as mentioned in [1].\n\nhttp://git.openstack.org/cgit/openstack-dev/devstack/tree/functions-common#n447","commit_id":"12d56691034b8edc730fa042fdfac0fe65f7a647"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"75be5607414bfbf8b67d9ed5ed86e3f61fc9ba72","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        sudo a2enmod shib2"},{"line_number":69,"context_line":"    elif is_fedora; then"},{"line_number":70,"context_line":"        # NOTE(knikolla): For CentOS/RHEL, installing shibboleth is tricky"},{"line_number":71,"context_line":"        # It requires adding a separate repo not officially supported"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Add Shibboleth repository with curl"},{"line_number":74,"context_line":"        curl https://download.opensuse.org/repositories/security://shibboleth/CentOS_7/security:shibboleth.repo \\"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fdfeff1_7e7838c3","line":71,"range":{"start_line":71,"start_character":10,"end_line":71,"end_character":69},"updated":"2019-01-28 07:47:46.000000000","message":"We can now remove this comment or can restructure it , as this patch is now supporting shibboleth for CentOS/RHEL.","commit_id":"12d56691034b8edc730fa042fdfac0fe65f7a647"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"846a6f31c2c6d4931ba6a423686337e63812ba86","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        sudo a2enmod shib2"},{"line_number":69,"context_line":"    elif is_fedora; then"},{"line_number":70,"context_line":"        # NOTE(knikolla): For CentOS/RHEL, installing shibboleth is tricky"},{"line_number":71,"context_line":"        # It requires adding a separate repo not officially supported"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Add Shibboleth repository with curl"},{"line_number":74,"context_line":"        curl https://download.opensuse.org/repositories/security://shibboleth/CentOS_7/security:shibboleth.repo \\"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fdfeff1_91714a0f","line":71,"range":{"start_line":71,"start_character":10,"end_line":71,"end_character":69},"in_reply_to":"9fdfeff1_7e7838c3","updated":"2019-01-28 13:48:40.000000000","message":"I would not remove this comment, it actually still applies because CentOS still doesn\u0027t have its own official repo for shibboleth.","commit_id":"12d56691034b8edc730fa042fdfac0fe65f7a647"}]}