)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"83562c924091a84fcccc4f02f7205a20b01b482a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"This commit updates the help text of the cache_on_issue configuration"},{"line_number":17,"context_line":"option to accurately describe what it does."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We should consider if we want this to be the behavior we want or if"},{"line_number":20,"context_line":"keystone should not cache_on_issue if token caching is disabled."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I1e1117deabadaba26ea8e833a06180529e1e0a4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_96cf217e","line":20,"range":{"start_line":19,"start_character":64,"end_line":20,"end_character":64},"updated":"2019-02-11 02:49:49.000000000","message":"++, Leave my vote here: I prefer \"caching\" is the main switch. If \"caching\u003dFalse\", \"cache_on_issue\" should not work.","commit_id":"335fa0b44d879236de2bcadc4203148167f9f048"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0449009dc208e66f200d37656c9287f27df18cb2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"This commit updates the help text of the cache_on_issue configuration"},{"line_number":17,"context_line":"option to accurately describe what it does."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We should consider if we want this to be the behavior we want or if"},{"line_number":20,"context_line":"keystone should not cache_on_issue if token caching is disabled."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I1e1117deabadaba26ea8e833a06180529e1e0a4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_98c66b49","line":20,"range":{"start_line":19,"start_character":64,"end_line":20,"end_character":64},"in_reply_to":"9fdfeff1_96cf217e","updated":"2019-02-11 10:05:59.000000000","message":"Agreed, I used to believe that both of them are the prerequisite for token caching, it\u0027s debatable.","commit_id":"335fa0b44d879236de2bcadc4203148167f9f048"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"458ab83a081f07e18b29189b7cd998500957c147","unresolved":false,"context_lines":[{"line_number":16,"context_line":"This commit updates the help text of the cache_on_issue configuration"},{"line_number":17,"context_line":"option to accurately describe what it does."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"We should consider if we want this to be the behavior we want or if"},{"line_number":20,"context_line":"keystone should not cache_on_issue if token caching is disabled."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I1e1117deabadaba26ea8e833a06180529e1e0a4b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_9e0dee91","line":20,"range":{"start_line":19,"start_character":64,"end_line":20,"end_character":64},"in_reply_to":"9fdfeff1_98c66b49","updated":"2019-02-11 16:33:15.000000000","message":"Yeah - I think I agree. The original implementation of cache_on_issue should have checked if caching was enabled.\n\nUnfortunately, users could be using this without realizing it (if they have token caching disabled, the would still be caching tokens on issue). If we change the logic, we could negatively impact performance since we wouldn\u0027t be caching those tokens anymore.\n\nWe could address that with an upgrade release note.","commit_id":"335fa0b44d879236de2bcadc4203148167f9f048"}],"keystone/conf/token.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0449009dc208e66f200d37656c9287f27df18cb2","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":108,"context_line":"Enable storing issued token data to token validation cache so that first token"},{"line_number":109,"context_line":"validation doesn\u0027t actually cause full validation cycle. This option has no"},{"line_number":110,"context_line":"effect unless global caching is enabled and will still cache tokens even if"},{"line_number":111,"context_line":"`[token] caching \u003d False`."},{"line_number":112,"context_line":"\"\"\"))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"allow_expired_window \u003d cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_18e03bcc","line":111,"range":{"start_line":110,"start_character":29,"end_line":111,"end_character":24},"updated":"2019-02-11 10:05:59.000000000","message":"This looks like a bug, if it still works why we need the option here?","commit_id":"335fa0b44d879236de2bcadc4203148167f9f048"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"458ab83a081f07e18b29189b7cd998500957c147","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":108,"context_line":"Enable storing issued token data to token validation cache so that first token"},{"line_number":109,"context_line":"validation doesn\u0027t actually cause full validation cycle. This option has no"},{"line_number":110,"context_line":"effect unless global caching is enabled and will still cache tokens even if"},{"line_number":111,"context_line":"`[token] caching \u003d False`."},{"line_number":112,"context_line":"\"\"\"))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"allow_expired_window \u003d cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_9ed08ecb","line":111,"range":{"start_line":110,"start_character":29,"end_line":111,"end_character":24},"in_reply_to":"9fdfeff1_18e03bcc","updated":"2019-02-11 16:33:15.000000000","message":"Correct, Dolph actually had that same concern in the original review [0].\n\nI can push another revision of this patch that deprecates this option for removal.\n\n[0] https://review.openstack.org/#/c/309146/21","commit_id":"335fa0b44d879236de2bcadc4203148167f9f048"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"f3adbd25253fab89ad009b525f0e79fadc0d2d74","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":118,"context_line":"Enable storing issued token data to token validation cache so that first token"},{"line_number":119,"context_line":"validation doesn\u0027t actually cause full validation cycle. This option has no"},{"line_number":120,"context_line":"effect unless global caching is enabled and will still cache tokens even if"},{"line_number":121,"context_line":"`[token] caching \u003d False`."},{"line_number":122,"context_line":"\"\"\"))"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_bd18621e","line":120,"range":{"start_line":120,"start_character":29,"end_line":120,"end_character":40},"updated":"2019-02-19 06:57:38.000000000","message":"IMO it should be \u0027disabled\u0027 as by default caching is always enabled.","commit_id":"ebad027f21e9fc7f3420a700f22cb2ef422d6645"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"50434c5d04070d1a3ea4c52558f11e28ce5b1e5e","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":118,"context_line":"Enable storing issued token data to token validation cache so that first token"},{"line_number":119,"context_line":"validation doesn\u0027t actually cause full validation cycle. This option has no"},{"line_number":120,"context_line":"effect unless global caching is enabled and will still cache tokens even if"},{"line_number":121,"context_line":"`[token] caching \u003d False`."},{"line_number":122,"context_line":"\"\"\"))"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_317eccaf","line":120,"range":{"start_line":120,"start_character":29,"end_line":120,"end_character":40},"in_reply_to":"9fdfeff1_bd18621e","updated":"2019-02-19 20:57:58.000000000","message":"I think what I\u0027m trying to clarify is that people can toggle cache_on_issue all they want and if ``keystone.conf [cache] enabled\u003dFalse`` it won\u0027t make a difference. Ultimately, operators will need to ensure they have both options enabled in order for the feature to be turned on (even if they are just using the defaults).\n\nAlso, we use this same phrasing for caching options across keystone, so if we\u0027re going to change it in one place we should probably do it in others, too.\n\nhttps://git.openstack.org/cgit/openstack/keystone/tree/keystone/conf/catalog.py#n42\n\nDid I misunderstand your concern?","commit_id":"ebad027f21e9fc7f3420a700f22cb2ef422d6645"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"888a3661910829f0030a088ff1b4b457d7a75e19","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":118,"context_line":"Enable storing issued token data to token validation cache so that first token"},{"line_number":119,"context_line":"validation doesn\u0027t actually cause full validation cycle. This option has no"},{"line_number":120,"context_line":"effect unless global caching is enabled and will still cache tokens even if"},{"line_number":121,"context_line":"`[token] caching \u003d False`."},{"line_number":122,"context_line":"\"\"\"))"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"allow_expired_window \u003d cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_b02cd601","line":121,"range":{"start_line":120,"start_character":29,"end_line":121,"end_character":26},"updated":"2019-02-21 07:51:58.000000000","message":"I think my question arises as the wording of this help section sounded ambiguous to me.\nAgree with your explanation but I\u0027ve one query from it,\nfrom your explanation : both global caching and [token] caching options need to be enabled\nfrom the help section : global cache is controlling the behavior and [token] caching value has no impact\n\nSince there isn\u0027t a good reason to disable [token] caching but if we disable it, will it have any impact on the functionality of caching ?","commit_id":"ebad027f21e9fc7f3420a700f22cb2ef422d6645"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"42d432aa142f024fae1b09b463376931b55905ca","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":118,"context_line":"Enable storing issued token data to token validation cache so that first token"},{"line_number":119,"context_line":"validation doesn\u0027t actually cause full validation cycle. This option has no"},{"line_number":120,"context_line":"effect unless global caching is enabled and will still cache tokens even if"},{"line_number":121,"context_line":"`[token] caching \u003d False`."},{"line_number":122,"context_line":"\"\"\"))"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"allow_expired_window \u003d cfg.IntOpt("}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_96fd0a0a","line":121,"range":{"start_line":120,"start_character":29,"end_line":121,"end_character":26},"in_reply_to":"9fdfeff1_b02cd601","updated":"2019-02-21 09:13:40.000000000","message":"Not just global cache is controlling the behavior, but also either [token] caching or [token] cache_on_issue should be turned on to enable the feature, there are two options for the token here.","commit_id":"ebad027f21e9fc7f3420a700f22cb2ef422d6645"}]}