)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3da916b4da2c667e38cbc8e5c5bcea0875c9aef5","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Co-Authored-By: Lance Bragstad \u003clbragstad@gmail.com\u003e"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Depends-on: https://review.openstack.org/#/c/641959/"},{"line_number":30,"context_line":"Partial-Bug: 1750673"},{"line_number":31,"context_line":"Change-Id: I0c6d202a315d4683e2589f0d9121e93c97fb13e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"5fc1f717_c45f7770","line":29,"updated":"2019-03-20 16:35:52.000000000","message":"I don\u0027t think we need this anymore without admin_domain_scope \u003d True, which was patched in devstack.","commit_id":"c282142f276f92b52e43637c4e45c2481d892fc9"}],"keystone/api/role_assignments.py":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"bf5e049013ae00622cfa7bdec6a484befc4195f3","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    if project.get(\u0027domain_id\u0027) \u003d\u003d self.oslo_context.domain_id:"},{"line_number":72,"context_line":"                        domain_assignments.append(assignment)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"                assignments[\u0027role_assignments\u0027] \u003d domain_assignments"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        return assignments"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5fc1f717_02f0f3c8","line":74,"range":{"start_line":74,"start_character":16,"end_line":74,"end_character":68},"updated":"2019-03-21 18:43:26.000000000","message":"Is this supposed to be in the for loop here?","commit_id":"1d0e04d01d34390ed611119078fc8618054e842d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"debcefdf05a4e3b14dac6a167a6e41c806b990b0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    if project.get(\u0027domain_id\u0027) \u003d\u003d self.oslo_context.domain_id:"},{"line_number":72,"context_line":"                        domain_assignments.append(assignment)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"                assignments[\u0027role_assignments\u0027] \u003d domain_assignments"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        return assignments"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5fc1f717_22c08f2a","line":74,"range":{"start_line":74,"start_character":16,"end_line":74,"end_character":68},"in_reply_to":"5fc1f717_02f0f3c8","updated":"2019-03-21 18:49:06.000000000","message":"I don\u0027t think so, but it doesn\u0027t fail because it\u0027s just unnecessarily reassigning something?","commit_id":"1d0e04d01d34390ed611119078fc8618054e842d"}],"keystone/tests/unit/protection/v3/test_assignment.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"03e49a0fbde365238e79ec6cac8b005cf63e6df0","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            self.assertEqual(len(expected), len(r.json[\u0027role_assignments\u0027]))"},{"line_number":281,"context_line":"            actual \u003d self._extract_role_assignments_from_response_body(r)"},{"line_number":282,"context_line":"            for assignment in actual:"},{"line_number":283,"context_line":"                self.assertIn(assignment, expected)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def test_user_can_filter_role_assignments_by_system(self):"},{"line_number":286,"context_line":"        assignments \u003d self._setup_test_role_assignments()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_7d3b3e9b","side":"PARENT","line":283,"updated":"2019-02-28 14:52:41.000000000","message":"I think we still want to keep this test here so that we ensure system users can actually filter by assignments by domain.","commit_id":"980fe3c55b803accb32d1d944985f1b8c2a01ec0"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"b8d9ebd2b527c9780ca3c4afe19ee7d95ff35208","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            self.assertEqual(len(expected), len(r.json[\u0027role_assignments\u0027]))"},{"line_number":281,"context_line":"            actual \u003d self._extract_role_assignments_from_response_body(r)"},{"line_number":282,"context_line":"            for assignment in actual:"},{"line_number":283,"context_line":"                self.assertIn(assignment, expected)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def test_user_can_filter_role_assignments_by_system(self):"},{"line_number":286,"context_line":"        assignments \u003d self._setup_test_role_assignments()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_e13189ee","side":"PARENT","line":283,"in_reply_to":"9fdfeff1_7d3b3e9b","updated":"2019-03-01 05:44:26.000000000","message":"Thanks lance for the patch set update.","commit_id":"980fe3c55b803accb32d1d944985f1b8c2a01ec0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"03e49a0fbde365238e79ec6cac8b005cf63e6df0","unresolved":false,"context_lines":[{"line_number":474,"context_line":"            self.assertEqual(len(expected), len(r.json[\u0027role_assignments\u0027]))"},{"line_number":475,"context_line":"            actual \u003d self._extract_role_assignments_from_response_body(r)"},{"line_number":476,"context_line":"            for assignment in actual:"},{"line_number":477,"context_line":"                self.assertIn(assignment, expected)"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    def test_user_can_filter_role_assignments_by_system_and_role(self):"},{"line_number":480,"context_line":"        assignments \u003d self._setup_test_role_assignments()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_fd464e21","side":"PARENT","line":477,"updated":"2019-02-28 14:52:41.000000000","message":"Same comment here as above.","commit_id":"980fe3c55b803accb32d1d944985f1b8c2a01ec0"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"03e49a0fbde365238e79ec6cac8b005cf63e6df0","unresolved":false,"context_lines":[{"line_number":667,"context_line":"                        common_auth.AuthTestMixin,"},{"line_number":668,"context_line":"                        _AssignmentTestUtilities,"},{"line_number":669,"context_line":"                        _SystemUserTests,"},{"line_number":670,"context_line":"                        _DomainUserTests):"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def setUp(self):"},{"line_number":673,"context_line":"        super(SystemReaderTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_5d5f5ae4","line":670,"range":{"start_line":670,"start_character":24,"end_line":670,"end_character":40},"updated":"2019-02-28 14:52:41.000000000","message":"Instead - we\u0027ll want to create a new test class called DomainReaderTests and have that inherit from _DomainUserTests, right?\n\nWe\u0027ve already done a pretty good job writing tests for system users that describes the behavior they have. Now the trick will be rewriting/reusing tests to define what that behavior should be for domain users.","commit_id":"87b47bcb53328c4eb9fb152813e9bc2963f7771e"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"dec3ad54955031a2ea4cc5f2cb34a1ed3da85612","unresolved":false,"context_lines":[{"line_number":667,"context_line":"                        common_auth.AuthTestMixin,"},{"line_number":668,"context_line":"                        _AssignmentTestUtilities,"},{"line_number":669,"context_line":"                        _SystemUserTests,"},{"line_number":670,"context_line":"                        _DomainUserTests):"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def setUp(self):"},{"line_number":673,"context_line":"        super(SystemReaderTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_66428f6a","line":670,"range":{"start_line":670,"start_character":24,"end_line":670,"end_character":40},"in_reply_to":"9fdfeff1_5d5f5ae4","updated":"2019-03-01 05:29:38.000000000","message":"OK. I got your point. Actually What my motive was to put the common domain Test cases (For system as well as domain reader) into one class. So that I can inherit that in both system as well as domain reader classes to avoid code duplicate. I will update according to your comments.","commit_id":"87b47bcb53328c4eb9fb152813e9bc2963f7771e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f12409fb1771ac7f1dc59f2c0832f9d123302d0c","unresolved":false,"context_lines":[{"line_number":667,"context_line":"                        common_auth.AuthTestMixin,"},{"line_number":668,"context_line":"                        _AssignmentTestUtilities,"},{"line_number":669,"context_line":"                        _SystemUserTests,"},{"line_number":670,"context_line":"                        _DomainUserTests):"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def setUp(self):"},{"line_number":673,"context_line":"        super(SystemReaderTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_31d91555","line":670,"range":{"start_line":670,"start_character":24,"end_line":670,"end_character":40},"in_reply_to":"9fdfeff1_66428f6a","updated":"2019-03-01 15:00:55.000000000","message":"Got it. I suppose we could create a follow-on patch to try and share common test cases between domain users and system users?\n\nRight now, I updated it to be separate test classes, but I\u0027m open to refactoring it (either now or later, it\u0027s up to you).\n\nThanks for describing your thought process :)","commit_id":"87b47bcb53328c4eb9fb152813e9bc2963f7771e"}]}