)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"3beec9110d613242ce09da3a2094247b7a56758c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"role assignments should behave with the role assignment API."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch needs some discussion to determine how useful exposing this"},{"line_number":13,"context_line":"API is to project users, including readers, members, and admins."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Co-Authored-By: Vishakha Agarwal \u003cagarwalvishakha18@gmail.com\u003e"},{"line_number":16,"context_line":"Closes-Bug: 1750673"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"5fc1f717_e7b1e245","line":13,"updated":"2019-03-25 18:00:04.000000000","message":"This should probably be deleted since we\u0027ve resolved this discussion I think","commit_id":"b52fc766eac50c6277ead42132d367ec48d2799e"}],"keystone/common/policies/role_assignment.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ec6f623f8835437bf49fe8d1a1a64b5d25be0e77","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        # make keystone smart enough to handle those cases in code, we can add"},{"line_number":46,"context_line":"        # \u0027project\u0027 to the scope_types below. For now, this should be a system"},{"line_number":47,"context_line":"        # administrator only operation to maintain backwards compatibility."},{"line_number":48,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027domain\u0027, \u0027project\u0027],"},{"line_number":49,"context_line":"        description\u003d\u0027List role assignments.\u0027,"},{"line_number":50,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v3/role_assignments\u0027,"},{"line_number":51,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_ab25f7c3","line":48,"range":{"start_line":48,"start_character":41,"end_line":48,"end_character":50},"updated":"2019-03-25 10:05:34.000000000","message":"I\u0027m not sure why even bother having a project scope type if all operations are forbidden to project users","commit_id":"ca3234380493861354c8cb2fb9a80148aff3a03a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"34bafedf0932e80d4a5e4353be6588311947d06b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        # make keystone smart enough to handle those cases in code, we can add"},{"line_number":46,"context_line":"        # \u0027project\u0027 to the scope_types below. For now, this should be a system"},{"line_number":47,"context_line":"        # administrator only operation to maintain backwards compatibility."},{"line_number":48,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027domain\u0027, \u0027project\u0027],"},{"line_number":49,"context_line":"        description\u003d\u0027List role assignments.\u0027,"},{"line_number":50,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v3/role_assignments\u0027,"},{"line_number":51,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_c06a9a18","line":48,"range":{"start_line":48,"start_character":41,"end_line":48,"end_character":50},"in_reply_to":"5fc1f717_ab25f7c3","updated":"2019-03-25 13:41:25.000000000","message":"Nice catch, I forgot to clean this up.","commit_id":"ca3234380493861354c8cb2fb9a80148aff3a03a"}],"keystone/tests/unit/protection/v3/test_assignment.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a9dcf781c2902f9c3c491eb5e81e9d21bd951eb9","unresolved":false,"context_lines":[{"line_number":935,"context_line":"        pass"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"    def test_user_cannot_filter_role_assignments_by_other_project_group(self):"},{"line_number":938,"context_line":"        pass"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":""},{"line_number":941,"context_line":"class SystemReaderTests(base_classes.TestCaseWithBootstrap,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_1738bc9d","line":938,"updated":"2019-02-27 16:04:12.000000000","message":"I can see these tests being useful for project administrators, but I\u0027m on the fence about users with the `member` or `reader` roles. Thoughts?","commit_id":"ae7959db602e0830a08af8f06b184bb73eb1fb0e"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"0eb13e58c1dedfb749486ad1173b58720f986a04","unresolved":false,"context_lines":[{"line_number":935,"context_line":"        pass"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"    def test_user_cannot_filter_role_assignments_by_other_project_group(self):"},{"line_number":938,"context_line":"        pass"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":""},{"line_number":941,"context_line":"class SystemReaderTests(base_classes.TestCaseWithBootstrap,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_8c9331a3","line":938,"in_reply_to":"9fdfeff1_1738bc9d","updated":"2019-02-28 06:57:07.000000000","message":"I think these cases are fit for project readers, which implies for project admin as well as members. IMO The role assignment API is reader dominant API.","commit_id":"ae7959db602e0830a08af8f06b184bb73eb1fb0e"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"1cc0274b3c8606346c3d308d0448fa0db0ee978f","unresolved":false,"context_lines":[{"line_number":935,"context_line":"        pass"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"    def test_user_cannot_filter_role_assignments_by_other_project_group(self):"},{"line_number":938,"context_line":"        pass"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":""},{"line_number":941,"context_line":"class SystemReaderTests(base_classes.TestCaseWithBootstrap,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_01512d30","line":938,"in_reply_to":"9fdfeff1_8c9331a3","updated":"2019-03-01 07:09:41.000000000","message":"I also updated the patch with the project test cases just to\nlook for the possibility of which case should be restricted for project members and readers.","commit_id":"ae7959db602e0830a08af8f06b184bb73eb1fb0e"}]}