)]}'
{"keystone/api/groups.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"3e02c053d924ea63947163ef08373837205fca2c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            for ref in refs:"},{"line_number":162,"context_line":"                if ref[\u0027domain_id\u0027] \u003d\u003d self.oslo_context.domain_id:"},{"line_number":163,"context_line":"                    filtered_refs.append(ref)"},{"line_number":164,"context_line":"            refs \u003d filtered_refs"},{"line_number":165,"context_line":"        return ks_flask.ResourceBase.wrap_collection("},{"line_number":166,"context_line":"            refs, hints\u003dhints, collection_name\u003d\u0027users\u0027)"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_20fe8738","line":164,"updated":"2019-03-30 09:13:17.000000000","message":"Can we pass the filter action to db layer? Just something like:\n\nif self.oslo_context.domain_id:\n    hints.add_filter(\"domain_id\", self.oslo_context.domain_id)","commit_id":"be452fee80fabe252b2dae3be76c1d46fdd857e4"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"37d8f06a113de571e58aeacd4ef659224fdda6e4","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            for ref in refs:"},{"line_number":162,"context_line":"                if ref[\u0027domain_id\u0027] \u003d\u003d self.oslo_context.domain_id:"},{"line_number":163,"context_line":"                    filtered_refs.append(ref)"},{"line_number":164,"context_line":"            refs \u003d filtered_refs"},{"line_number":165,"context_line":"        return ks_flask.ResourceBase.wrap_collection("},{"line_number":166,"context_line":"            refs, hints\u003dhints, collection_name\u003d\u0027users\u0027)"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_aad48d48","line":164,"in_reply_to":"5fc1f717_20fe8738","updated":"2019-04-01 03:38:29.000000000","message":"Good idea, but this is consistent with how we\u0027re already doing it elsewhere. Can we fix it in a followup?","commit_id":"be452fee80fabe252b2dae3be76c1d46fdd857e4"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"c32d1a85a8c39855f3cc23b98adc7a581d8a1bcf","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            for ref in refs:"},{"line_number":162,"context_line":"                if ref[\u0027domain_id\u0027] \u003d\u003d self.oslo_context.domain_id:"},{"line_number":163,"context_line":"                    filtered_refs.append(ref)"},{"line_number":164,"context_line":"            refs \u003d filtered_refs"},{"line_number":165,"context_line":"        return ks_flask.ResourceBase.wrap_collection("},{"line_number":166,"context_line":"            refs, hints\u003dhints, collection_name\u003d\u0027users\u0027)"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_2ac09d7c","line":164,"in_reply_to":"5fc1f717_aad48d48","updated":"2019-04-01 03:42:13.000000000","message":"ok. Then I\u0027m fine with this patch.","commit_id":"be452fee80fabe252b2dae3be76c1d46fdd857e4"}],"keystone/common/policies/group.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"47cb118e60a4a36ce9c515aa675ecee89a458b07","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \u0027user_id:%(user_id)s\u0027"},{"line_number":22,"context_line":")"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"SYSTEM_READER_OR_DOMAIN_READER_FOR_TARGET_GROUP \u003d ("},{"line_number":25,"context_line":"    \u0027(role:reader and system_scope:all) or \u0027"},{"line_number":26,"context_line":"    \u0027(role:reader and domain_id:%(target.group.domain_id)s)\u0027"},{"line_number":27,"context_line":")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"SYSTEM_READER_OR_DOMAIN_READER_FOR_TARGET_GROUP_USER \u003d ("},{"line_number":30,"context_line":"    \u0027(role:reader and system_scope:all) or \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_e489ca74","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":1},"updated":"2019-03-26 15:12:59.000000000","message":"Is this needed if we have SYSTEM_READER_OR_DOMAIN_READER?","commit_id":"93637c97ea01ef984b5c4b43ebddb2b5f4f7ec58"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ecbe7dfb46cbb8f2f491194e52e34f5fb30112bf","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \u0027user_id:%(user_id)s\u0027"},{"line_number":22,"context_line":")"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"SYSTEM_READER_OR_DOMAIN_READER_FOR_TARGET_GROUP \u003d ("},{"line_number":25,"context_line":"    \u0027(role:reader and system_scope:all) or \u0027"},{"line_number":26,"context_line":"    \u0027(role:reader and domain_id:%(target.group.domain_id)s)\u0027"},{"line_number":27,"context_line":")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"SYSTEM_READER_OR_DOMAIN_READER_FOR_TARGET_GROUP_USER \u003d ("},{"line_number":30,"context_line":"    \u0027(role:reader and system_scope:all) or \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_2453523b","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":1},"in_reply_to":"5fc1f717_e489ca74","updated":"2019-03-26 15:33:12.000000000","message":"I think this is leftover from earlier when I was trying to figure this out","commit_id":"93637c97ea01ef984b5c4b43ebddb2b5f4f7ec58"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"47cb118e60a4a36ce9c515aa675ecee89a458b07","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        deprecated_since\u003dversionutils.deprecated.STEIN),"},{"line_number":168,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":169,"context_line":"        name\u003dbase.IDENTITY % \u0027list_users_in_group\u0027,"},{"line_number":170,"context_line":"        check_str\u003dSYSTEM_READER_OR_DOMAIN_READER_FOR_TARGET_GROUP,"},{"line_number":171,"context_line":"        scope_types\u003d[\u0027system\u0027, \u0027domain\u0027],"},{"line_number":172,"context_line":"        description\u003d\u0027List members of a specific group.\u0027,"},{"line_number":173,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v3/groups/{group_id}/users\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_44dd3e6e","line":170,"range":{"start_line":170,"start_character":18,"end_line":170,"end_character":65},"updated":"2019-03-26 15:12:59.000000000","message":"I think this can be SYSTEM_READER_OR_DOMAIN_READER, can\u0027t it?","commit_id":"93637c97ea01ef984b5c4b43ebddb2b5f4f7ec58"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"dad6a0071992264072f9c6ef61aeb241a35b6044","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \u0027domain_id:%(target.user.domain_id)s)\u0027"},{"line_number":41,"context_line":")"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"SYSTEM_READER_OR_DOMAIN_READER \u003d ("},{"line_number":44,"context_line":"    \u0027(role:reader and system_scope:all) or \u0027"},{"line_number":45,"context_line":"    \u0027(role:reader and domain_id:%(target.group.domain_id)s)\u0027"},{"line_number":46,"context_line":")"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_def56ccc","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":30},"updated":"2019-03-27 06:22:39.000000000","message":"This string is same as L24 \"SYSTEM_READER_OR_DOMAIN_READER_FOR_TARGET_GROUP\". Maybe we can use either of the two?","commit_id":"e1956fd4045001ea2643b7dd85ca781dce4e97fc"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"bdc567e45b030b2b766176f676de9f6998f1ec44","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \u0027domain_id:%(target.user.domain_id)s)\u0027"},{"line_number":41,"context_line":")"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"SYSTEM_READER_OR_DOMAIN_READER \u003d ("},{"line_number":44,"context_line":"    \u0027(role:reader and system_scope:all) or \u0027"},{"line_number":45,"context_line":"    \u0027(role:reader and domain_id:%(target.group.domain_id)s)\u0027"},{"line_number":46,"context_line":")"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_edabd8d2","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":30},"in_reply_to":"5fc1f717_def56ccc","updated":"2019-03-27 10:25:14.000000000","message":"Oops, yes I accidentally reverted that fix.","commit_id":"e1956fd4045001ea2643b7dd85ca781dce4e97fc"}]}