)]}'
{"keystone/server/flask/application.py":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"c873577cfec9196d1d8e6603b057e0a84f3b0206","unresolved":false,"context_lines":[{"line_number":24,"context_line":"try:"},{"line_number":25,"context_line":"    # werkzeug 0.15.x"},{"line_number":26,"context_line":"    from werkzeug.middleware import dispatcher as wsgi_dispatcher"},{"line_number":27,"context_line":"except ModuleNotFoundError:"},{"line_number":28,"context_line":"    # werkzeug 0.14.x"},{"line_number":29,"context_line":"    import werkzeug.wsgi as wsgi_dispatcher"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_c9404b09","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":27},"updated":"2019-04-10 06:36:07.000000000","message":"Same here","commit_id":"ea9a98c92ab26e1f2dde223bc5486c609216dc56"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"9af524182e41128b20254a8aea034926ab7d2f36","unresolved":false,"context_lines":[{"line_number":24,"context_line":"try:"},{"line_number":25,"context_line":"    # werkzeug 0.15.x"},{"line_number":26,"context_line":"    from werkzeug.middleware import dispatcher as wsgi_dispatcher"},{"line_number":27,"context_line":"except ModuleNotFoundError:"},{"line_number":28,"context_line":"    # werkzeug 0.14.x"},{"line_number":29,"context_line":"    import werkzeug.wsgi as wsgi_dispatcher"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_3147ed4e","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":27},"in_reply_to":"5fc1f717_c9404b09","updated":"2019-04-10 17:07:24.000000000","message":"Done","commit_id":"ea9a98c92ab26e1f2dde223bc5486c609216dc56"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"20c260f06a0126da2bd1d8cd3c021089192b8a81","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"try:"},{"line_number":25,"context_line":"    # werkzeug 0.15.x"},{"line_number":26,"context_line":"    from werkzeug.middleware import dispatcher as wsgi_dispatcher"},{"line_number":27,"context_line":"except ImportError:"},{"line_number":28,"context_line":"    # werkzeug 0.14.x"},{"line_number":29,"context_line":"    import werkzeug.wsgi as wsgi_dispatcher"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_df098edd","line":26,"updated":"2019-04-22 16:19:02.000000000","message":"Can\u0027t we just update the minimum werkzeug directly in our requirements files? Flask works with either and we\u0027re directly importing.","commit_id":"de07ad37fc1b4d99176d5e706c0179c7cf939958"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"1f4dda49e13cb2ea2284b54f4cc05a48b1617c25","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"try:"},{"line_number":25,"context_line":"    # werkzeug 0.15.x"},{"line_number":26,"context_line":"    from werkzeug.middleware import dispatcher as wsgi_dispatcher"},{"line_number":27,"context_line":"except ImportError:"},{"line_number":28,"context_line":"    # werkzeug 0.14.x"},{"line_number":29,"context_line":"    import werkzeug.wsgi as wsgi_dispatcher"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_df8e6e2d","line":26,"in_reply_to":"ffb9cba7_df098edd","updated":"2019-04-22 16:21:57.000000000","message":"There\u0027s a chicken-and-egg issue, we can\u0027t lift the cap in u-c because it breaks keystone, we can\u0027t raise the minimum in keystone because it would conflict with the cap in u-c. Besides, this is more flexible for packagers.","commit_id":"de07ad37fc1b4d99176d5e706c0179c7cf939958"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"bbbb6ab7f41af57660fe166b14fccfb248f356cc","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"try:"},{"line_number":25,"context_line":"    # werkzeug 0.15.x"},{"line_number":26,"context_line":"    from werkzeug.middleware import dispatcher as wsgi_dispatcher"},{"line_number":27,"context_line":"except ImportError:"},{"line_number":28,"context_line":"    # werkzeug 0.14.x"},{"line_number":29,"context_line":"    import werkzeug.wsgi as wsgi_dispatcher"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_22c20d35","line":26,"in_reply_to":"ffb9cba7_df8e6e2d","updated":"2019-04-22 16:52:38.000000000","message":"The \"besides it\u0027s more flexible for packagers\" isn\u0027t really a worth-while argument this early in the cycle. The rest is fine as long as we move to bumping the minimum before the end of Train.","commit_id":"de07ad37fc1b4d99176d5e706c0179c7cf939958"}],"keystone/server/flask/core.py":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"c873577cfec9196d1d8e6603b057e0a84f3b0206","unresolved":false,"context_lines":[{"line_number":19,"context_line":"try:"},{"line_number":20,"context_line":"    # werkzeug 0.15.x"},{"line_number":21,"context_line":"    from werkzeug.middleware import proxy_fix"},{"line_number":22,"context_line":"except ModuleNotFoundError:"},{"line_number":23,"context_line":"    # werkzeug 0.14.x"},{"line_number":24,"context_line":"    from werkzeug.contrib import fixers as proxy_fix"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_a93dbf8e","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":27},"updated":"2019-04-10 06:36:07.000000000","message":"Can use importerror instead of ModuleNotFoundError. Same as [1] \n\n[1] https://github.com/openstack/keystone/blob/106b28ad4c30948c293dc9200adb908893b24a35/keystone/common/utils.py#L151","commit_id":"ea9a98c92ab26e1f2dde223bc5486c609216dc56"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"9af524182e41128b20254a8aea034926ab7d2f36","unresolved":false,"context_lines":[{"line_number":19,"context_line":"try:"},{"line_number":20,"context_line":"    # werkzeug 0.15.x"},{"line_number":21,"context_line":"    from werkzeug.middleware import proxy_fix"},{"line_number":22,"context_line":"except ModuleNotFoundError:"},{"line_number":23,"context_line":"    # werkzeug 0.14.x"},{"line_number":24,"context_line":"    from werkzeug.contrib import fixers as proxy_fix"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_5142b93c","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":27},"in_reply_to":"5fc1f717_a93dbf8e","updated":"2019-04-10 17:07:24.000000000","message":"Fixed, thanks","commit_id":"ea9a98c92ab26e1f2dde223bc5486c609216dc56"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"0e2e92d9fb47006c5f2529e079e54d87fe5ea1f2","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        factory_func \u003d loaded.driver.factory({}, **mw.conf)"},{"line_number":127,"context_line":"        app.wsgi_app \u003d factory_func(app.wsgi_app)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    # Apply werkzeug speficic middleware"},{"line_number":130,"context_line":"    app.wsgi_app \u003d fixers.ProxyFix(app.wsgi_app)"},{"line_number":131,"context_line":"    return app"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_d8b37097","side":"PARENT","line":129,"range":{"start_line":129,"start_character":21,"end_line":129,"end_character":29},"updated":"2019-04-18 20:34:49.000000000","message":"nice","commit_id":"0a66ef5328b26e166e9c4821aef4373ca4594d44"}]}