)]}'
{"keystone/token/token_formatters.py":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"a39532d87cd31be1e6af293654d0a4c4da9ad2ee","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        (is_stored_as_bytes, user_id) \u003d payload[0]"},{"line_number":559,"context_line":"        if is_stored_as_bytes:"},{"line_number":560,"context_line":"            user_id \u003d cls.convert_uuid_bytes_to_hex(user_id)"},{"line_number":561,"context_line":"        else:"},{"line_number":562,"context_line":"            # NOTE(cmurphy): The user ID of shadowed federated users is no"},{"line_number":563,"context_line":"            # longer a UUID but a sha256 hash string, and so it should not be"},{"line_number":564,"context_line":"            # converted to a byte string since it is not a UUID format."},{"line_number":565,"context_line":"            # However. on python3 msgpack returns the serialized input as a"},{"line_number":566,"context_line":"            # byte string anyway. Similar to other msgpack\u0027d values in the"},{"line_number":567,"context_line":"            # payload, we need to explicitly decode it to a string value."},{"line_number":568,"context_line":"            if six.PY3 and isinstance(user_id, six.binary_type):"},{"line_number":569,"context_line":"                user_id \u003d user_id.decode(\u0027utf-8\u0027)"},{"line_number":570,"context_line":"        methods \u003d auth_plugins.convert_integer_to_method_list(payload[1])"},{"line_number":571,"context_line":"        group_ids \u003d list(map(cls.unpack_group_id, payload[2]))"},{"line_number":572,"context_line":"        (is_stored_as_bytes, idp_id) \u003d payload[3]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_13f05567","line":569,"range":{"start_line":561,"start_character":8,"end_line":569,"end_character":49},"updated":"2019-04-15 06:27:08.000000000","message":"Haven\u0027t had done the same changes in [1]\n\n[1] https://review.openstack.org/#/c/650615/3/keystone/token/token_formatters.py","commit_id":"e8c5abf28ffe532786767f95168684f92393f3e7"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"6f9b043b5eade794a335fb88c4f7946543d53881","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        (is_stored_as_bytes, user_id) \u003d payload[0]"},{"line_number":559,"context_line":"        if is_stored_as_bytes:"},{"line_number":560,"context_line":"            user_id \u003d cls.convert_uuid_bytes_to_hex(user_id)"},{"line_number":561,"context_line":"        else:"},{"line_number":562,"context_line":"            # NOTE(cmurphy): The user ID of shadowed federated users is no"},{"line_number":563,"context_line":"            # longer a UUID but a sha256 hash string, and so it should not be"},{"line_number":564,"context_line":"            # converted to a byte string since it is not a UUID format."},{"line_number":565,"context_line":"            # However. on python3 msgpack returns the serialized input as a"},{"line_number":566,"context_line":"            # byte string anyway. Similar to other msgpack\u0027d values in the"},{"line_number":567,"context_line":"            # payload, we need to explicitly decode it to a string value."},{"line_number":568,"context_line":"            if six.PY3 and isinstance(user_id, six.binary_type):"},{"line_number":569,"context_line":"                user_id \u003d user_id.decode(\u0027utf-8\u0027)"},{"line_number":570,"context_line":"        methods \u003d auth_plugins.convert_integer_to_method_list(payload[1])"},{"line_number":571,"context_line":"        group_ids \u003d list(map(cls.unpack_group_id, payload[2]))"},{"line_number":572,"context_line":"        (is_stored_as_bytes, idp_id) \u003d payload[3]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_59ccb7bb","line":569,"range":{"start_line":561,"start_character":8,"end_line":569,"end_character":49},"in_reply_to":"3fce034c_13f05567","updated":"2019-04-15 14:22:33.000000000","message":"Those changes were for FederatedScopedPayload, this is for FederatedUnscopedPayload. Although that class inherits from this class, the disassemble class methods are completely independent so we have to repeat the case here.","commit_id":"e8c5abf28ffe532786767f95168684f92393f3e7"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"77108594844d1d093a73ff47826cdb3b792398c5","unresolved":false,"context_lines":[{"line_number":558,"context_line":"        (is_stored_as_bytes, user_id) \u003d payload[0]"},{"line_number":559,"context_line":"        if is_stored_as_bytes:"},{"line_number":560,"context_line":"            user_id \u003d cls.convert_uuid_bytes_to_hex(user_id)"},{"line_number":561,"context_line":"        else:"},{"line_number":562,"context_line":"            # NOTE(cmurphy): The user ID of shadowed federated users is no"},{"line_number":563,"context_line":"            # longer a UUID but a sha256 hash string, and so it should not be"},{"line_number":564,"context_line":"            # converted to a byte string since it is not a UUID format."},{"line_number":565,"context_line":"            # However. on python3 msgpack returns the serialized input as a"},{"line_number":566,"context_line":"            # byte string anyway. Similar to other msgpack\u0027d values in the"},{"line_number":567,"context_line":"            # payload, we need to explicitly decode it to a string value."},{"line_number":568,"context_line":"            if six.PY3 and isinstance(user_id, six.binary_type):"},{"line_number":569,"context_line":"                user_id \u003d user_id.decode(\u0027utf-8\u0027)"},{"line_number":570,"context_line":"        methods \u003d auth_plugins.convert_integer_to_method_list(payload[1])"},{"line_number":571,"context_line":"        group_ids \u003d list(map(cls.unpack_group_id, payload[2]))"},{"line_number":572,"context_line":"        (is_stored_as_bytes, idp_id) \u003d payload[3]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_2ba2a34c","line":569,"range":{"start_line":561,"start_character":8,"end_line":569,"end_character":49},"in_reply_to":"3fce034c_59ccb7bb","updated":"2019-04-16 07:38:45.000000000","message":"Sorry I did not noticed the class. Thanks for the update.","commit_id":"e8c5abf28ffe532786767f95168684f92393f3e7"}]}
