)]}'
{"keystone/identity/core.py":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"034fa755dca1f9f2261c86bbcc24d941bf9a6faf","unresolved":false,"context_lines":[{"line_number":953,"context_line":""},{"line_number":954,"context_line":"    def _exempt_from_password_check(self, user_dict):"},{"line_number":955,"context_line":"        return bool(user_dict.get("},{"line_number":956,"context_line":"            iro.IGNORE_USER_INACTIVITY_OPT.option_name, False))"},{"line_number":957,"context_line":""},{"line_number":958,"context_line":"    @domains_configured"},{"line_number":959,"context_line":"    @exception_translated(\u0027user\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_4c6c1908","line":956,"range":{"start_line":956,"start_character":12,"end_line":956,"end_character":55},"updated":"2019-05-03 21:33:58.000000000","message":"Don\u0027t you mean IGNORE_PASSWORD_REGEX_OPT","commit_id":"32d1510d66533a2b682139643258cb9bb405838a"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"034fa755dca1f9f2261c86bbcc24d941bf9a6faf","unresolved":false,"context_lines":[{"line_number":1385,"context_line":"            self._get_domain_driver_and_entity_id(user_id))"},{"line_number":1386,"context_line":"        user \u003d driver.get_user(entity_id)"},{"line_number":1387,"context_line":"        try:"},{"line_number":1388,"context_line":"            if not getattr(user.get_resource_option("},{"line_number":1389,"context_line":"                    iro.IGNORE_PASSWORD_REGEX_OPT.option_id),"},{"line_number":1390,"context_line":"                    \u0027option_value\u0027, False):"},{"line_number":1391,"context_line":"                validators.validate_password(new_password)"},{"line_number":1392,"context_line":"            driver.change_password(entity_id, new_password)"},{"line_number":1393,"context_line":"        except exception.PasswordValidationError as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_600fa12e","line":1390,"range":{"start_line":1388,"start_character":0,"end_line":1390,"end_character":43},"updated":"2019-05-03 21:33:58.000000000","message":"can you use: _exempt_from_password_check ?","commit_id":"32d1510d66533a2b682139643258cb9bb405838a"}],"keystone/tests/unit/identity/test_backend_sql.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"3f9991db5b6cd91e50acb47318b98dda7207175f","unresolved":false,"context_lines":[{"line_number":995,"context_line":"        super(IgnorePasswordRegexTests, self).setUp()"},{"line_number":996,"context_line":"        self.password \u003d \u0027mypassword2\u0027"},{"line_number":997,"context_line":"        self.user_dict \u003d self._get_user_dict(self.password)"},{"line_number":998,"context_line":"        # invalid regular expression, missing beginning \u0027[\u0027"},{"line_number":999,"context_line":"        self.config_fixture.config(group\u003d\u0027security_compliance\u0027,"},{"line_number":1000,"context_line":"                                   password_regex\u003d\u0027\\S]+\u0027)"},{"line_number":1001,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_f4b25593","line":998,"updated":"2020-08-26 17:50:43.000000000","message":"I\u0027m unclear why this says invalid? It\u0027s a valid regex:\n\n \u003e\u003e\u003e re.match(\u0027\\S]+\u0027, \u0027x]]]]\u0027)\n \u003cre.Match object; span\u003d(0, 5), match\u003d\u0027x]]]]\u0027\u003e\n\nIn any case, why use an invalid regex? Why not use a valid one and have the tests try to use a password that doesn\u0027t match it?","commit_id":"18dd03e8731b597f7806f2dbb0bba3c68c73687b"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"25d82f9b5a58bafcdb265009353b3ac770d7d81c","unresolved":false,"context_lines":[{"line_number":995,"context_line":"        super(IgnorePasswordRegexTests, self).setUp()"},{"line_number":996,"context_line":"        self.password \u003d \u0027mypassword2\u0027"},{"line_number":997,"context_line":"        self.user_dict \u003d self._get_user_dict(self.password)"},{"line_number":998,"context_line":"        # invalid regular expression, missing beginning \u0027[\u0027"},{"line_number":999,"context_line":"        self.config_fixture.config(group\u003d\u0027security_compliance\u0027,"},{"line_number":1000,"context_line":"                                   password_regex\u003d\u0027\\S]+\u0027)"},{"line_number":1001,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_300683cf","line":998,"in_reply_to":"9f560f44_f4b25593","updated":"2020-08-27 18:40:36.000000000","message":"Thanks for the suggestion. Makes sense to me, also updated the patch","commit_id":"18dd03e8731b597f7806f2dbb0bba3c68c73687b"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"862bca4f6862827c8f17c36ea5158bd5517c7753","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"        user_dict \u003d dict()"},{"line_number":1012,"context_line":"        # When \u0027ignore_password_regex\u0027 option not passed and is"},{"line_number":1013,"context_line":"        # False by default"},{"line_number":1014,"context_line":"        user_dict[\u0027password\u0027] \u003d \u0027my second password\u0027"},{"line_number":1015,"context_line":"        self.assertRaises(exception.PasswordValidationError,"},{"line_number":1016,"context_line":"                          PROVIDERS.identity_api.update_user,"},{"line_number":1017,"context_line":"                          user[\u0027id\u0027], user_dict)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_fc2321a6","line":1014,"updated":"2020-09-15 16:53:15.000000000","message":"ignore_password_regex is already set to True in _create_user(), I don\u0027t think it should need to be set again when updating the user. Missing options don\u0027t override options on an active resource.","commit_id":"ffa9788228abc9645682439d1a520a8286b7e5bc"}]}