)]}'
{"api-ref/source/v3-ext/parameters.yaml":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"78e6c94dc3e06cd9ce034588072035718598c000","unresolved":false,"context_lines":[{"line_number":95,"context_line":"# variables in query"},{"line_number":96,"context_line":"eg_name_query:"},{"line_number":97,"context_line":"  description: |"},{"line_number":98,"context_line":"    Filters the response by a endpoint group name."},{"line_number":99,"context_line":"  in: query"},{"line_number":100,"context_line":"  required: false"},{"line_number":101,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfbec78f_5b43e713","line":98,"range":{"start_line":98,"start_character":28,"end_line":98,"end_character":29},"updated":"2019-05-13 16:23:28.000000000","message":"(nit) an","commit_id":"1a487705103faba484611afda7bfbfb0974cc19e"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"f98e6e8636df632976619d230744270fe049c638","unresolved":false,"context_lines":[{"line_number":93,"context_line":"  type: string"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# variables in query"},{"line_number":96,"context_line":"eg_name_query:"},{"line_number":97,"context_line":"  description: |"},{"line_number":98,"context_line":"    Filters the response by an endpoint group name."},{"line_number":99,"context_line":"  in: query"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_aaf8f9c3","line":96,"updated":"2019-06-04 20:25:07.000000000","message":"not a huge fan of this \"name\" for the query. You are not passing an actual query, right? What you are going to pass is just a name.","commit_id":"ac15b83cbe9992274506db9f719e617680c90435"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"f6c842b08c0d264aaafa062a1c4fb4147c8a3a39","unresolved":false,"context_lines":[{"line_number":93,"context_line":"  type: string"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# variables in query"},{"line_number":96,"context_line":"eg_name_query:"},{"line_number":97,"context_line":"  description: |"},{"line_number":98,"context_line":"    Filters the response by an endpoint group name."},{"line_number":99,"context_line":"  in: query"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_5fc6f369","line":96,"in_reply_to":"9fb8cfa7_aaf8f9c3","updated":"2019-07-05 19:30:15.000000000","message":"The _query suffix is conventional because it is part of the URL query parameters, so it would have been better to keep that convention. Could be fixed in a followup.","commit_id":"ac15b83cbe9992274506db9f719e617680c90435"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"c869893fcd6f29a2e733e86664dc20b51d751289","unresolved":false,"context_lines":[{"line_number":93,"context_line":"  type: string"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# variables in query"},{"line_number":96,"context_line":"endpoint_group_name_query:"},{"line_number":97,"context_line":"  description: |"},{"line_number":98,"context_line":"    Filters the response by an endpoint group name."},{"line_number":99,"context_line":"  in: query"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_125e9475","line":96,"range":{"start_line":96,"start_character":0,"end_line":96,"end_character":25},"updated":"2019-07-17 06:55:56.000000000","message":"If we look the conventions discussed in etherpad [0],\nCan we add required/not required attribute also? It makes easier for contributor to understand and also do not require to chase down in another file.  \n\n{request|response}_{attribute}_{location}_{required|not required}\n\nFor example -\nrequest_default_limit_body_not_required\n\n[0]  https://etherpad.openstack.org/p/queens-ptg-keystone-doc-cleanup","commit_id":"98d20315e6d474804dd612823aaa36cf4b396572"}],"keystone/api/os_ep_filter.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"78e6c94dc3e06cd9ce034588072035718598c000","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            PROVIDERS.catalog_api.get_endpoint_group(endpoint_group_id))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def _list_endpoint_groups(self):"},{"line_number":69,"context_line":"        ENFORCER.enforce_call(action\u003d\u0027identity:list_endpoint_groups\u0027)"},{"line_number":70,"context_line":"        filters \u003d (\u0027name\u0027)"},{"line_number":71,"context_line":"        hints \u003d self.build_driver_hints(filters)"},{"line_number":72,"context_line":"        refs \u003d PROVIDERS.catalog_api.list_endpoint_groups(hints\u003dhints)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_fb22db51","line":69,"updated":"2019-05-13 16:23:28.000000000","message":"The filter should be passed to the enforcer, for example like here https://opendev.org/openstack/keystone/src/branch/master/keystone/api/services.py#L37-L38","commit_id":"1a487705103faba484611afda7bfbfb0974cc19e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"23e9bda5fd7e48cc3c541d9894a57b6a3243bc59","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        ENFORCER.enforce_call(action\u003d\u0027identity:list_endpoint_groups\u0027,"},{"line_number":71,"context_line":"                              filters\u003dfilters)"},{"line_number":72,"context_line":"        hints \u003d self.build_driver_hints(filters)"},{"line_number":73,"context_line":"        refs \u003d PROVIDERS.catalog_api.list_endpoint_groups(hints\u003dhints)"},{"line_number":74,"context_line":"        return self.wrap_collection(refs, hints\u003dhints)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def get(self, endpoint_group_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_93bfb65f","line":73,"range":{"start_line":73,"start_character":58,"end_line":73,"end_character":69},"updated":"2019-07-01 19:20:49.000000000","message":"Using a kwarg here isn\u0027t really necessary since the method signature of the callee doesn\u0027t define hints as a kwarg. We could just:\n\n  PROVIDERS.catalog_api.list_endpoint_groups(hints)\n\nOr we could adjust the method signature to actually make hints a real kwarg and provide a reasonable default of None (which is something we do elsewhere).\n\n  def list_endpoint_groups(self, hints\u003dNone):\n\nKeeping the call and the signature of the callee in sync helps readability regardless of which piece of code you\u0027re reading.","commit_id":"ac15b83cbe9992274506db9f719e617680c90435"}],"keystone/catalog/backends/base.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"18d54a002eae620ebb244ea57083758f6ff7d5fc","unresolved":false,"context_lines":[{"line_number":443,"context_line":"    @abc.abstractmethod"},{"line_number":444,"context_line":"    def list_endpoint_groups(self, hints):"},{"line_number":445,"context_line":"        \"\"\"List all endpoint groups."},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        :returns: None."},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_46473578","line":446,"updated":"2019-07-20 12:54:10.000000000","message":"might be good to add some desc on the parameter of \"hints\", like what L65 did.","commit_id":"6cdb3a8374599a95303dc9bf14dbe96c2d4c0f16"}],"keystone/tests/unit/test_associate_project_endpoint_extension.py":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"78e6c94dc3e06cd9ce034588072035718598c000","unresolved":false,"context_lines":[{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":"        self.assertEqual("},{"line_number":1007,"context_line":"            endpoint_group_id,"},{"line_number":1008,"context_line":"            response.result[\u0027endpoint_groups\u0027][0][\u0027id\u0027])"},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":"        self.head(url, expected_status\u003dhttp_client.OK)"},{"line_number":1011,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dfbec78f_fbe73b11","line":1008,"updated":"2019-05-13 16:23:28.000000000","message":"There is nothing that asserts that the list really is filtered, for example by using the length of the response or using a negative test to assert that filtered-out groups are not in the response.","commit_id":"1a487705103faba484611afda7bfbfb0974cc19e"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"18d54a002eae620ebb244ea57083758f6ff7d5fc","unresolved":false,"context_lines":[{"line_number":1063,"context_line":""},{"line_number":1064,"context_line":"        self.head(url, expected_status\u003dhttp_client.OK)"},{"line_number":1065,"context_line":""},{"line_number":1066,"context_line":"        # try to retrieve a non existant one"},{"line_number":1067,"context_line":"        url \u003d (\u0027/OS-EP-FILTER/endpoint_groups?name\u003d%(name)s\u0027 %"},{"line_number":1068,"context_line":"               {\u0027name\u0027: \u0027fake\u0027})"},{"line_number":1069,"context_line":"        r \u003d self.get(url, expected_status\u003dhttp_client.OK)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_e6618106","line":1066,"range":{"start_line":1066,"start_character":32,"end_line":1066,"end_character":40},"updated":"2019-07-20 12:54:10.000000000","message":"existent","commit_id":"6cdb3a8374599a95303dc9bf14dbe96c2d4c0f16"}],"releasenotes/notes/list-endpoint-groups-by-name-0790c4c60ba34100.yaml":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"78e6c94dc3e06cd9ce034588072035718598c000","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes endpoint group listing by name. This allows the openstackclient"},{"line_number":5,"context_line":"    command to search endpoint groups by name."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfbec78f_bbed43f1","line":3,"updated":"2019-05-13 16:23:28.000000000","message":"Include a link to the bug report","commit_id":"1a487705103faba484611afda7bfbfb0974cc19e"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"23e9bda5fd7e48cc3c541d9894a57b6a3243bc59","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1828565 \u003chttps://bugs.launchpad.net/keystone/+bug/1828565\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_73d1e2cb","line":1,"updated":"2019-07-01 19:20:49.000000000","message":"We usually try and incorporate the bug number into the name of the release note to avoid collisions and stick with a convention. The process is available here if you\u0027re curious: https://docs.openstack.org/keystone/latest/contributor/release-notes.html#release-notes-for-bugs","commit_id":"ac15b83cbe9992274506db9f719e617680c90435"}]}