)]}'
{"id":"openstack%2Fkeystone~659901","triplet_id":"openstack%2Fkeystone~master~Ibbbb8e42166e62f80975c0219eaee483a6df2d4f","project":"openstack/keystone","branch":"master","hashtags":[],"change_id":"Ibbbb8e42166e62f80975c0219eaee483a6df2d4f","subject":"Fix XSS issues","status":"ABANDONED","created":"2019-05-18 08:53:37.000000000","updated":"2021-06-04 18:16:52.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"91a919ff564df6da1d7d924a78341e2e65204933","_number":659901,"virtual_id_number":659901,"owner":{"_account_id":24115,"name":"Xianghui Zeng","email":"zengxh1981@126.com","username":"XianghuiZeng"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":-1,"date":"2019-05-18 10:42:46.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"all":[{"value":-1,"date":"2019-05-24 16:53:44.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"value":-1,"date":"2019-05-20 16:11:34.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":-1,"date":"2019-05-23 09:14:53.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-18 10:42:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-20 16:11:34.000000000","updated_by":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"reviewer":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"state":"REVIEWER"},{"updated":"2019-05-23 09:14:53.000000000","updated_by":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"reviewer":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"state":"REVIEWER"},{"updated":"2019-05-24 16:53:44.000000000","updated_by":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"reviewer":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"state":"REVIEWER"}],"messages":[{"id":"9d115edbae38360b7461822f114d0782de81ced7","author":{"_account_id":24115,"name":"Xianghui Zeng","email":"zengxh1981@126.com","username":"XianghuiZeng"},"date":"2019-05-18 08:53:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b2158155207fe85b11017d02f08d2153012e6807","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-18 10:42:46.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/01/659901/1/check/openstack-tox-cover/f9767bf/ : FAILURE in 25m 51s\n- openstack-tox-lower-constraints http://logs.openstack.org/01/659901/1/check/openstack-tox-lower-constraints/3ea06f8/ : FAILURE in 29m 53s\n- openstack-tox-pep8 http://logs.openstack.org/01/659901/1/check/openstack-tox-pep8/f3073e9/ : FAILURE in 4m 41s\n- openstack-tox-py27 http://logs.openstack.org/01/659901/1/check/openstack-tox-py27/c47f9b7/ : SUCCESS in 21m 58s\n- openstack-tox-py36 http://logs.openstack.org/01/659901/1/check/openstack-tox-py36/8b484df/ : FAILURE in 23m 05s\n- openstack-tox-py37 http://logs.openstack.org/01/659901/1/check/openstack-tox-py37/e2ba1de/ : FAILURE in 22m 27s\n- openstack-tox-docs http://logs.openstack.org/01/659901/1/check/openstack-tox-docs/f90531a/html/ : SUCCESS in 7m 07s\n- tempest-full http://logs.openstack.org/01/659901/1/check/tempest-full/550d1d7/ : SUCCESS in 1h 43m 53s\n- neutron-grenade http://logs.openstack.org/01/659901/1/check/neutron-grenade/f7458fe/ : SUCCESS in 56m 59s\n- grenade-py3 http://logs.openstack.org/01/659901/1/check/grenade-py3/e408889/ : SUCCESS in 56m 28s\n- tempest-full-py3 http://logs.openstack.org/01/659901/1/check/tempest-full-py3/dc6f8a7/ : SUCCESS in 1h 28m 56s\n- keystone-dsvm-functional http://logs.openstack.org/01/659901/1/check/keystone-dsvm-functional/9d6848d/ : SUCCESS in 29m 31s\n- keystone-dsvm-py3-functional http://logs.openstack.org/01/659901/1/check/keystone-dsvm-py3-functional/ae0a4cf/ : SUCCESS in 29m 57s\n- keystone-dsvm-functional-federation-opensuse15 http://logs.openstack.org/01/659901/1/check/keystone-dsvm-functional-federation-opensuse15/77b698e/ : SUCCESS in 36m 44s (non-voting)\n- keystone-dsvm-py3-functional-federation-opensuse15 http://logs.openstack.org/01/659901/1/check/keystone-dsvm-py3-functional-federation-opensuse15/53cab06/ : SUCCESS in 39m 29s (non-voting)\n- keystoneclient-devstack-functional http://logs.openstack.org/01/659901/1/check/keystoneclient-devstack-functional/4f47c55/ : SUCCESS in 10m 19s (non-voting)\n- legacy-tempest-dsvm-ldap-domain-specific-driver http://logs.openstack.org/01/659901/1/check/legacy-tempest-dsvm-ldap-domain-specific-driver/248810e/ : SUCCESS in 1h 31m 55s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7bc40b847d38412fd85eddd1edd0c19af0d05f3c","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-05-20 16:11:34.000000000","message":"Patch Set 1: Code-Review-1\n\nPlease make it clear in the commit message what the problem is and how your change addresses it. Without more explanation, I can\u0027t tell at all how changing an error message and the unit tests fixes XSS issues.","accounts_in_message":[],"_revision_number":1},{"id":"5fb173429c8c1e4b96c7ad103517c6d1b3feb585","author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"date":"2019-05-23 09:14:53.000000000","message":"Patch Set 1: Code-Review-1\n\nHi Xianghui. Kindly create a bug describing the problem, which will be helpful for the reviewer. You can take help from [1]\n\n[1]https://docs.openstack.org/project-team-guide/bugs.html","accounts_in_message":[],"_revision_number":1},{"id":"c1e5fadf90e5825d6113e03d614e4f04ccbd9a5a","author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"date":"2019-05-24 16:53:44.000000000","message":"Patch Set 1: Code-Review-1\n\nI fail to see how this is a XSS, we are not returning request parameters to the user without sanitizing them. We are just returning out the attribute keys that are missing. We provide the parameters returned to the user. Please provide more information on your testing mechanism.","accounts_in_message":[],"_revision_number":1},{"id":"91a919ff564df6da1d7d924a78341e2e65204933","tag":"autogenerated:gerrit:abandon","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2021-06-04 18:16:52.000000000","message":"Abandoned\n\nAbandoning since there hasn\u0027t been any recent activity, if anyone wants to continue this work, please feel free to restore this or create a new change.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"68acb2d5c56613daf03b0a18393b024d282d2c21","revisions":{"68acb2d5c56613daf03b0a18393b024d282d2c21":{"kind":"REWORK","_number":1,"created":"2019-05-18 08:53:37.000000000","uploader":{"_account_id":24115,"name":"Xianghui Zeng","email":"zengxh1981@126.com","username":"XianghuiZeng"},"ref":"refs/changes/01/659901/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/01/659901/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/01/659901/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/01/659901/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/01/659901/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/01/659901/1"}}},"commit":{"parents":[{"commit":"9b81cebbafc89021982c036c095318acb06f7f93","subject":"Merge \"Cap sphinx for py2 to match global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/9b81cebbafc89021982c036c095318acb06f7f93"}]}],"author":{"name":"Xianghui Zeng","email":"zeng.xianghui@zte.com.cn","date":"2019-05-18 09:02:55.000000000","tz":480},"committer":{"name":"Xianghui Zeng","email":"zeng.xianghui@zte.com.cn","date":"2019-05-18 09:02:55.000000000","tz":480},"subject":"Fix XSS issues","message":"Fix XSS issues\n\nUsing webinspect tool to test, the test results show that there is XSS issues.\n\nChange-Id: Ibbbb8e42166e62f80975c0219eaee483a6df2d4f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/68acb2d5c56613daf03b0a18393b024d282d2c21"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/68acb2d5c56613daf03b0a18393b024d282d2c21"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}