)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1462e2f957db16128c235535a0b009d5ebe2eefc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"queried on a per-user basis and re-used with new application"},{"line_number":12,"context_line":"credentials. This change adds the user_id and external_id columns and"},{"line_number":13,"context_line":"indices to allow that."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8a516fc19be25350593ef915a94f029c65db8de2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fb8cfa7_1c580088","line":14,"updated":"2019-06-26 15:09:35.000000000","message":"Just clarifying, but this was discussed during the PTG or Forum? Are the details being tracked in a bug or an old blueprint somewhere?","commit_id":"194a2721d49cbee8bb749abd8f828d603f32a16c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"da5df22f43b64ca38124837175dbf122b1c4e3d3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"queried on a per-user basis and re-used with new application"},{"line_number":12,"context_line":"credentials. This change adds the user_id and external_id columns and"},{"line_number":13,"context_line":"indices to allow that."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8a516fc19be25350593ef915a94f029c65db8de2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fb8cfa7_df7d7a1c","line":14,"in_reply_to":"9fb8cfa7_1c580088","updated":"2019-06-26 15:25:58.000000000","message":"The work here lines up with the updated spec, so I can see a case for reusing the old blueprint. I\u0027d also be in favor of just opening RFE bugs specific for this, especially since you\u0027ve done a nice job of isolating functionality across patches.\n\nIt\u0027s your call, but I think we should link it to the specification/bug somehow.","commit_id":"194a2721d49cbee8bb749abd8f828d603f32a16c"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"d2fb8cbb7223f86e8d39f729976b51d4de20149f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"queried on a per-user basis and re-used with new application"},{"line_number":12,"context_line":"credentials. This change adds the user_id and external_id columns and"},{"line_number":13,"context_line":"indices to allow that."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8a516fc19be25350593ef915a94f029c65db8de2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fb8cfa7_d01a49c4","line":14,"in_reply_to":"9fb8cfa7_df7d7a1c","updated":"2019-06-28 16:49:18.000000000","message":"Oops, yes this is definitely missing the blueprint tag","commit_id":"194a2721d49cbee8bb749abd8f828d603f32a16c"}],"keystone/tests/unit/application_credential/backends/test_sql.py":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"3a1f261603648a1aaa64b5c3c1a322726f564808","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.assertExpectedSchema(\u0027application_credential_role\u0027, cols)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_access_rule_model(self):"},{"line_number":43,"context_line":"        cols \u003d ((\u0027id\u0027, sql.Integer, None),"},{"line_number":44,"context_line":"                (\u0027user_id\u0027, sql.String, 64),"},{"line_number":45,"context_line":"                (\u0027service\u0027, sql.String, 64),"},{"line_number":46,"context_line":"                (\u0027path\u0027, sql.String, 128),"},{"line_number":47,"context_line":"                (\u0027method\u0027, sql.String, 16))"},{"line_number":48,"context_line":"        self.assertExpectedSchema(\u0027access_rule\u0027, cols)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_application_credential_access_rule_model(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_b3e1ec9d","line":47,"range":{"start_line":43,"start_character":8,"end_line":47,"end_character":43},"updated":"2019-06-11 07:32:23.000000000","message":"IMO the cols should contain \"external_id\" too.\nThis also raises a concern that our current assertions are weak and doesn\u0027t check if more columns exist in table which aren\u0027t listed here.","commit_id":"cf47bc488130471c9fa7bfaef0614103b731b990"}]}