)]}'
{"id":"openstack%2Fkeystone~669886","triplet_id":"openstack%2Fkeystone~master~I704f346e8e7e3a0d007d68a055f6218fbb1b218e","project":"openstack/keystone","branch":"master","topic":"bug/1773967","hashtags":[],"change_id":"I704f346e8e7e3a0d007d68a055f6218fbb1b218e","subject":"Make application credentials work with group-assigned roles","status":"ABANDONED","created":"2019-07-09 15:03:50.000000000","updated":"2019-07-25 06:13:59.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cdf5b09141a6efdc3bccd30ff22dde7a139ef11e","_number":669886,"virtual_id_number":669886,"owner":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":-1,"date":"2019-07-09 19:56:32.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"date":"2019-07-10 21:54:23.000000000","_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"date":"2019-07-09 15:08:05.000000000","_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2019-07-25 05:15:38.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-09 19:56:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-10 21:54:23.000000000","updated_by":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"reviewer":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"state":"REVIEWER"},{"updated":"2019-07-25 05:15:38.000000000","updated_by":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"reviewer":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"state":"REVIEWER"}],"messages":[{"id":"0b085972a5457bde68f8b180d8b8bb16b544b81a","author":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"date":"2019-07-09 15:03:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f546608416001f717dc0642226b4c9b19434be87","author":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"date":"2019-07-09 15:08:05.000000000","message":"Patch Set 1:\n\nHi,\n\nThis is my first dive into Keystone code so I\u0027m probably missing something, but I\u0027m happy to learn :)\n\nThis change made application credentials work in our environment (no federation), but I realize that https://review.opendev.org/#/c/655166 might be the path to a better fix.","accounts_in_message":[],"_revision_number":1},{"id":"c2a692e8acbcd3f28ba068ad93a17bad2c79810e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-09 19:56:32.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/86/669886/1/check/openstack-tox-cover/d9efad2/cover/ : SUCCESS in 30m 08s\n- openstack-tox-lower-constraints http://logs.openstack.org/86/669886/1/check/openstack-tox-lower-constraints/53766a4/ : TIMED_OUT in 41m 36s\n- openstack-tox-pep8 http://logs.openstack.org/86/669886/1/check/openstack-tox-pep8/9b06546/ : SUCCESS in 6m 11s\n- openstack-tox-py27 http://logs.openstack.org/86/669886/1/check/openstack-tox-py27/d60b8ff/ : SUCCESS in 22m 55s\n- openstack-tox-py36 http://logs.openstack.org/86/669886/1/check/openstack-tox-py36/4d06f9e/ : SUCCESS in 28m 13s\n- openstack-tox-py37 http://logs.openstack.org/86/669886/1/check/openstack-tox-py37/c23f253/ : SUCCESS in 26m 31s\n- openstack-tox-docs http://logs.openstack.org/86/669886/1/check/openstack-tox-docs/851754e/html/ : SUCCESS in 7m 29s\n- tempest-full http://logs.openstack.org/86/669886/1/check/tempest-full/4615aa4/ : SUCCESS in 1h 37m 51s\n- neutron-grenade http://logs.openstack.org/86/669886/1/check/neutron-grenade/606c982/ : SUCCESS in 53m 57s\n- grenade-py3 http://logs.openstack.org/86/669886/1/check/grenade-py3/ad4bab5/ : SUCCESS in 1h 00m 38s\n- tempest-full-py3 http://logs.openstack.org/86/669886/1/check/tempest-full-py3/f689d31/ : SUCCESS in 1h 37m 00s\n- keystone-dsvm-functional http://logs.openstack.org/86/669886/1/check/keystone-dsvm-functional/3d2a1ce/ : SUCCESS in 38m 25s\n- keystone-dsvm-py3-functional http://logs.openstack.org/86/669886/1/check/keystone-dsvm-py3-functional/fdd873b/ : SUCCESS in 32m 22s\n- keystone-dsvm-functional-federation-opensuse15 http://logs.openstack.org/86/669886/1/check/keystone-dsvm-functional-federation-opensuse15/563a28c/ : SUCCESS in 36m 59s (non-voting)\n- keystone-dsvm-py3-functional-federation-opensuse15 http://logs.openstack.org/86/669886/1/check/keystone-dsvm-py3-functional-federation-opensuse15/69efc9d/ : SUCCESS in 53m 59s (non-voting)\n- keystoneclient-devstack-functional http://logs.openstack.org/86/669886/1/check/keystoneclient-devstack-functional/c8d0c96/ : SUCCESS in 16m 31s (non-voting)\n- legacy-tempest-dsvm-ldap-domain-specific-driver http://logs.openstack.org/86/669886/1/check/legacy-tempest-dsvm-ldap-domain-specific-driver/f8e2c8c/ : SUCCESS in 1h 49m 29s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e6c8cdc9abe85c2c15df28378a4e1d0d90fc7037","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-07-10 21:54:23.000000000","message":"Patch Set 1:\n\nHi Gauvain, thanks for this fix. There\u0027s a bit of history around this bug and we\u0027ve already attempted to solve it in a different patch: https://review.opendev.org/655166\n\nI\u0027ve restored that patch and we can continue discussion on that one.","accounts_in_message":[],"_revision_number":1},{"id":"d547b48cf3abb6b8ba485168511d8daea7c26608","author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"date":"2019-07-25 05:15:38.000000000","message":"Patch Set 1: Code-Review-1\n\nThe fix for the bug #1773967 is going on [1]. This can be abandoned.\n\n[1] https://review.opendev.org/#/c/655166/","accounts_in_message":[],"_revision_number":1},{"id":"95092ba254f46149eec09111b9a81dad3017e847","author":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"date":"2019-07-25 06:13:59.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5c48d165ecacbba485d12552cb4751c8c684221c","revisions":{"5c48d165ecacbba485d12552cb4751c8c684221c":{"kind":"REWORK","_number":1,"created":"2019-07-09 15:03:50.000000000","uploader":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"ref":"refs/changes/86/669886/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/86/669886/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/86/669886/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/86/669886/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/86/669886/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/86/669886/1"}}},"commit":{"parents":[{"commit":"19cd84b8409982a3d226fca25b090ff320a64aad","subject":"nit: remove some useless code","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/19cd84b8409982a3d226fca25b090ff320a64aad"}]}],"author":{"name":"Gauvain Pocentek","email":"gauvain.pocentek@objectif-libre.com","date":"2019-07-09 14:58:55.000000000","tz":120},"committer":{"name":"Gauvain Pocentek","email":"gauvain.pocentek@objectif-libre.com","date":"2019-07-09 15:03:48.000000000","tz":120},"subject":"Make application credentials work with group-assigned roles","message":"Make application credentials work with group-assigned roles\n\nCurrently the role assignment checks in the application credentials\ncode only deals with explicit user/role assignment for projects. This\npatch changes the behavior to also consider group/role assignments.\n\nCloses-Bug #1773967\n\nChange-Id: I704f346e8e7e3a0d007d68a055f6218fbb1b218e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/5c48d165ecacbba485d12552cb4751c8c684221c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/5c48d165ecacbba485d12552cb4751c8c684221c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}