)]}'
{"keystone/api/os_ep_filter.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"185af78584c121b665fdf7a2b8b02931ab4de875","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self._require_valid_filter(ep_group)"},{"line_number":88,"context_line":"        ep_group \u003d self._assign_unique_id(ep_group)"},{"line_number":89,"context_line":"        return self.wrap_member(PROVIDERS.catalog_api.create_endpoint_group("},{"line_number":90,"context_line":"            ep_group[\u0027id\u0027], ep_group)), http_client.CREATED"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def patch(self, endpoint_group_id):"},{"line_number":93,"context_line":"        ENFORCER.enforce_call(action\u003d\u0027identity:update_endpoint_group\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_d33ebeb6","side":"PARENT","line":90,"updated":"2019-07-17 09:32:08.000000000","message":"wait, this will break out-tree plubin as well.","commit_id":"10eab4824249a2ba190d80cc58e404f07c3d51e8"}],"keystone/catalog/backends/sql.py":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"dbe51ea776438fea425b1723388228784d136ec7","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            return ref.to_dict()"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    # Endpoints"},{"line_number":223,"context_line":"    def create_endpoint(self, endpoint_id, endpoint):"},{"line_number":224,"context_line":"        with sql.session_for_write() as session:"},{"line_number":225,"context_line":"            endpoint_ref \u003d Endpoint.from_dict(endpoint)"},{"line_number":226,"context_line":"            session.add(endpoint_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_c285985b","line":223,"range":{"start_line":223,"start_character":30,"end_line":223,"end_character":41},"updated":"2019-07-16 11:27:06.000000000","message":"This should be removed too.","commit_id":"e82567e55261197bd6166190bfaa301957627349"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"e8bb304408975d82383dd4a9d2dd8ad0b493ce35","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            return ref.to_dict()"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    # Endpoints"},{"line_number":223,"context_line":"    def create_endpoint(self, endpoint_id, endpoint):"},{"line_number":224,"context_line":"        with sql.session_for_write() as session:"},{"line_number":225,"context_line":"            endpoint_ref \u003d Endpoint.from_dict(endpoint)"},{"line_number":226,"context_line":"            session.add(endpoint_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_78580955","line":223,"range":{"start_line":223,"start_character":30,"end_line":223,"end_character":41},"in_reply_to":"7faddb67_18431515","updated":"2019-07-17 09:27:05.000000000","message":"that is the problem, if we change the interface in base.py, the third part out-tree catalog plugin driver will be broken.","commit_id":"e82567e55261197bd6166190bfaa301957627349"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"86fa830d956872ab9e001c1cfa2629515aa8d2ca","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            return ref.to_dict()"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    # Endpoints"},{"line_number":223,"context_line":"    def create_endpoint(self, endpoint_id, endpoint):"},{"line_number":224,"context_line":"        with sql.session_for_write() as session:"},{"line_number":225,"context_line":"            endpoint_ref \u003d Endpoint.from_dict(endpoint)"},{"line_number":226,"context_line":"            session.add(endpoint_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_18431515","line":223,"range":{"start_line":223,"start_character":30,"end_line":223,"end_character":41},"in_reply_to":"7faddb67_ad4de13e","updated":"2019-07-17 08:53:02.000000000","message":"Since \u0027endpoint_id\u0027 isn\u0027t in use in this function. Can\u0027t we avoid passing it in here [1] and also updating [2]\n\n[1] https://github.com/openstack/keystone/blob/master/keystone/catalog/core.py#L200\n[2]https://github.com/openstack/keystone/blob/master/keystone/catalog/backends/base.py#L158","commit_id":"e82567e55261197bd6166190bfaa301957627349"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"cba48b31ab0dc604fbaa72649b0cc5c0dea9cee6","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            return ref.to_dict()"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    # Endpoints"},{"line_number":223,"context_line":"    def create_endpoint(self, endpoint_id, endpoint):"},{"line_number":224,"context_line":"        with sql.session_for_write() as session:"},{"line_number":225,"context_line":"            endpoint_ref \u003d Endpoint.from_dict(endpoint)"},{"line_number":226,"context_line":"            session.add(endpoint_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_ad4de13e","line":223,"range":{"start_line":223,"start_character":30,"end_line":223,"end_character":41},"in_reply_to":"7faddb67_c285985b","updated":"2019-07-17 07:43:40.000000000","message":"I prefer not. Since the base function contains `endpoint_id` as well, removing it will break base interface.","commit_id":"e82567e55261197bd6166190bfaa301957627349"}]}