)]}'
{"id":"openstack%2Fkeystone~674122","triplet_id":"openstack%2Fkeystone~master~Id423f8a304abffbe0c7814ab2ab4458e6a403bb1","project":"openstack/keystone","branch":"master","topic":"fix-websso","hashtags":[],"change_id":"Id423f8a304abffbe0c7814ab2ab4458e6a403bb1","subject":"Fix websso auth loop","status":"MERGED","created":"2019-08-01 19:42:01.000000000","updated":"2019-08-06 18:22:45.000000000","submitted":"2019-08-06 18:22:45.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"674122-1565115765768-45ecd640","meta_rev_id":"5c8671e1d244df0f0d3a7b604975aeac135f7d20","_number":674122,"virtual_id_number":674122,"owner":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":2,"date":"2019-08-06 18:22:45.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"all":[{"value":2,"date":"2019-08-01 20:20:51.000000000","_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-02 21:37:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":2,"date":"2019-08-06 16:37:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"all":[{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":1,"date":"2019-08-06 16:37:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-01 20:20:51.000000000","updated_by":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"reviewer":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"state":"REVIEWER"},{"updated":"2019-08-02 21:37:05.000000000","updated_by":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"reviewer":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"state":"REVIEWER"},{"updated":"2019-08-06 16:37:10.000000000","updated_by":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"reviewer":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"state":"REVIEWER"},{"updated":"2019-08-06 18:22:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8b8ff6e36c2fde4b11020a8b0d66914f5b58e7d0","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-08-01 19:42:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2c9bd0585346072b273a3ab525ee8d502e7254f9","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2019-08-01 20:20:51.000000000","message":"Patch Set 1: Code-Review+2\n\nI am able to validate the changes in my dev box as well.","accounts_in_message":[],"_revision_number":1},{"id":"161ce5e9bb5123416c38e8762f8c2304b0d42414","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-02 01:47:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://logs.opendev.org/22/674122/1/check/openstack-tox-cover/6122c67/cover/ : SUCCESS in 40m 55s\n- openstack-tox-lower-constraints https://logs.opendev.org/22/674122/1/check/openstack-tox-lower-constraints/92ff3c1/ : SUCCESS in 36m 41s\n- openstack-tox-pep8 https://logs.opendev.org/22/674122/1/check/openstack-tox-pep8/cea2c42/ : SUCCESS in 5m 50s\n- openstack-tox-py27 https://logs.opendev.org/22/674122/1/check/openstack-tox-py27/0632930/ : SUCCESS in 34m 41s\n- openstack-tox-py36 https://logs.opendev.org/22/674122/1/check/openstack-tox-py36/50f5731/ : SUCCESS in 27m 02s\n- openstack-tox-py37 https://logs.opendev.org/22/674122/1/check/openstack-tox-py37/c90d181/ : SUCCESS in 29m 11s\n- openstack-tox-docs https://logs.opendev.org/22/674122/1/check/openstack-tox-docs/99b0131/html/ : SUCCESS in 8m 03s\n- tempest-full https://logs.opendev.org/22/674122/1/check/tempest-full/dde7d61/ : SUCCESS in 2h 02m 36s\n- neutron-grenade https://logs.opendev.org/22/674122/1/check/neutron-grenade/a2fbc80/ : SUCCESS in 57m 11s\n- grenade-py3 https://logs.opendev.org/22/674122/1/check/grenade-py3/c667c52/ : SUCCESS in 56m 19s\n- tempest-full-py3 https://logs.opendev.org/22/674122/1/check/tempest-full-py3/9fa8566/ : SUCCESS in 1h 25m 27s\n- keystone-dsvm-functional https://logs.opendev.org/22/674122/1/check/keystone-dsvm-functional/2f7269c/ : SUCCESS in 35m 43s\n- keystone-dsvm-py3-functional https://logs.opendev.org/22/674122/1/check/keystone-dsvm-py3-functional/c1dde18/ : SUCCESS in 34m 58s\n- keystone-dsvm-functional-federation-opensuse15 https://logs.opendev.org/22/674122/1/check/keystone-dsvm-functional-federation-opensuse15/f413329/ : SUCCESS in 44m 55s (non-voting)\n- keystone-dsvm-py3-functional-federation-opensuse15 https://logs.opendev.org/22/674122/1/check/keystone-dsvm-py3-functional-federation-opensuse15/6191e34/ : SUCCESS in 50m 24s (non-voting)\n- keystoneclient-devstack-functional https://logs.opendev.org/22/674122/1/check/keystoneclient-devstack-functional/448636c/ : SUCCESS in 16m 16s (non-voting)\n- legacy-tempest-dsvm-ldap-domain-specific-driver https://logs.opendev.org/22/674122/1/check/legacy-tempest-dsvm-ldap-domain-specific-driver/c7df177/ : SUCCESS in 1h 35m 28s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7e5b5841d10c7a807f19dbb4984469e23dde99a3","author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"date":"2019-08-02 21:37:05.000000000","message":"Patch Set 1: Code-Review+1\n\nLooks good","accounts_in_message":[],"_revision_number":1},{"id":"387b694f2be72bdb587ad6ac556cb4404ac2e60e","author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"date":"2019-08-06 16:37:10.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"f7bf1d8e70f6eb4aeaa55ce5b13445ef706e49d0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 16:37:39.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"ed2b4ce6e9e240a67f2ef5ee373acfb1ab00dd22","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 18:22:45.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"c069119f3b9a1e403155de64fab243d6ec5729ff","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 18:22:45.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://logs.opendev.org/22/674122/1/gate/openstack-tox-lower-constraints/f92a311/ : SUCCESS in 39m 17s\n- openstack-tox-pep8 https://logs.opendev.org/22/674122/1/gate/openstack-tox-pep8/9f83ba3/ : SUCCESS in 5m 34s\n- openstack-tox-py27 https://logs.opendev.org/22/674122/1/gate/openstack-tox-py27/3b93c9f/ : SUCCESS in 28m 40s\n- openstack-tox-py36 https://logs.opendev.org/22/674122/1/gate/openstack-tox-py36/eb2170a/ : SUCCESS in 28m 46s\n- openstack-tox-py37 https://logs.opendev.org/22/674122/1/gate/openstack-tox-py37/81a6701/ : SUCCESS in 30m 38s\n- openstack-tox-docs https://logs.opendev.org/22/674122/1/gate/openstack-tox-docs/883d3c2/html/ : SUCCESS in 7m 38s\n- tempest-full https://logs.opendev.org/22/674122/1/gate/tempest-full/e32048f/ : SUCCESS in 1h 34m 09s\n- neutron-grenade https://logs.opendev.org/22/674122/1/gate/neutron-grenade/31c70a0/ : SUCCESS in 53m 52s\n- grenade-py3 https://logs.opendev.org/22/674122/1/gate/grenade-py3/d2f75c6/ : SUCCESS in 1h 01m 40s\n- tempest-full-py3 https://logs.opendev.org/22/674122/1/gate/tempest-full-py3/4d767f8/ : SUCCESS in 1h 21m 39s\n- keystone-dsvm-functional https://logs.opendev.org/22/674122/1/gate/keystone-dsvm-functional/ab87f1f/ : SUCCESS in 33m 28s\n- keystone-dsvm-py3-functional https://logs.opendev.org/22/674122/1/gate/keystone-dsvm-py3-functional/c28f8a1/ : SUCCESS in 37m 06s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d8f3ba0429c535cdc9dbde83d948b816ae7d760b","revisions":{"d8f3ba0429c535cdc9dbde83d948b816ae7d760b":{"kind":"REWORK","_number":1,"created":"2019-08-01 19:42:01.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/22/674122/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/22/674122/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/22/674122/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/22/674122/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/22/674122/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/22/674122/1"}}},"commit":{"parents":[{"commit":"97d38108d624849b2facee454e9414d94fb51244","subject":"Merge \"Fix python3 compatibility on LDAP search DN from id\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/97d38108d624849b2facee454e9414d94fb51244"}]}],"author":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-08-01 19:34:30.000000000","tz":-420},"committer":{"name":"Colleen Murphy","email":"colleen.murphy@suse.de","date":"2019-08-01 19:34:30.000000000","tz":-420},"subject":"Fix websso auth loop","message":"Fix websso auth loop\n\nIn bf67b3c8[1] we introduced an error whereby trying to use WebSSO to\nauthenticate with one protocol would fail with an uncaught HTTP 404 if\nan IdP was found that did not use that protocol. This patch fixes the\nissue by ensuring that during the search for an IdP that matches the\ngiven protocol, we ignore invalid IdPs.\n\nThis is tested by the existing WebSSOTests unit test class simply by\ninserting a dummy IdP and protocol combination into the test data during\nsetup, since the problem arises when the protocol you are *not* trying\nto authenticate with is indexed first in the database.\n\nSince the breaking change was not released yet, this bugfix does not\nneed a release note.\n\n[1] https://review.opendev.org/637305\n\nChange-Id: Id423f8a304abffbe0c7814ab2ab4458e6a403bb1\nCloses-bug: #1838592\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/d8f3ba0429c535cdc9dbde83d948b816ae7d760b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/d8f3ba0429c535cdc9dbde83d948b816ae7d760b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}