)]}'
{"keystone/cmd/status.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"40bbd4f5e18db538c726437ab48eb400a5736f5e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        roles \u003d PROVIDERS.role_api.list_roles()"},{"line_number":68,"context_line":"        default_roles \u003d (\u0027admin\u0027, \u0027member\u0027, \u0027reader\u0027,)"},{"line_number":69,"context_line":"        failed_roles \u003d []"},{"line_number":70,"context_line":"        for role in [r for r in roles if r[\u0027name\u0027] in default_roles]:"},{"line_number":71,"context_line":"            if not role.get(\u0027options\u0027, {}).get(\u0027immutable\u0027):"},{"line_number":72,"context_line":"                failed_roles.append(role[\u0027name\u0027])"},{"line_number":73,"context_line":"        if any(failed_roles):"}],"source_content_type":"text/x-python","patch_set":12,"id":"5faad753_9f9e6152","line":70,"updated":"2019-09-11 17:33:18.000000000","message":"we can have a domain-specific role and a global role with the same name right?","commit_id":"01c7c8035e0d10533e19a661704a5c92c557ac90"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"bb36465b87f6fe4829635aa7d696ea7c9608079b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        roles \u003d PROVIDERS.role_api.list_roles()"},{"line_number":68,"context_line":"        default_roles \u003d (\u0027admin\u0027, \u0027member\u0027, \u0027reader\u0027,)"},{"line_number":69,"context_line":"        failed_roles \u003d []"},{"line_number":70,"context_line":"        for role in [r for r in roles if r[\u0027name\u0027] in default_roles]:"},{"line_number":71,"context_line":"            if not role.get(\u0027options\u0027, {}).get(\u0027immutable\u0027):"},{"line_number":72,"context_line":"                failed_roles.append(role[\u0027name\u0027])"},{"line_number":73,"context_line":"        if any(failed_roles):"}],"source_content_type":"text/x-python","patch_set":12,"id":"5faad753_dfedb98b","line":70,"in_reply_to":"5faad753_9f9e6152","updated":"2019-09-11 17:43:17.000000000","message":"Good catch, we should only be checking the global roles here","commit_id":"01c7c8035e0d10533e19a661704a5c92c557ac90"}]}
