)]}'
{"id":"openstack%2Fkeystone~676991","triplet_id":"openstack%2Fkeystone~master~I8537afad94fae365a4293b6d4ff8e36b911d48d8","project":"openstack/keystone","branch":"master","hashtags":[],"change_id":"I8537afad94fae365a4293b6d4ff8e36b911d48d8","subject":"Fix caching behavior","status":"ABANDONED","created":"2019-08-16 17:02:45.000000000","updated":"2019-08-20 10:23:16.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6baa6be6b0fecf7e2552e24865fc9d15d57a3f6b","_number":676991,"virtual_id_number":676991,"owner":{"_account_id":30834,"name":"Nikita Kalyanov","email":"nikitakalyanov@gmail.com","username":"nikitakalyanov"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":-1,"date":"2019-08-16 18:49:43.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},{"value":-1,"date":"2019-08-16 20:50:32.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2019-08-16 17:04:10.000000000","_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-16 17:04:10.000000000","updated_by":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"reviewer":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"state":"REVIEWER"},{"updated":"2019-08-16 18:49:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-16 20:50:32.000000000","updated_by":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"reviewer":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"state":"REVIEWER"}],"messages":[{"id":"5fe68b229f6decabb57b021b84e63a0fcbfa0597","author":{"_account_id":30834,"name":"Nikita Kalyanov","email":"nikitakalyanov@gmail.com","username":"nikitakalyanov"},"date":"2019-08-16 17:02:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"42eb5c5ba25352d6c55cde7b02db18f15e1896ef","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 18:49:43.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b2b3fb6fc81042368fb0301d141aca3b : FAILURE in 31m 58s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5b930ceca9514976a828b42006bdcf31 : FAILURE in 31m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e73481197a3241a1ba7a8b6d6e75d850 : SUCCESS in 5m 43s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/fbc095da06a14ac787ff136d29ee2cbb : FAILURE in 26m 15s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b4d0af38c5034f2cb8139480f753d989 : FAILURE in 24m 02s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/0ebc30958e604964a6a075c15c46fdb6 : FAILURE in 23m 45s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c92c99ea263b4af896131ab623398553 : SUCCESS in 10m 12s\n- tempest-full https://zuul.opendev.org/t/openstack/build/d6f245c5f69e43208115dd41c606e642 : SUCCESS in 1h 32m 46s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/a9a58cce825844198096f798619cd6de : SUCCESS in 1h 00m 17s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/43575bc3210c4e4d80e7dca8a048eec6 : SUCCESS in 58m 09s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/a1a0acd03be24ba09cb7793f53d6f689 : SUCCESS in 1h 25m 58s\n- keystone-dsvm-functional https://zuul.opendev.org/t/openstack/build/8137c56e0e8242988ec2f9c42cc10196 : SUCCESS in 36m 57s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/188a90c1969b437b8131e86f0cb1b32c : SUCCESS in 33m 37s\n- keystone-dsvm-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/88749df494744fe4965d991ef3d2e792 : SUCCESS in 31m 00s (non-voting)\n- keystone-dsvm-py3-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/8020daf1296a4d1f992ab223cbdeda0d : POST_FAILURE in 36m 56s (non-voting)\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/2c64ab30e40448968c4b90aa456d37df : FAILURE in 13m 03s (non-voting)\n- legacy-tempest-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/c1a474dbc2374b1b8924a66632448d08 : SUCCESS in 1h 40m 38s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/86d6cbd875fe4ab4975d8c50b3971a2e : SUCCESS in 1h 04m 47s","accounts_in_message":[],"_revision_number":1},{"id":"2f898253144e68c2b940a8780c293a47f6b16b55","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2019-08-16 20:50:32.000000000","message":"Patch Set 1: Code-Review-1\n\nUnder no circumstances should there be caching of decrypted elements or re-decryption, it should be a single pass and return. Please show an example of the traceback, please file a bug, and instead of adding in a copy to the decrypt, ensure we never pass through decryption a second time, if we are there is another flaw in our code.","accounts_in_message":[],"_revision_number":1},{"id":"76cf4b74f3531bdc7b867f57a0cb9adbc8de60ec","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2019-08-16 20:52:03.000000000","message":"Patch Set 1:\n\nalso requires a release note.","accounts_in_message":[],"_revision_number":1},{"id":"6baa6be6b0fecf7e2552e24865fc9d15d57a3f6b","author":{"_account_id":30834,"name":"Nikita Kalyanov","email":"nikitakalyanov@gmail.com","username":"nikitakalyanov"},"date":"2019-08-20 10:23:16.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8db9536a7643753f0b3bde73da9e4f41f0105b87","revisions":{"8db9536a7643753f0b3bde73da9e4f41f0105b87":{"kind":"REWORK","_number":1,"created":"2019-08-16 17:02:45.000000000","uploader":{"_account_id":30834,"name":"Nikita Kalyanov","email":"nikitakalyanov@gmail.com","username":"nikitakalyanov"},"ref":"refs/changes/91/676991/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/91/676991/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/91/676991/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/91/676991/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/91/676991/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/91/676991/1"}}},"commit":{"parents":[{"commit":"182aa60791f3c221d79660bf0158c52886da1700","subject":"Update broken link","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/182aa60791f3c221d79660bf0158c52886da1700"}]}],"author":{"name":"Nikita Kalyanov","email":"nikitakalyanov@gmail.com","date":"2019-08-16 16:37:04.000000000","tz":180},"committer":{"name":"Nikita Kalyanov","email":"nikitakalyanov@gmail.com","date":"2019-08-16 16:37:04.000000000","tz":180},"subject":"Fix caching behavior","message":"Fix caching behavior\n\nThe previous realization of the method led to unstable caching behaviour:\nThe method modified credential dictionary in-place. For the second and subsequent calls for the same user the caching mechanism\npassed the modified in-place dictionary back to the method resulting in a KeyError.\nBasically the already decrypted in-place credential was fed back to the _decrypt_credential method by the caching mechanism.\nThe solution is to modify the copy of the dictionary (as in _encrypt_credential method).\nThis way the originally retrieved encrypted credential does not get modified\nand the caching could properly work.\n\nChange-Id: I8537afad94fae365a4293b6d4ff8e36b911d48d8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/8db9536a7643753f0b3bde73da9e4f41f0105b87"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/8db9536a7643753f0b3bde73da9e4f41f0105b87"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}