)]}'
{"id":"openstack%2Fkeystone~677117","triplet_id":"openstack%2Fkeystone~master~Icb3d9dcd25a5dde0676fc4bd4eaad7b265a0c99d","project":"openstack/keystone","branch":"master","topic":"fix-i18n-resp","hashtags":[],"change_id":"Icb3d9dcd25a5dde0676fc4bd4eaad7b265a0c99d","subject":"Fix translated response","status":"MERGED","created":"2019-08-19 06:49:58.000000000","updated":"2019-08-23 11:13:01.000000000","submitted":"2019-08-23 11:10:54.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"677117-1566558654205-66c16398","meta_rev_id":"a37cab7579e6d59a5910752cc17bc76a777fdec4","_number":677117,"virtual_id_number":677117,"owner":{"_account_id":19766,"name":"Shengjing Zhu","email":"zsj950618@gmail.com","username":"zhsj"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"date":"2019-08-19 12:16:36.000000000","_account_id":19766,"name":"Shengjing Zhu","email":"zsj950618@gmail.com","username":"zhsj"},{"value":2,"date":"2019-08-23 11:10:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"recommended":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"all":[{"value":1,"date":"2019-08-21 14:09:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":2,"date":"2019-08-19 23:46:25.000000000","_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":1,"date":"2019-08-21 13:33:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"_account_id":19766,"name":"Shengjing Zhu","email":"zsj950618@gmail.com","username":"zhsj"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-23 07:09:13.000000000","_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"all":[{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"_account_id":19766,"name":"Shengjing Zhu","email":"zsj950618@gmail.com","username":"zhsj"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-23 07:09:13.000000000","_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},{"_account_id":19766,"name":"Shengjing Zhu","email":"zsj950618@gmail.com","username":"zhsj"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-19 23:46:25.000000000","updated_by":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"reviewer":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"state":"REVIEWER"},{"updated":"2019-08-21 13:33:19.000000000","updated_by":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"reviewer":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"state":"REVIEWER"},{"updated":"2019-08-21 14:09:51.000000000","updated_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"reviewer":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"state":"REVIEWER"},{"updated":"2019-08-23 07:09:13.000000000","updated_by":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"reviewer":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"state":"REVIEWER"},{"updated":"2019-08-23 11:10:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4cdd5c71836b1e71eeb6bf33522072442b87d257","author":{"_account_id":19766,"name":"Shengjing Zhu","email":"zsj950618@gmail.com","username":"zhsj"},"date":"2019-08-19 06:49:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2d204c2ba4e4dd55687d3cb451a16f9b6fe9e520","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-19 08:38:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/175f600f241741e78d2443bcd6c5d75d : SUCCESS in 30m 34s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/72ef4871e7114198905b3da19e3e1450 : SUCCESS in 40m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ac5f7d432a65449e9ba097f3b9ff97b4 : SUCCESS in 6m 43s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/888a3f19994e49358c65b91ea329a39d : SUCCESS in 36m 47s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a39727d37b5d4b078b80860380abdce6 : SUCCESS in 35m 06s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/ba874978d20741e98d316ab06a7d51f9 : SUCCESS in 31m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/57c00a9901e14776ace423fb4d7b1724 : SUCCESS in 10m 38s\n- tempest-full https://zuul.opendev.org/t/openstack/build/46a9efad3d6a47ee88083434a4119a07 : SUCCESS in 1h 42m 32s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/83d98db6ac334db0a28d724a8cea1330 : SUCCESS in 1h 04m 44s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/e5738860ac5c42a297581b5c1326ad9b : SUCCESS in 57m 13s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/0f198ffd4bb24d8c803c0df88118a1d3 : SUCCESS in 1h 34m 23s\n- keystone-dsvm-functional https://zuul.opendev.org/t/openstack/build/d47f32bc47a84084a7127c1d51723baf : SUCCESS in 35m 54s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/8fb85e89ce5b486faa6a87b2ae05351e : SUCCESS in 34m 30s\n- keystone-dsvm-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/1a13cf8e24144c4cb4a2caa745ab1f06 : SUCCESS in 45m 51s (non-voting)\n- keystone-dsvm-py3-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/833df99359bc487cbb1d29dca886a851 : SUCCESS in 47m 26s (non-voting)\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/a50e6fa6576c4432bcee2744c293e866 : SUCCESS in 15m 57s (non-voting)\n- legacy-tempest-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/5dcaab60c3394c53894675a8a92c1235 : SUCCESS in 1h 28m 57s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/a79b54b24191463c93101ade3adfd33c : SUCCESS in 1h 02m 15s","accounts_in_message":[],"_revision_number":1},{"id":"9e1cf0d8996da40860fde0c7e7ba5d7a317bf4d9","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2019-08-19 11:20:10.000000000","message":"Patch Set 1:\n\nIIRC, there was a discussion about removing `enable_lazy`. While I forgot  the conclusion.\n\nwould you please take a look at the history first? \n\nThanks.\n\nhttps://bugs.launchpad.net/oslo.i18n/+bug/1801761\nhttp://lists.openstack.org/pipermail/openstack-operators/2018-November/016139.html","accounts_in_message":[],"_revision_number":1},{"id":"44b30538a9126e04676e232d6eb92e545b69e75a","author":{"_account_id":19766,"name":"Shengjing Zhu","email":"zsj950618@gmail.com","username":"zhsj"},"date":"2019-08-19 12:16:36.000000000","message":"Patch Set 1:\n\n\u003e IIRC, there was a discussion about removing `enable_lazy`. While I\n \u003e forgot  the conclusion.\n \u003e \n \u003e would you please take a look at the history first?\n \u003e \n \u003e Thanks.\n \u003e \n \u003e https://bugs.launchpad.net/oslo.i18n/+bug/1801761\n \u003e http://lists.openstack.org/pipermail/openstack-operators/2018-November/016139.html\n\n \u003e IIRC, there was a discussion about removing `enable_lazy`. While I\n \u003e forgot  the conclusion.\n \u003e \n \u003e would you please take a look at the history first?\n \u003e \n \u003e Thanks.\n \u003e \n \u003e https://bugs.launchpad.net/oslo.i18n/+bug/1801761\n \u003e http://lists.openstack.org/pipermail/openstack-operators/2018-November/016139.html\n\nSeems nobody is moving forward with this issue.\n\nI think if the project is going to remove the API response translation, then the buggy code should be removed. But at this point, maybe just fix the broken code with less effort?","accounts_in_message":[],"_revision_number":1},{"id":"8e0bbf0a92933c120f58ac3046b733eec247a681","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2019-08-19 20:46:25.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3734350678a4179dc2d02f9cdf9a6387a7f47fe5","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-08-19 23:46:25.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a65ef44cf4768ad7faa1f7738a92dcebcde8fe78","author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"date":"2019-08-21 13:33:19.000000000","message":"Patch Set 1: Code-Review+1\n\nMakes sense","accounts_in_message":[],"_revision_number":1},{"id":"215cac6ffa927964234582f3a5b6d040f4777473","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2019-08-21 14:09:51.000000000","message":"Patch Set 1: Code-Review+1\n\nTo specifically address the question of whether lazy translation is going away, I guess this patch suggests the answer is \"no\". The main reason we were looking to remove it was that we weren\u0027t sure anyone was actually using it, and this patch is evidence that someone is. It does add some complexity to the translation framework, but it\u0027s not a huge maintenance burden otherwise.","accounts_in_message":[],"_revision_number":1},{"id":"a70459a1e52b4bc007c0a5cc1991932840415555","author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"date":"2019-08-23 07:09:13.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nThanks very much for the replay.","accounts_in_message":[],"_revision_number":1},{"id":"1cdda1060b3353717cf5ec03dc891e3984993fe6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-23 07:09:38.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"33625972d1a27ec283d0af85254e453f359f60d1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-23 11:10:53.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b4b5d81d89f64e9fbc9c88b09d90aede : SUCCESS in 39m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ebf4c169a5dd4b168db1a08e4c38ef0a : SUCCESS in 7m 19s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/cd8e2b575f1c47e58fe08c9e6ca8ce9f : SUCCESS in 30m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8610e1ed3843429c818da42d4e59ac41 : SUCCESS in 32m 01s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/17aaf728ffd64ff99f8a592f6c949acd : SUCCESS in 28m 18s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/01cc34914d57458b8e2d51ea243b960b : SUCCESS in 11m 43s\n- tempest-full https://zuul.opendev.org/t/openstack/build/f3bbf44effe24e718c897b634d49a964 : SUCCESS in 1h 59m 14s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/d28991a879e54063bef3cfd5c14f2fd1 : SUCCESS in 55m 11s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/8e449180fc804ecdbe8bc5dcdd6e65e9 : SUCCESS in 1h 02m 37s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/9d8cb0adbd4f45ce94357d919f8d423f : SUCCESS in 1h 26m 52s\n- keystone-dsvm-functional https://zuul.opendev.org/t/openstack/build/eadae9d718184e04bf72525ff73c6c30 : SUCCESS in 34m 02s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/45e71f01ce30497b81d0c7622c0db344 : SUCCESS in 35m 23s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/e926745b07b740deaf1709033c047f26 : SUCCESS in 1h 09m 56s","accounts_in_message":[],"_revision_number":1},{"id":"f223af533a3c23fa382c120b106a11c601063390","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-23 11:10:54.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"a1add6df13655edbc35824f9531292431b0d5456","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-23 11:13:01.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a55da6f66ebe4270836191453bfeeaf5 : SUCCESS in 1m 42s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6abd44500f3cfce4f74204b77b0e92ecb0d8c4a2","revisions":{"6abd44500f3cfce4f74204b77b0e92ecb0d8c4a2":{"kind":"REWORK","_number":1,"created":"2019-08-19 06:49:58.000000000","uploader":{"_account_id":19766,"name":"Shengjing Zhu","email":"zsj950618@gmail.com","username":"zhsj"},"ref":"refs/changes/17/677117/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/17/677117/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/17/677117/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/17/677117/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/17/677117/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/17/677117/1"}}},"commit":{"parents":[{"commit":"7aa97f1712f6dcb1981f293b3e1eb2e74b084515","subject":"Merge \"Add protection tests for trusts API\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/7aa97f1712f6dcb1981f293b3e1eb2e74b084515"}]}],"author":{"name":"Shengjing Zhu","email":"zsj950618@gmail.com","date":"2019-08-19 06:49:37.000000000","tz":480},"committer":{"name":"Shengjing Zhu","email":"zsj950618@gmail.com","date":"2019-08-19 06:49:37.000000000","tz":480},"subject":"Fix translated response","message":"Fix translated response\n\nWhen request has ``Accept-Language`` header, keystone should response\nthe translated message. Without oslo_i18n lazy translation feature, the\nmessage will be translated before the server knows the language.\n\nActually this has been fixed previously, like\n2167e3612cbb79003cc0b8a98607f346238d7be4\n\nBut seems the logic was broken after i18n refactor.\n\nChange-Id: Icb3d9dcd25a5dde0676fc4bd4eaad7b265a0c99d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/6abd44500f3cfce4f74204b77b0e92ecb0d8c4a2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/6abd44500f3cfce4f74204b77b0e92ecb0d8c4a2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}