)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"afce66a19bb0178b43b662cf2e165c2cb9abcd94","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-01-19 17:05:01 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactored JsonBodyMiddleware and XmlBodyMiddleware to fix"},{"line_number":8,"context_line":"the double parsing issue"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Closes-Bug: #1270516"},{"line_number":11,"context_line":"Change-Id: I99da2e0aebbcff23d9d1ffccbdd47ee47a02a887"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2B%2B5c%3D","line":8,"updated":"2014-01-20 05:15:20.000000000","message":"Looks like pep8 is failing here (Git commit title 50+ characters), the following is a good guide for structuring commit messages. \n\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"6a6a98d9e440e3b41485fd3f6c3e90a8d891d832"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"aaae91e85545efff2fbe7e475e10a193a5e81db1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-01-19 17:05:01 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactored JsonBodyMiddleware and XmlBodyMiddleware to fix"},{"line_number":8,"context_line":"the double parsing issue"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Closes-Bug: #1270516"},{"line_number":11,"context_line":"Change-Id: I99da2e0aebbcff23d9d1ffccbdd47ee47a02a887"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2B8qI%3D","line":8,"in_reply_to":"AAAAUH%2F%2B%2B5c%3D","updated":"2014-01-20 14:33:36.000000000","message":"Agreed. The commit message (besides the 50-char thing) does not describe what the patch is doing and why. What is the \"double parsing issue\"? What is the patch refactoring and why did you choose the strategy you did? These are the kinds of things that should go in a commit message.","commit_id":"6a6a98d9e440e3b41485fd3f6c3e90a8d891d832"},{"author":{"_account_id":7874,"name":"Venkat Sundaram","email":"tsv@hp.com","username":"tsv"},"change_message_id":"df38071f0abfde596405526172279522461bed53","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-01-19 17:05:01 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactored JsonBodyMiddleware and XmlBodyMiddleware to fix"},{"line_number":8,"context_line":"the double parsing issue"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Closes-Bug: #1270516"},{"line_number":11,"context_line":"Change-Id: I99da2e0aebbcff23d9d1ffccbdd47ee47a02a887"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2B4ac%3D","line":8,"in_reply_to":"AAAAUH%2F%2B%2B5c%3D","updated":"2014-01-21 05:50:32.000000000","message":"Thanks. That was a nice wiki. Have tried to follow the advice. Please review","commit_id":"6a6a98d9e440e3b41485fd3f6c3e90a8d891d832"},{"author":{"_account_id":7874,"name":"Venkat Sundaram","email":"tsv@hp.com","username":"tsv"},"change_message_id":"df38071f0abfde596405526172279522461bed53","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-01-19 17:05:01 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactored JsonBodyMiddleware and XmlBodyMiddleware to fix"},{"line_number":8,"context_line":"the double parsing issue"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Closes-Bug: #1270516"},{"line_number":11,"context_line":"Change-Id: I99da2e0aebbcff23d9d1ffccbdd47ee47a02a887"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2B4aY%3D","line":8,"in_reply_to":"AAAAUH%2F%2B8qI%3D","updated":"2014-01-21 05:50:32.000000000","message":"Thanks. Have now provided more details in the comment. Please review. Done","commit_id":"6a6a98d9e440e3b41485fd3f6c3e90a8d891d832"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"8c00c2a1766f1dcfc67859d7be051820f066b243","unresolved":false,"context_lines":[{"line_number":36,"context_line":"   Store the unfiltered dict in the request body as JSON string."},{"line_number":37,"context_line":"   Set an environment variable \"SKIP_JSON_PARSING\" to True"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"5. Added tests corresponding to \"SKIP_JSON_PARSING\" logic"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Closes-Bug: #1270516"},{"line_number":42,"context_line":"Change-Id: I99da2e0aebbcff23d9d1ffccbdd47ee47a02a887"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUH%2F%2Buco%3D","line":39,"updated":"2014-01-22 19:15:36.000000000","message":"No need for the \"sausage-making\" #5.","commit_id":"cb12cd9f38471e7ac52d2245d8e02d15d64231c1"}],"keystone/middleware/core.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"aaae91e85545efff2fbe7e475e10a193a5e81db1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# Environment variable used to pass the request params"},{"line_number":44,"context_line":"PARAMS_ENV \u003d wsgi.PARAMS_ENV"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Filter private fields from parsed params"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def get_filtered_params(params_parsed):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2B8ow%3D","line":46,"updated":"2014-01-20 14:33:36.000000000","message":"Instead of this hash comment, a docstring for the function below would be preferred.","commit_id":"6a6a98d9e440e3b41485fd3f6c3e90a8d891d832"},{"author":{"_account_id":7874,"name":"Venkat Sundaram","email":"tsv@hp.com","username":"tsv"},"change_message_id":"df38071f0abfde596405526172279522461bed53","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# Environment variable used to pass the request params"},{"line_number":44,"context_line":"PARAMS_ENV \u003d wsgi.PARAMS_ENV"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Filter private fields from parsed params"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def get_filtered_params(params_parsed):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2B4aM%3D","line":46,"in_reply_to":"AAAAUH%2F%2B8ow%3D","updated":"2014-01-21 05:50:32.000000000","message":"Done","commit_id":"6a6a98d9e440e3b41485fd3f6c3e90a8d891d832"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"afce66a19bb0178b43b662cf2e165c2cb9abcd94","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"class TokenAuthMiddleware(wsgi.Middleware):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def process_request(self, request):"},{"line_number":68,"context_line":"        token \u003d request.headers.get(AUTH_TOKEN_HEADER)"},{"line_number":69,"context_line":"        context \u003d request.environ.get(CONTEXT_ENV, {})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2B%2B5o%3D","line":66,"updated":"2014-01-20 05:15:20.000000000","message":"Any reason for adding new lines here, and not on lines 197 or 211?","commit_id":"6a6a98d9e440e3b41485fd3f6c3e90a8d891d832"},{"author":{"_account_id":7874,"name":"Venkat Sundaram","email":"tsv@hp.com","username":"tsv"},"change_message_id":"df38071f0abfde596405526172279522461bed53","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"class TokenAuthMiddleware(wsgi.Middleware):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def process_request(self, request):"},{"line_number":68,"context_line":"        token \u003d request.headers.get(AUTH_TOKEN_HEADER)"},{"line_number":69,"context_line":"        context \u003d request.environ.get(CONTEXT_ENV, {})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2B4Zw%3D","line":66,"in_reply_to":"AAAAUH%2F%2B%2B5o%3D","updated":"2014-01-21 05:50:32.000000000","message":"No particular reason. I used the autopep8 tool and that somehow did not update those two places. Have fixed it now. Thanks.","commit_id":"6a6a98d9e440e3b41485fd3f6c3e90a8d891d832"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6b87eb094e17b78da79d6bf25c5219afac6a9ff0","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"class TokenAuthMiddleware(wsgi.Middleware):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def process_request(self, request):"},{"line_number":68,"context_line":"        token \u003d request.headers.get(AUTH_TOKEN_HEADER)"},{"line_number":69,"context_line":"        context \u003d request.environ.get(CONTEXT_ENV, {})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2Bt88%3D","line":66,"in_reply_to":"AAAAUH%2F%2B4Zw%3D","updated":"2014-01-22 20:47:03.000000000","message":"Wondering if those should be pulled out into a separate commit?","commit_id":"6a6a98d9e440e3b41485fd3f6c3e90a8d891d832"}]}