)]}'
{"keystone/api/auth.py":[{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"9091a9185490f0ca932fa0df074f69d78306864f","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                # no protocol for this IdP, so this can\u0027t be the IdP we\u0027re"},{"line_number":345,"context_line":"                # looking for"},{"line_number":346,"context_line":"                continue"},{"line_number":347,"context_line":"            remote_id \u003d flask.request.environ.get(remote_id_name)"},{"line_number":348,"context_line":"            if remote_id:"},{"line_number":349,"context_line":"                break"},{"line_number":350,"context_line":"        if not remote_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_eb399ad7","line":347,"range":{"start_line":347,"start_character":12,"end_line":347,"end_character":65},"updated":"2019-09-03 08:37:54.000000000","message":"IMO instead of changing at L338, you can pass the default value None in the get method like-\nremote_id \u003d flask.request.environ.get(remote_id_name, None)","commit_id":"a5052879c5e039324722e57fcae448d4e9996d1a"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"5119ff3f0b7514b4158173df19c0d49b323e70df","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                # no protocol for this IdP, so this can\u0027t be the IdP we\u0027re"},{"line_number":345,"context_line":"                # looking for"},{"line_number":346,"context_line":"                continue"},{"line_number":347,"context_line":"            remote_id \u003d flask.request.environ.get(remote_id_name)"},{"line_number":348,"context_line":"            if remote_id:"},{"line_number":349,"context_line":"                break"},{"line_number":350,"context_line":"        if not remote_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_44e03afb","line":347,"range":{"start_line":347,"start_character":12,"end_line":347,"end_character":65},"in_reply_to":"7faddb67_8b6346b1","updated":"2019-09-10 16:54:14.000000000","message":"Makes sense.","commit_id":"a5052879c5e039324722e57fcae448d4e9996d1a"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"9df16291d52d36fb9c57e863f6b7646212c3e3f7","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                # no protocol for this IdP, so this can\u0027t be the IdP we\u0027re"},{"line_number":345,"context_line":"                # looking for"},{"line_number":346,"context_line":"                continue"},{"line_number":347,"context_line":"            remote_id \u003d flask.request.environ.get(remote_id_name)"},{"line_number":348,"context_line":"            if remote_id:"},{"line_number":349,"context_line":"                break"},{"line_number":350,"context_line":"        if not remote_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_8b6346b1","line":347,"range":{"start_line":347,"start_character":12,"end_line":347,"end_character":65},"in_reply_to":"7faddb67_eb399ad7","updated":"2019-09-03 08:48:45.000000000","message":"oh, if all continue from L346, then remote_id is never initialized, so adding whatever in L347 is of no use.","commit_id":"a5052879c5e039324722e57fcae448d4e9996d1a"}]}