)]}'
{"id":"openstack%2Fkeystone~679893","triplet_id":"openstack%2Fkeystone~master~I57180272cfd07cf33712d77230e305a8cf107049","project":"openstack/keystone","branch":"master","topic":"bug/1842416","hashtags":[],"change_id":"I57180272cfd07cf33712d77230e305a8cf107049","subject":"Modify the exception for assert_user_enabled","status":"ABANDONED","created":"2019-09-04 03:17:11.000000000","updated":"2021-06-04 18:24:37.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a8d2dc617d9c162d7a33fd9fcdf6c3bb0a1c8600","_number":679893,"virtual_id_number":679893,"owner":{"_account_id":17144,"name":"jun923.gu","email":"gujun1989@126.com","username":"jun923.gu"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":-1,"date":"2019-09-04 05:25:39.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"disliked":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"all":[{"value":-2,"date":"2019-09-17 18:30:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":-1,"date":"2019-09-04 08:32:23.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-04 05:25:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-09-04 08:32:23.000000000","updated_by":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"reviewer":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"state":"REVIEWER"},{"updated":"2019-09-17 18:30:50.000000000","updated_by":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"reviewer":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"state":"REVIEWER"}],"messages":[{"id":"bba3126d66fd5c395b8a1c650232c103f386c998","author":{"_account_id":17144,"name":"jun923.gu","email":"gujun1989@126.com","username":"jun923.gu"},"date":"2019-09-04 03:17:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"94c7e893b53333cdf9d31d75eb2e34a036d12e3d","author":{"_account_id":17144,"name":"jun923.gu","email":"gujun1989@126.com","username":"jun923.gu"},"date":"2019-09-04 03:37:13.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b0a989a3fc7bec1e50f273fb6a5cd1c4abe9dae7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-04 05:25:39.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f2166a7f780e40d6ac18eb5f40be5f24 : FAILURE in 40m 19s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ee20b240f70543779c00ff4b5160f510 : FAILURE in 33m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ec61a46737b2459c9e4a806ebb4e2f3c : SUCCESS in 6m 12s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/3ea487adc2ce4ea8836fcb892885af32 : FAILURE in 30m 38s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d6d7a502bf2b4bf39cdc2980238ec828 : FAILURE in 31m 25s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/a2b21b046f3a4168bfeb9d23075e67cc : FAILURE in 36m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ce19fa7059ff4e3e8f3b6c6f145c1d63 : SUCCESS in 11m 58s\n- tempest-full https://zuul.opendev.org/t/openstack/build/cd3ab0b3e3884313beaf865f9a7537e5 : SUCCESS in 1h 47m 47s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/e40bc6332ad04556b19bde4541598501 : SUCCESS in 1h 00m 15s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/0d8e09e8a16e409a8e9d414f6cd20e1c : SUCCESS in 1h 07m 19s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/f707b64e635845b983581326a63063e6 : SUCCESS in 1h 41m 58s\n- keystone-dsvm-functional https://zuul.opendev.org/t/openstack/build/a4fdb90fe0bd4362aa870c0b304c3c41 : SUCCESS in 31m 54s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/79ae4d59a23c4d00b07510f9260f0861 : SUCCESS in 30m 51s\n- keystone-dsvm-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/9aef06c56f904e9284d2f81ca70bc83c : RETRY_LIMIT in 4m 33s (non-voting)\n- keystone-dsvm-py3-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/4485f121ec474e02b12b35941f923e9a : RETRY_LIMIT in 3m 49s (non-voting)\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/c9e45bf42c8a42729d4b6d1091e10cb5 : SUCCESS in 15m 36s (non-voting)\n- legacy-tempest-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/ead6448c8ceb48ec9da7e7e8cbc675dd : SUCCESS in 1h 42m 48s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/fef7973ca3854b4f93a73209141dc7bb : SUCCESS in 1h 12m 00s","accounts_in_message":[],"_revision_number":2},{"id":"a57a10ae1bc8096bad34192e4a3dfe4bd67a761f","author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"date":"2019-09-04 08:32:23.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"71f1df5281371a9cb61ea25b2f0145ff2adf839d","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-09-17 18:30:50.000000000","message":"Patch Set 2: Code-Review-2\n\nThanks for the patch, but we cannot accept this.\n\nThe code that uses this function explicitly checks for an assertion error, for example:\n\nhttps://opendev.org/openstack/keystone/src/branch/master/keystone/auth/plugins/core.py#L128-L136\nhttps://opendev.org/openstack/keystone/src/branch/master/keystone/trust/core.py#L126-L131\n\nSo we cannot simply change the exception raised since other parts of the code are relying on it.\n\nThe assertion error is always handled by raising an appropriate user-facing error. We cannot directly expose UserDisabled to an end user as that exposes internal information to unauthorized users and creates a security issue.","accounts_in_message":[],"_revision_number":2},{"id":"a8d2dc617d9c162d7a33fd9fcdf6c3bb0a1c8600","tag":"autogenerated:gerrit:abandon","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2021-06-04 18:24:37.000000000","message":"Abandoned\n\nAbandoning since there hasn\u0027t been any recent activity, if anyone wants to continue this work, please feel free to restore this or create a new change.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"17e2940069a82cb6f22acd90882f2b104ca8a463","revisions":{"8bacdcc809b61ae3acc5f92e9411f546910b4642":{"kind":"REWORK","_number":1,"created":"2019-09-04 03:17:11.000000000","uploader":{"_account_id":17144,"name":"jun923.gu","email":"gujun1989@126.com","username":"jun923.gu"},"ref":"refs/changes/93/679893/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/93/679893/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/93/679893/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/93/679893/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/93/679893/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/93/679893/1"}}},"commit":{"parents":[{"commit":"fe39838f712880c336e18eadf320e7c9e2007448","subject":"Merge \"Implement system admin for policy association\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/fe39838f712880c336e18eadf320e7c9e2007448"}]}],"author":{"name":"jun923.gu","email":"gujun1989@126.com","date":"2019-09-04 03:09:34.000000000","tz":480},"committer":{"name":"jun923.gu","email":"gujun1989@126.com","date":"2019-09-04 03:17:07.000000000","tz":480},"subject":"Modify the exception for assert_user_enabled","message":"Modify the exception for assert_user_enabled\n\nWhen user is disabled, assert_user_enabled function will raise\nAssertionError exception that can\u0027t be identified easily by client.\nkeysotne should raise UserDisabled exception.\n\nChange-Id: I57180272cfd07cf33712d77230e305a8cf107049\nRelated-bug: #1842416\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/8bacdcc809b61ae3acc5f92e9411f546910b4642"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/8bacdcc809b61ae3acc5f92e9411f546910b4642"}]},"branch":"refs/heads/master"},"17e2940069a82cb6f22acd90882f2b104ca8a463":{"kind":"REWORK","_number":2,"created":"2019-09-04 03:37:13.000000000","uploader":{"_account_id":17144,"name":"jun923.gu","email":"gujun1989@126.com","username":"jun923.gu"},"ref":"refs/changes/93/679893/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/93/679893/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/93/679893/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/93/679893/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/93/679893/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/93/679893/2"}}},"commit":{"parents":[{"commit":"fe39838f712880c336e18eadf320e7c9e2007448","subject":"Merge \"Implement system admin for policy association\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/fe39838f712880c336e18eadf320e7c9e2007448"}]}],"author":{"name":"jun923.gu","email":"gujun1989@126.com","date":"2019-09-04 03:09:34.000000000","tz":480},"committer":{"name":"jun923.gu","email":"gujun1989@126.com","date":"2019-09-04 03:23:28.000000000","tz":480},"subject":"Modify the exception for assert_user_enabled","message":"Modify the exception for assert_user_enabled\n\nWhen user is disabled, assert_user_enabled function will raise\nAssertionError exception that can\u0027t be identified easily by client.\nkeysotne should raise UserDisabled exception.\n\nChange-Id: I57180272cfd07cf33712d77230e305a8cf107049\nRelated-bug: #1842416\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/17e2940069a82cb6f22acd90882f2b104ca8a463"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/17e2940069a82cb6f22acd90882f2b104ca8a463"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}