)]}'
{"etc/policy.v3cloudsample.json":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"39ed5c89fdb1bce43533106f919b4dd79a7d6ce2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"admin_required\": \"role:admin\","},{"line_number":3,"context_line":"    \"cloud_admin\": \"role:admin and (is_admin_project:True or domain_id:admin_domain_id)\","},{"line_number":4,"context_line":"    \"owner\": \"user_id:%(user_id)s or user_id:%(target.token.user_id)s\","},{"line_number":5,"context_line":"    \"admin_or_owner\": \"(rule:admin_required and domain_id:%(target.token.user.domain.id)s) or rule:owner\","},{"line_number":6,"context_line":"    \"admin_and_matching_domain_id\": \"rule:admin_required and domain_id:%(domain_id)s\","},{"line_number":7,"context_line":"    \"service_admin_or_owner\": \"rule:service_or_admin or rule:owner\","},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    \"default\": \"rule:admin_required\","},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    \"identity:get_limit\": \"\","},{"line_number":12,"context_line":"    \"identity:create_limits\": \"rule:admin_required\","}],"source_content_type":"application/json","patch_set":4,"id":"3fa7e38b_d618f31e","side":"PARENT","line":9,"range":{"start_line":2,"start_character":0,"end_line":9,"end_character":37},"updated":"2019-09-26 13:36:41.000000000","message":"This is just plumbing we don\u0027t need anymore.","commit_id":"ea5d02e8e8db72f189b2ab47b5d9cc877161a460"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"39ed5c89fdb1bce43533106f919b4dd79a7d6ce2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    \"default\": \"rule:admin_required\","},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    \"identity:get_limit\": \"\","},{"line_number":12,"context_line":"    \"identity:create_limits\": \"rule:admin_required\","},{"line_number":13,"context_line":"    \"identity:update_limit\": \"rule:admin_required\","},{"line_number":14,"context_line":"    \"identity:delete_limit\": \"rule:admin_required\","},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    \"domain_admin_matches_domain_role\": \"rule:admin_required and domain_id:%(role.domain_id)s\","},{"line_number":17,"context_line":"    \"get_domain_roles\": \"rule:domain_admin_matches_target_domain_role or rule:project_admin_matches_target_domain_role\","}],"source_content_type":"application/json","patch_set":4,"id":"3fa7e38b_762a5f2c","side":"PARENT","line":14,"range":{"start_line":11,"start_character":0,"end_line":14,"end_character":51},"updated":"2019-09-26 13:36:41.000000000","message":"These can be removed once https://review.opendev.org/#/c/621025/ merges","commit_id":"ea5d02e8e8db72f189b2ab47b5d9cc877161a460"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"39ed5c89fdb1bce43533106f919b4dd79a7d6ce2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    \"identity:update_limit\": \"rule:admin_required\","},{"line_number":14,"context_line":"    \"identity:delete_limit\": \"rule:admin_required\","},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    \"domain_admin_matches_domain_role\": \"rule:admin_required and domain_id:%(role.domain_id)s\","},{"line_number":17,"context_line":"    \"get_domain_roles\": \"rule:domain_admin_matches_target_domain_role or rule:project_admin_matches_target_domain_role\","},{"line_number":18,"context_line":"    \"domain_admin_matches_target_domain_role\": \"rule:admin_required and domain_id:%(target.role.domain_id)s\","},{"line_number":19,"context_line":"    \"project_admin_matches_target_domain_role\": \"rule:admin_required and project_domain_id:%(target.role.domain_id)s\","},{"line_number":20,"context_line":"    \"list_domain_roles\": \"rule:domain_admin_matches_filter_on_list_domain_roles or rule:project_admin_matches_filter_on_list_domain_roles\","},{"line_number":21,"context_line":"    \"domain_admin_matches_filter_on_list_domain_roles\": \"rule:admin_required and domain_id:%(domain_id)s\","},{"line_number":22,"context_line":"    \"project_admin_matches_filter_on_list_domain_roles\": \"rule:admin_required and project_domain_id:%(domain_id)s\","},{"line_number":23,"context_line":"    \"admin_and_matching_prior_role_domain_id\": \"rule:admin_required and domain_id:%(target.prior_role.domain_id)s\","},{"line_number":24,"context_line":"    \"implied_role_matches_prior_role_domain_or_global\": \"(domain_id:%(target.implied_role.domain_id)s or None:%(target.implied_role.domain_id)s)\","},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    \"admin_on_domain_filter\": \"rule:admin_required and domain_id:%(scope.domain.id)s\","},{"line_number":27,"context_line":"    \"admin_on_project_filter\": \"rule:admin_required and project_id:%(scope.project.id)s\","}],"source_content_type":"application/json","patch_set":4,"id":"3fa7e38b_765c9fec","side":"PARENT","line":24,"range":{"start_line":16,"start_character":0,"end_line":24,"end_character":146},"updated":"2019-09-26 13:36:41.000000000","message":"Doesn\u0027t look like these were used anywhere.","commit_id":"ea5d02e8e8db72f189b2ab47b5d9cc877161a460"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"39ed5c89fdb1bce43533106f919b4dd79a7d6ce2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"admin_and_matching_prior_role_domain_id\": \"rule:admin_required and domain_id:%(target.prior_role.domain_id)s\","},{"line_number":24,"context_line":"    \"implied_role_matches_prior_role_domain_or_global\": \"(domain_id:%(target.implied_role.domain_id)s or None:%(target.implied_role.domain_id)s)\","},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    \"admin_on_domain_filter\": \"rule:admin_required and domain_id:%(scope.domain.id)s\","},{"line_number":27,"context_line":"    \"admin_on_project_filter\": \"rule:admin_required and project_id:%(scope.project.id)s\","},{"line_number":28,"context_line":"    \"admin_on_domain_of_project_filter\": \"rule:admin_required and domain_id:%(target.project.domain_id)s\","},{"line_number":29,"context_line":"    \"identity:list_role_assignments_for_tree\": \"rule:cloud_admin or rule:admin_on_domain_of_project_filter\","},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    \"identity:check_token\": \"rule:admin_or_owner\","},{"line_number":32,"context_line":"    \"identity:validate_token\": \"rule:service_admin_or_owner\","}],"source_content_type":"application/json","patch_set":4,"id":"3fa7e38b_d66a337f","side":"PARENT","line":29,"range":{"start_line":26,"start_character":0,"end_line":29,"end_character":108},"updated":"2019-09-26 13:36:41.000000000","message":"Colleen fixed all this in another patch: \n\nhttps://review.opendev.org/#/c/682762/","commit_id":"ea5d02e8e8db72f189b2ab47b5d9cc877161a460"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"39ed5c89fdb1bce43533106f919b4dd79a7d6ce2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \"admin_on_domain_of_project_filter\": \"rule:admin_required and domain_id:%(target.project.domain_id)s\","},{"line_number":29,"context_line":"    \"identity:list_role_assignments_for_tree\": \"rule:cloud_admin or rule:admin_on_domain_of_project_filter\","},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    \"identity:check_token\": \"rule:admin_or_owner\","},{"line_number":32,"context_line":"    \"identity:validate_token\": \"rule:service_admin_or_owner\","},{"line_number":33,"context_line":"    \"identity:validate_token_head\": \"rule:service_or_admin\","},{"line_number":34,"context_line":"    \"identity:revoke_token\": \"rule:admin_or_owner\""},{"line_number":35,"context_line":"}"}],"source_content_type":"application/json","patch_set":4,"id":"3fa7e38b_16fa0bbc","side":"PARENT","line":34,"range":{"start_line":31,"start_character":0,"end_line":34,"end_character":50},"updated":"2019-09-26 13:36:41.000000000","message":"These are the defaults we have in code:\n\nhttps://opendev.org/openstack/keystone/src/branch/master/keystone/common/policies/token.py","commit_id":"ea5d02e8e8db72f189b2ab47b5d9cc877161a460"}],"keystone/tests/unit/test_v3_auth.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"39ed5c89fdb1bce43533106f919b4dd79a7d6ce2","unresolved":false,"context_lines":[{"line_number":2879,"context_line":"        )"},{"line_number":2880,"context_line":""},{"line_number":2881,"context_line":""},{"line_number":2882,"context_line":"class TestTokenRevokeSelfAndAdmin(test_v3.RestfulTestCase):"},{"line_number":2883,"context_line":"    \"\"\"Test token revoke using v3 Identity API by token owner and admin.\"\"\""},{"line_number":2884,"context_line":""},{"line_number":2885,"context_line":"    def load_sample_data(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_36ce2782","line":2882,"updated":"2019-09-26 13:36:41.000000000","message":"I\u0027m pretty sure we can just remove this whole test class. It looks redundant.","commit_id":"6ff63fd457e3ba7ff3a8e98ba3ea0fa5c0ae6de0"}],"keystone/tests/unit/test_v3_protection.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"39ed5c89fdb1bce43533106f919b4dd79a7d6ce2","unresolved":false,"context_lines":[{"line_number":639,"context_line":"        self.get(\u0027/OS-REVOKE/events\u0027, token\u003duser_token, expected_status\u003d403)"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"class IdentityTestv3CloudPolicySample(test_v3.RestfulTestCase,"},{"line_number":643,"context_line":"                                      test_v3.AssignmentTestMixin):"},{"line_number":644,"context_line":"    \"\"\"Test policy enforcement of the sample v3 cloud policy file.\"\"\""},{"line_number":645,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_76ad7f99","line":642,"updated":"2019-09-26 13:36:41.000000000","message":"This whole file can go. I\u0027m only keeping it around so that folks can see all these tests pass with the current defaults, which proves our migration from the old defaults to new defaults somewhat work with the policy.v3cloudsample.json file.","commit_id":"6ff63fd457e3ba7ff3a8e98ba3ea0fa5c0ae6de0"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"5e8843fdfd0370b8ca42e0787ff51fd6e44a3e0a","unresolved":false,"context_lines":[{"line_number":639,"context_line":"        self.get(\u0027/OS-REVOKE/events\u0027, token\u003duser_token, expected_status\u003d403)"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"class IdentityTestv3CloudPolicySample(test_v3.RestfulTestCase,"},{"line_number":643,"context_line":"                                      test_v3.AssignmentTestMixin):"},{"line_number":644,"context_line":"    \"\"\"Test policy enforcement of the sample v3 cloud policy file.\"\"\""},{"line_number":645,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_ee64294c","line":642,"in_reply_to":"3fa7e38b_76ad7f99","updated":"2019-09-27 08:54:02.000000000","message":"++,how about remove it in the new patchset. We have the test result already in this PS.","commit_id":"6ff63fd457e3ba7ff3a8e98ba3ea0fa5c0ae6de0"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"9e0a26e071bd60407df748ecff40d527adf72a07","unresolved":false,"context_lines":[{"line_number":639,"context_line":"        self.get(\u0027/OS-REVOKE/events\u0027, token\u003duser_token, expected_status\u003d403)"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"class IdentityTestv3CloudPolicySample(test_v3.RestfulTestCase,"},{"line_number":643,"context_line":"                                      test_v3.AssignmentTestMixin):"},{"line_number":644,"context_line":"    \"\"\"Test policy enforcement of the sample v3 cloud policy file.\"\"\""},{"line_number":645,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_4ca9a18d","side":"PARENT","line":642,"range":{"start_line":642,"start_character":18,"end_line":642,"end_character":37},"updated":"2019-09-30 18:22:11.000000000","message":"Should we just remove this whole class?","commit_id":"e860c69831289a800a1d7bb52e8621fc460f260b"}],"releasenotes/notes/bug-1806762-08ff9eecdc03c554.yaml":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"9e0a26e071bd60407df748ecff40d527adf72a07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3fa7e38b_ec972d44","line":20,"updated":"2019-09-30 18:22:11.000000000","message":"They need enforce_scope\u003dtrue to actually ensure it works the same though.","commit_id":"fc7aedc1c142c36d31487f1656739bfd4a553c2c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"547ee19585dce9ae108f7aa45b4eb2dac29145b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3fa7e38b_278777b9","line":20,"in_reply_to":"3fa7e38b_ec972d44","updated":"2019-10-02 20:26:24.000000000","message":"Done","commit_id":"fc7aedc1c142c36d31487f1656739bfd4a553c2c"}]}