)]}'
{"id":"openstack%2Fkeystone~682955","triplet_id":"openstack%2Fkeystone~master~Iedccc36b2909d889d9dcb46273ed62cd7c450ad4","project":"openstack/keystone","branch":"master","topic":"bug/1835303","hashtags":[],"change_id":"Iedccc36b2909d889d9dcb46273ed62cd7c450ad4","subject":"\"Unauthorized\" error message needs more hints","status":"ABANDONED","created":"2019-09-18 17:58:09.000000000","updated":"2022-01-21 20:59:48.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"13e9e9cb966f3c41d458a4bc84ce5a80919ca5ba","_number":682955,"virtual_id_number":682955,"owner":{"_account_id":18044,"name":"Abhishek Mahajan","email":"m.abhishek84@gmail.com","username":"mahajan-abhishek"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2019-09-18 17:58:24.000000000","_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"date":"2020-05-13 12:24:16.000000000","_account_id":18044,"name":"Abhishek Mahajan","email":"m.abhishek84@gmail.com","username":"mahajan-abhishek"},{"value":-1,"date":"2019-09-19 02:31:23.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":-1,"date":"2019-09-19 10:29:16.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18044,"name":"Abhishek Mahajan","email":"m.abhishek84@gmail.com","username":"mahajan-abhishek"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":18044,"name":"Abhishek Mahajan","email":"m.abhishek84@gmail.com","username":"mahajan-abhishek"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":18044,"name":"Abhishek Mahajan","email":"m.abhishek84@gmail.com","username":"mahajan-abhishek"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-18 17:58:24.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2019-09-19 02:31:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-09-19 10:29:16.000000000","updated_by":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"reviewer":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"state":"REVIEWER"}],"messages":[{"id":"ffb63e41bb8539937e7a8c3d981e82385258535b","author":{"_account_id":18044,"name":"Abhishek Mahajan","email":"m.abhishek84@gmail.com","username":"mahajan-abhishek"},"date":"2019-09-18 17:58:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e0c72333de7d66debbd3b7ec4a6c4c9dae1f5d45","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2019-09-18 17:58:24.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\nYour patch will now be tested automatically by OpenStack testing frameworks\nand once the automatic tests pass, it will be reviewed by other friendly\ndevelopers. They will give you feedback and may require you to refine it.\n\nPeople seldom get their patch approved on the first try, so don\u0027t be\nconcerned if requested to make corrections. Feel free to modify your patch\nand resubmit a new change-set.\n\nPatches usually take 3 to 7 days to be reviewed so be patient and be\navailable on IRC to ask and answer questions about your work. Also it\ntakes generally at least a couple of weeks for cores to get around to\nreviewing code. The more you participate in the community the more\nrewarding it is for you. You may also notice that the more you get to know\npeople and get to be known, the faster your patches will be reviewed and\neventually approved. Get to know others and become known by doing code\nreviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\nThanks again for supporting OpenStack, we look forward to working with you.\n\nIRC: https://wiki.openstack.org/wiki/IRC\nWorkflow: https://docs.openstack.org/infra/manual/developers.html\nCommit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"9fc77d108d695194c5eef26495ee803618e76eb8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 02:31:23.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/68240bcd45c140678c2a3bd872966184 : SUCCESS in 20m 30s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b7c99b4c850a4a56bc3a6d4ac21121f4 : SUCCESS in 17m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ee5ca07d276643808951a7f9d5093ca4 : SUCCESS in 5m 53s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/c11ad9515f5d4d81b1f144cb7b17db17 : SUCCESS in 14m 06s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c1ae1b7c27a24b8da003723a8517d0b5 : SUCCESS in 1h 05m 04s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/f7ec0a42f059467a898ee4ff335a1e45 : SUCCESS in 17m 14s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/072f1c625ce545b684e71b1cf4124118 : SUCCESS in 13m 18s\n- tempest-full https://zuul.opendev.org/t/openstack/build/b562b3814f224e6d947865be48cd387f : SUCCESS in 1h 39m 30s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/43fa0211cc4e4681b8e81f8e5c167c09 : SUCCESS in 1h 01m 27s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/aa245bfc8e764244bd7f52608d07c755 : FAILURE in 52m 41s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/b77f62b34aa040e4acf28739a3d29f70 : SUCCESS in 1h 23m 29s\n- keystone-dsvm-functional https://zuul.opendev.org/t/openstack/build/8598b840ce5e47baaa92158d85ecfb40 : SUCCESS in 33m 45s\n- keystone-dsvm-py3-functional https://zuul.opendev.org/t/openstack/build/15d8fd93a657401f8b762f7af2e156bb : SUCCESS in 34m 23s\n- keystone-dsvm-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/e08ce66698f840b9a223a6ecec4b128b : SUCCESS in 40m 29s (non-voting)\n- keystone-dsvm-py3-functional-federation-opensuse15 https://zuul.opendev.org/t/openstack/build/fdc24375baf149cfb751aad175b07b2e : SUCCESS in 38m 39s (non-voting)\n- keystoneclient-devstack-functional https://zuul.opendev.org/t/openstack/build/3bcdaf7845bb4fb1911838efc898450e : SUCCESS in 16m 20s (non-voting)\n- legacy-tempest-dsvm-ldap-domain-specific-driver https://zuul.opendev.org/t/openstack/build/df558f90644548babf3152e78e8c5c86 : SUCCESS in 1h 43m 18s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/55774acd903044cea4bb8ed1eaf70b4b : SUCCESS in 1h 02m 38s\n- keystone-tox-protection https://zuul.opendev.org/t/openstack/build/e18b03e2afe442559c2d814fcdda2ee8 : SUCCESS in 33m 10s","accounts_in_message":[],"_revision_number":1},{"id":"255eeaff1fd55488983563ad74c5111100e2af8f","author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"date":"2019-09-19 10:29:16.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nHi Abhishek. Thanks for contributing in keystone. Pl find the below comments. \n\nThis would require a release note too.","accounts_in_message":[],"_revision_number":1},{"id":"f6a82c1ccef935fca0bedec82c6cb62310c999d3","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2019-09-19 17:21:43.000000000","message":"Patch Set 1: Code-Review-1\n\nWe have to be very careful about adding more information to these exceptions. A lot more data is provided if keystone is run in debug mode specifically in \"insecure_debug\" enabled.\n\nIn HTTP parlance, a 401 (Unauthorized) indicates that authentication is required. It may in fact be a failure to authenticate, it may be an expired set of credentials, it may be an expired token, etc.\n\nI agree this specific fix (current patch) is not adding anything meaningful.","accounts_in_message":[],"_revision_number":1},{"id":"bd82b396ac998e704d5a412e667ab0712d4b3de2","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2019-09-19 17:22:56.000000000","message":"Patch Set 1:\n\nAnd to add, I am 100% open to adding more information to the Unauthorized message(s) as long as it\u0027s meaningful to the end user.","accounts_in_message":[],"_revision_number":1},{"id":"2ada02765c906a6d97f4721b0f81896302d81522","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2020-01-28 17:16:27.000000000","message":"Removed reviewer Morgan Fainberg with the following votes:\n\n* Code-Review-1 by Morgan Fainberg \u003cmorgan.fainberg@gmail.com\u003e\n","accounts_in_message":[],"_revision_number":1},{"id":"4f58d8709510057413258eac671a779a4bd84a83","author":{"_account_id":18044,"name":"Abhishek Mahajan","email":"m.abhishek84@gmail.com","username":"mahajan-abhishek"},"date":"2020-05-13 12:24:16.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"13e9e9cb966f3c41d458a4bc84ce5a80919ca5ba","tag":"autogenerated:gerrit:abandon","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2022-01-21 20:59:48.000000000","message":"Abandoned\n\nAbandoning since there hasn\u0027t been any recent activity, if anyone wants to continue this work, please feel free to restore this or create a new change.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a5af128532d6af1617c9ed54244c5a47c5a1829a","revisions":{"a5af128532d6af1617c9ed54244c5a47c5a1829a":{"kind":"REWORK","_number":1,"created":"2019-09-18 17:58:09.000000000","uploader":{"_account_id":18044,"name":"Abhishek Mahajan","email":"m.abhishek84@gmail.com","username":"mahajan-abhishek"},"ref":"refs/changes/55/682955/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/keystone","ref":"refs/changes/55/682955/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/682955/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/682955/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/keystone refs/changes/55/682955/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/keystone refs/changes/55/682955/1"}}},"commit":{"parents":[{"commit":"d8b49d802fa2dcfda97067b54b94a57ab2a35ee6","subject":"Merge \"Use correct repo for initial version check\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/d8b49d802fa2dcfda97067b54b94a57ab2a35ee6"}]}],"author":{"name":"Abhishek Mahajan","email":"m.abhishek84@gmail.com","date":"2019-09-18 17:45:41.000000000","tz":330},"committer":{"name":"Abhishek Mahajan","email":"m.abhishek84@gmail.com","date":"2019-09-18 17:55:28.000000000","tz":330},"subject":"\"Unauthorized\" error message needs more hints","message":"\"Unauthorized\" error message needs more hints\n\nAdded a better text for Unauthorized error msg,\nwhen authorization fails.\n\nChange-Id: Iedccc36b2909d889d9dcb46273ed62cd7c450ad4\nCloses-Bug: #1835303\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/a5af128532d6af1617c9ed54244c5a47c5a1829a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/keystone/commit/a5af128532d6af1617c9ed54244c5a47c5a1829a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}